From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>,
Daniel Martin <consume.noise@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Duggan <aduggan@synaptics.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
linux-input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!
Date: Mon, 16 Mar 2015 10:46:28 -0400 [thread overview]
Message-ID: <CAN+gG=Gn4h=x6SrN1Ui2zAiK2VW8M0e9W1tKUzYJ4Hrtaww+Kg@mail.gmail.com> (raw)
In-Reply-To: <CAN+gG=EaSpH2sG2HYXJMbCfCWOfvyZ9H9GYMBbkCUmKjfOgCPg@mail.gmail.com>
On Mon, Mar 9, 2015 at 3:36 PM, Benjamin Tissoires
<benjamin.tissoires@gmail.com> wrote:
> On Mon, Mar 9, 2015 at 4:24 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>>
>> On 09-03-15 07:46, Dmitry Torokhov wrote:
>>>
>>> On Wed, Feb 25, 2015 at 03:58:20PM +0100, Hans de Goede wrote:
>>>>
>>>> Hi,
>>>>
>>>> On 25-02-15 15:36, Benjamin Tissoires wrote:
>>>>>
>>>>> On Mon, Feb 16, 2015 at 10:23 PM, Benjamin Tissoires
>>>>> <benjamin.tissoires@gmail.com> wrote:
>>>>>>
>>>>>> On Fri, Feb 6, 2015 at 3:04 PM, Benjamin Tissoires
>>>>>> <benjamin.tissoires@redhat.com> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> This is the second episode of the Lenovo 2015 party :)
>>>>>>>
>>>>>>> Thanks to Andrew, we now have an idea within the driver of what are
>>>>>>> the extra
>>>>>>> buttons aimed for, and the patch series looks cleaner.
>>>>>>> Many thanks for your help.
>>>>>>>
>>>>>>> I marked only patches 1/7, 2/7 and 3/7 as stable because they are
>>>>>>> really
>>>>>>> stable fixes. Without the rest of the series, user-space can cope with
>>>>>>> the
>>>>>>> kernel result, and so there is IMO no need to backport too many
>>>>>>> patches in
>>>>>>> stable. I bet distributions will cherry-pick the rest of the series
>>>>>>> however.
>>>>>>>
>>>>>>
>>>>>> Guys,
>>>>>>
>>>>>> any chances we consider this for 3.20 (or whatever it will be
>>>>>> numbered)?
>>>>>> I'd really like to see this accepted upstream in one way or one other
>>>>>> so we will prevent the mess we had to deal with last year.
>>>>>>
>>>>>
>>>>> Hans, Dmitry,
>>>>>
>>>>> well, it's been 3 weeks since I received the loaner I have to support
>>>>> these touchpads. I will have to return it next week or the week after
>>>>> at most. That means that I will not be able to conduct more tests at
>>>>> that point.
>>>>> Can I ask you to please review the series?
>>>>
>>>>
>>>> Ah, sorry I missed you did a v2 (I did review v1).
>>>>
>>>> Series looks good to me and is:
>>>>
>>>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>>
>>> I did a few edits of the patches in the 2 series so I created a separate
>>> branch "synaptics" based on 3.19. I'd appreciate if you could give it q
>>> quick spin before I will send it for 4.0.
>>
>>
>> I don't have access to the hardware in question, but Benjamin does, so
>> we'll have to wait (a bit) for him to wake up :)
>>
>
> It took me a little bit of time to retrieve the laptop and get it tested.
> So far, so good:
> - t440s (2013) shows the correct behavior
> - x1 carbon 3 has the buttons properly forwarded through the
> trackstick interface and are reacting as expected.
>
> Thanks Dmitry!
>
> I've added Daniel to the thread and asked it this morning if he could
> also give a try to the series.
>
It's been a week since this testing request has been made.
So far:
- we pushed that on Fedora 22/rawhide since last Thu, no bad reports since
- our internal IT tested the series on a X250 and W541 with good results
- I recieved other reports from X250 IIRC, no problems so far
I guess it's time to merge this branch in your "next" branch at least.
Cheers,
Benjamin
next prev parent reply other threads:[~2015-03-16 14:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 20:04 [PATCH v2 0/7] New Lenovos 2015 touchpads: party time! Benjamin Tissoires
2015-02-06 20:04 ` [PATCH v2 1/7] Input: synaptics - fix middle button on Lenovo 2015 products Benjamin Tissoires
2015-02-06 20:04 ` [PATCH v2 2/7] Input: synaptics - handle spurious release of trackstick buttons Benjamin Tissoires
2015-02-06 20:04 ` [PATCH v2 3/7] Input: synaptics - do not retrieve the board id on old firmwares Benjamin Tissoires
2015-02-06 20:04 ` [PATCH v2 4/7] Input: synaptics - retrieve the extended capabilities in query $10 Benjamin Tissoires
2015-02-06 20:04 ` [PATCH v2 5/7] Input: synaptics - remove TOPBUTTONPAD property for Lenovos 2015 Benjamin Tissoires
2015-02-06 20:04 ` [PATCH v2 6/7] Input: synaptics - re-route tracksticks buttons on the Lenovo 2015 series Benjamin Tissoires
2015-03-09 6:45 ` Dmitry Torokhov
2015-02-06 20:04 ` [PATCH v2 7/7] Input: synaptics - Remove X1 Carbon 3rd gen from the topbuttonpad list Benjamin Tissoires
2015-02-17 3:23 ` [PATCH v2 0/7] New Lenovos 2015 touchpads: party time! Benjamin Tissoires
2015-02-25 14:36 ` Benjamin Tissoires
2015-02-25 14:58 ` Hans de Goede
2015-03-09 6:46 ` Dmitry Torokhov
2015-03-09 8:24 ` Hans de Goede
2015-03-09 19:36 ` Benjamin Tissoires
2015-03-10 6:17 ` Steven Noonan
2015-03-10 7:23 ` Hans de Goede
2015-03-10 18:35 ` Steven Noonan
2015-03-16 14:46 ` Benjamin Tissoires [this message]
2015-03-19 14:24 ` Yves-Alexis Perez
2015-03-19 14:46 ` Benjamin Tissoires
2015-03-19 15:25 ` Yves-Alexis Perez
2015-03-19 15:58 ` Benjamin Tissoires
2015-03-19 16:47 ` Yves-Alexis Perez
2015-03-19 17:06 ` Benjamin Tissoires
2015-03-19 17:43 ` Dmitry Torokhov
2015-03-19 18:29 ` Benjamin Tissoires
2015-03-20 13:59 ` Yves-Alexis Perez
2015-04-09 12:59 ` Yves-Alexis Perez
2015-04-09 13:56 ` Benjamin Tissoires
2015-02-21 23:22 Michael Mullin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN+gG=Gn4h=x6SrN1Ui2zAiK2VW8M0e9W1tKUzYJ4Hrtaww+Kg@mail.gmail.com' \
--to=benjamin.tissoires@gmail.com \
--cc=aduggan@synaptics.com \
--cc=consume.noise@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).