* RE: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
[not found] <1346350624-27291-1-git-send-email-m-karicheri2@ti.com>
@ 2012-09-07 18:39 ` Karicheri, Muralidharan
2012-09-24 14:36 ` Artem Bityutskiy
2012-09-07 21:28 ` Mike Turquette
1 sibling, 1 reply; 7+ messages in thread
From: Karicheri, Muralidharan @ 2012-09-07 18:39 UTC (permalink / raw)
To: Karicheri, Muralidharan, dwmw2, artem.bityutskiy, dbaryshkov,
computersforpeace, linux-mtd, linux-kernel, mturquette,
davinci-linux-open-source
>> -----Original Message-----
>> From: Karicheri, Muralidharan
>> Sent: Thursday, August 30, 2012 2:17 PM
>> To: dwmw2@infradead.org; artem.bityutskiy@linux.intel.com; dbaryshkov@gmail.com;
>> computersforpeace@gmail.com; linux-mtd@lists.infradead.org; linux-
>> kernel@vger.kernel.org; mturquette@linaro.org
>> Cc: Karicheri, Muralidharan
>> Subject: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
>>
>> As a first step towards migrating davinci platforms to use common clock
>> framework, replace all instances of clk_enable() with clk_prepare_enable()
>> and clk_disable() with clk_disable_unprepare(). Until the platform is
>> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
>> adds a might_sleep() call and would work without any issues.
>>
>> This will make it easy later to switch to common clk based implementation
>> of clk driver from DaVinci specific driver.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>> drivers/mtd/nand/davinci_nand.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index d94b03c..6b8cf27 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -656,7 +656,7 @@ static int __init nand_davinci_probe(struct platform_device
>> *pdev)
>> goto err_clk;
>> }
>>
>> - ret = clk_enable(info->clk);
>> + ret = clk_prepare_enable(info->clk);
>> if (ret < 0) {
>> dev_dbg(&pdev->dev, "unable to enable AEMIF clock, err %d\n",
>> ret);
>> @@ -767,7 +767,7 @@ syndrome_done:
>>
>> err_scan:
>> err_timing:
>> - clk_disable(info->clk);
>> + clk_disable_unprepare(info->clk);
>>
>> err_clk_enable:
>> clk_put(info->clk);
>> @@ -804,7 +804,7 @@ static int __exit nand_davinci_remove(struct platform_device
>> *pdev)
>>
>> nand_release(&info->mtd);
>>
>> - clk_disable(info->clk);
>> + clk_disable_unprepare(info->clk);
>> clk_put(info->clk);
>>
>> kfree(info);
>> --
>> 1.7.9.5
subsystem owner,
Could you please review and apply this patch as needed? We need to get this upstream before submitting the patch for Common clock framework support for mach-davinci. If I need to follow a specific procedure to get this merged, please direct me to a process page.
Thanks.
Murali Karicheri
Software Design Engineer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
[not found] <1346350624-27291-1-git-send-email-m-karicheri2@ti.com>
2012-09-07 18:39 ` [PATCH] mtd:nand:clk: preparation for switch to common clock framework Karicheri, Muralidharan
@ 2012-09-07 21:28 ` Mike Turquette
2012-09-07 21:56 ` Karicheri, Muralidharan
1 sibling, 1 reply; 7+ messages in thread
From: Mike Turquette @ 2012-09-07 21:28 UTC (permalink / raw)
To: Murali Karicheri, dwmw2, artem.bityutskiy, dbaryshkov,
computersforpeace, linux-mtd, linux-kernel
Cc: Murali Karicheri
Quoting Murali Karicheri (2012-08-30 11:17:04)
> As a first step towards migrating davinci platforms to use common clock
> framework, replace all instances of clk_enable() with clk_prepare_enable()
> and clk_disable() with clk_disable_unprepare(). Until the platform is
> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
> adds a might_sleep() call and would work without any issues.
>
> This will make it easy later to switch to common clk based implementation
> of clk driver from DaVinci specific driver.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
> ---
> drivers/mtd/nand/davinci_nand.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index d94b03c..6b8cf27 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -656,7 +656,7 @@ static int __init nand_davinci_probe(struct platform_device *pdev)
> goto err_clk;
> }
>
> - ret = clk_enable(info->clk);
> + ret = clk_prepare_enable(info->clk);
> if (ret < 0) {
> dev_dbg(&pdev->dev, "unable to enable AEMIF clock, err %d\n",
> ret);
> @@ -767,7 +767,7 @@ syndrome_done:
>
> err_scan:
> err_timing:
> - clk_disable(info->clk);
> + clk_disable_unprepare(info->clk);
>
> err_clk_enable:
> clk_put(info->clk);
> @@ -804,7 +804,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev)
>
> nand_release(&info->mtd);
>
> - clk_disable(info->clk);
> + clk_disable_unprepare(info->clk);
> clk_put(info->clk);
>
> kfree(info);
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
2012-09-07 21:28 ` Mike Turquette
@ 2012-09-07 21:56 ` Karicheri, Muralidharan
2012-09-07 23:22 ` Mike Turquette
2012-09-08 0:43 ` Brian Norris
0 siblings, 2 replies; 7+ messages in thread
From: Karicheri, Muralidharan @ 2012-09-07 21:56 UTC (permalink / raw)
To: Mike Turquette, dwmw2, artem.bityutskiy, dbaryshkov,
computersforpeace, linux-mtd, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2738 bytes --]
Mike,
How do these patch get to upstream? Does this get merged through davinci maintainer or through individual subsystem maintainers?
Thanks.
Murali Karicheri
Software Design Engineer
>> -----Original Message-----
>> From: Mike Turquette [mailto:mturquette@linaro.org]
>> Sent: Friday, September 07, 2012 5:29 PM
>> To: Karicheri, Muralidharan; dwmw2@infradead.org; artem.bityutskiy@linux.intel.com;
>> dbaryshkov@gmail.com; computersforpeace@gmail.com; linux-mtd@lists.infradead.org;
>> linux-kernel@vger.kernel.org
>> Cc: Karicheri, Muralidharan
>> Subject: Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
>>
>> Quoting Murali Karicheri (2012-08-30 11:17:04)
>> > As a first step towards migrating davinci platforms to use common clock
>> > framework, replace all instances of clk_enable() with clk_prepare_enable()
>> > and clk_disable() with clk_disable_unprepare(). Until the platform is
>> > switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
>> > adds a might_sleep() call and would work without any issues.
>> >
>> > This will make it easy later to switch to common clk based implementation
>> > of clk driver from DaVinci specific driver.
>> >
>> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Acked-by: Mike Turquette <mturquette@linaro.org>
>>
>> > ---
>> > drivers/mtd/nand/davinci_nand.c | 6 +++---
>> > 1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> > index d94b03c..6b8cf27 100644
>> > --- a/drivers/mtd/nand/davinci_nand.c
>> > +++ b/drivers/mtd/nand/davinci_nand.c
>> > @@ -656,7 +656,7 @@ static int __init nand_davinci_probe(struct platform_device
>> *pdev)
>> > goto err_clk;
>> > }
>> >
>> > - ret = clk_enable(info->clk);
>> > + ret = clk_prepare_enable(info->clk);
>> > if (ret < 0) {
>> > dev_dbg(&pdev->dev, "unable to enable AEMIF clock, err %d\n",
>> > ret);
>> > @@ -767,7 +767,7 @@ syndrome_done:
>> >
>> > err_scan:
>> > err_timing:
>> > - clk_disable(info->clk);
>> > + clk_disable_unprepare(info->clk);
>> >
>> > err_clk_enable:
>> > clk_put(info->clk);
>> > @@ -804,7 +804,7 @@ static int __exit nand_davinci_remove(struct platform_device
>> *pdev)
>> >
>> > nand_release(&info->mtd);
>> >
>> > - clk_disable(info->clk);
>> > + clk_disable_unprepare(info->clk);
>> > clk_put(info->clk);
>> >
>> > kfree(info);
>> > --
>> > 1.7.9.5
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: RE: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
2012-09-07 21:56 ` Karicheri, Muralidharan
@ 2012-09-07 23:22 ` Mike Turquette
2012-09-08 0:43 ` Brian Norris
1 sibling, 0 replies; 7+ messages in thread
From: Mike Turquette @ 2012-09-07 23:22 UTC (permalink / raw)
To: Karicheri, Muralidharan, dwmw2, artem.bityutskiy, dbaryshkov,
computersforpeace, linux-mtd, linux-kernel
Quoting Karicheri, Muralidharan (2012-09-07 14:56:22)
> Mike,
>
> How do these patch get to upstream? Does this get merged through davinci maintainer or through individual subsystem maintainers?
>
What does scripts/get_maintainer.pl tell you?
Also feel free to make my Acked-by into a Reviewed-by. I always ge
those two confused.
Regards,
Mike
cant never remembr
> Thanks.
>
> Murali Karicheri
> Software Design Engineer
>
>
> >> -----Original Message-----
> >> From: Mike Turquette [mailto:mturquette@linaro.org]
> >> Sent: Friday, September 07, 2012 5:29 PM
> >> To: Karicheri, Muralidharan; dwmw2@infradead.org; artem.bityutskiy@linux.intel.com;
> >> dbaryshkov@gmail.com; computersforpeace@gmail.com; linux-mtd@lists.infradead.org;
> >> linux-kernel@vger.kernel.org
> >> Cc: Karicheri, Muralidharan
> >> Subject: Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
> >>
> >> Quoting Murali Karicheri (2012-08-30 11:17:04)
> >> > As a first step towards migrating davinci platforms to use common clock
> >> > framework, replace all instances of clk_enable() with clk_prepare_enable()
> >> > and clk_disable() with clk_disable_unprepare(). Until the platform is
> >> > switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
> >> > adds a might_sleep() call and would work without any issues.
> >> >
> >> > This will make it easy later to switch to common clk based implementation
> >> > of clk driver from DaVinci specific driver.
> >> >
> >> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> >>
> >> Acked-by: Mike Turquette <mturquette@linaro.org>
> >>
> >> > ---
> >> > drivers/mtd/nand/davinci_nand.c | 6 +++---
> >> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> >> > index d94b03c..6b8cf27 100644
> >> > --- a/drivers/mtd/nand/davinci_nand.c
> >> > +++ b/drivers/mtd/nand/davinci_nand.c
> >> > @@ -656,7 +656,7 @@ static int __init nand_davinci_probe(struct platform_device
> >> *pdev)
> >> > goto err_clk;
> >> > }
> >> >
> >> > - ret = clk_enable(info->clk);
> >> > + ret = clk_prepare_enable(info->clk);
> >> > if (ret < 0) {
> >> > dev_dbg(&pdev->dev, "unable to enable AEMIF clock, err %d\n",
> >> > ret);
> >> > @@ -767,7 +767,7 @@ syndrome_done:
> >> >
> >> > err_scan:
> >> > err_timing:
> >> > - clk_disable(info->clk);
> >> > + clk_disable_unprepare(info->clk);
> >> >
> >> > err_clk_enable:
> >> > clk_put(info->clk);
> >> > @@ -804,7 +804,7 @@ static int __exit nand_davinci_remove(struct platform_device
> >> *pdev)
> >> >
> >> > nand_release(&info->mtd);
> >> >
> >> > - clk_disable(info->clk);
> >> > + clk_disable_unprepare(info->clk);
> >> > clk_put(info->clk);
> >> >
> >> > kfree(info);
> >> > --
> >> > 1.7.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
2012-09-07 21:56 ` Karicheri, Muralidharan
2012-09-07 23:22 ` Mike Turquette
@ 2012-09-08 0:43 ` Brian Norris
2012-09-10 14:17 ` Karicheri, Muralidharan
1 sibling, 1 reply; 7+ messages in thread
From: Brian Norris @ 2012-09-08 0:43 UTC (permalink / raw)
To: Karicheri, Muralidharan
Cc: Mike Turquette, dwmw2, artem.bityutskiy, dbaryshkov, linux-mtd,
linux-kernel
On Fri, Sep 7, 2012 at 2:56 PM, Karicheri, Muralidharan
<m-karicheri2@ti.com> wrote:
> How do these patch get to upstream? Does this get merged through davinci maintainer or through individual subsystem maintainers?
I think this driver would be taken by David Woodhouse in his linux-mtd
repo. Usually Artem Bityutskiy gleans the mailing list of patches and
puts them in his l2-mtd-2.6 git repo to help David out. Give it some
time, and I'm sure they'll be taking it. We don't really have a
full-time maintainer!
Brian
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
2012-09-08 0:43 ` Brian Norris
@ 2012-09-10 14:17 ` Karicheri, Muralidharan
0 siblings, 0 replies; 7+ messages in thread
From: Karicheri, Muralidharan @ 2012-09-10 14:17 UTC (permalink / raw)
To: Brian Norris
Cc: Mike Turquette, dwmw2, artem.bityutskiy, dbaryshkov, linux-mtd,
linux-kernel
>> -----Original Message-----
>> From: Brian Norris [mailto:computersforpeace@gmail.com]
>> Sent: Friday, September 07, 2012 8:44 PM
>> To: Karicheri, Muralidharan
>> Cc: Mike Turquette; dwmw2@infradead.org; artem.bityutskiy@linux.intel.com;
>> dbaryshkov@gmail.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
>>
>> On Fri, Sep 7, 2012 at 2:56 PM, Karicheri, Muralidharan
>> <m-karicheri2@ti.com> wrote:
>> > How do these patch get to upstream? Does this get merged through davinci maintainer
>> or through individual subsystem maintainers?
>>
>> I think this driver would be taken by David Woodhouse in his linux-mtd
>> repo. Usually Artem Bityutskiy gleans the mailing list of patches and
>> puts them in his l2-mtd-2.6 git repo to help David out. Give it some
>> time, and I'm sure they'll be taking it. We don't really have a
>> full-time maintainer!
>>
>> Brian
Thanks Brian for your response. Understood. Will wait.
Murali Karicheri
Software Design Engineer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework
2012-09-07 18:39 ` [PATCH] mtd:nand:clk: preparation for switch to common clock framework Karicheri, Muralidharan
@ 2012-09-24 14:36 ` Artem Bityutskiy
0 siblings, 0 replies; 7+ messages in thread
From: Artem Bityutskiy @ 2012-09-24 14:36 UTC (permalink / raw)
To: Karicheri, Muralidharan
Cc: dwmw2, dbaryshkov, computersforpeace, linux-mtd, linux-kernel,
mturquette, davinci-linux-open-source
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
On Fri, 2012-09-07 at 18:39 +0000, Karicheri, Muralidharan wrote:
> subsystem owner,
>
> Could you please review and apply this patch as needed? We need to get
> this upstream before submitting the patch for Common clock framework
> support for mach-davinci. If I need to follow a specific procedure to
> get this merged, please direct me to a process page.
Pushed to l2-mtd.git, thanks!
Artem.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-24 14:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1346350624-27291-1-git-send-email-m-karicheri2@ti.com>
2012-09-07 18:39 ` [PATCH] mtd:nand:clk: preparation for switch to common clock framework Karicheri, Muralidharan
2012-09-24 14:36 ` Artem Bityutskiy
2012-09-07 21:28 ` Mike Turquette
2012-09-07 21:56 ` Karicheri, Muralidharan
2012-09-07 23:22 ` Mike Turquette
2012-09-08 0:43 ` Brian Norris
2012-09-10 14:17 ` Karicheri, Muralidharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).