* [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
@ 2015-05-28 8:58 Anand Moon
2015-05-28 9:19 ` Krzysztof Kozlowski
2015-05-29 10:37 ` Krzysztof Kozlowski
0 siblings, 2 replies; 10+ messages in thread
From: Anand Moon @ 2015-05-28 8:58 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Anand Moon
Enable regulator for usbdrd3_0 and usbdrd3_1
>From the schematic pin diagram USB3_0 and USB3_1
is regulated by LDO9 and LD011.
Fix the boot message of failed.
[ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
[ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
[ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
[ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
[ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
[ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
[ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
[ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
[ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
[ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
[ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
---
This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
---
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 27014bb..a353a58 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -513,3 +513,13 @@
&usbdrd_dwc3_1 {
dr_mode = "otg";
};
+
+&usbdrd3_0 {
+ vdd33-supply = <&ldo9_reg>;
+ vdd10-supply = <&ldo11_reg>;
+};
+
+&usbdrd3_1 {
+ vdd33-supply = <&ldo9_reg>;
+ vdd10-supply = <&ldo11_reg>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-28 8:58 [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
@ 2015-05-28 9:19 ` Krzysztof Kozlowski
2015-05-28 10:28 ` Anand Moon
` (2 more replies)
2015-05-29 10:37 ` Krzysztof Kozlowski
1 sibling, 3 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-28 9:19 UTC (permalink / raw)
To: Anand Moon, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, Russell King, Kukjin Kim
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 28.05.2015 17:58, Anand Moon wrote:
> Enable regulator for usbdrd3_0 and usbdrd3_1
>>From the schematic pin diagram USB3_0 and USB3_1
> is regulated by LDO9 and LD011.
Please reformat statement above to proper sentence(s) without ">" before
"From".
>
> Fix the boot message of failed.
> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>
> ---
> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
> ---
I mentioned this already on previous postings. Let's make an exercise.
Please:
1. Save your email as mbox format (from mailer).
2. Go to a GIT repo with kernel and checkout base branch.
3. git am 0001-the-name-of-file.mbox
4. git show
Do you see the signed-off-by in commit?
The patch itself looks good, thanks for fixing this. Just please fix the
issues with commit message.
By the way:
1. The always-on from LDO9 could be probably removed if the ehci-exynos
driver had regulator consumer implemented.
2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
should proably mention the vdd-supply property.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-28 9:19 ` Krzysztof Kozlowski
@ 2015-05-28 10:28 ` Anand Moon
2015-05-28 23:57 ` Krzysztof Kozlowski
2015-05-29 13:17 ` Anand Moon
2015-05-30 13:53 ` Anand Moon
2 siblings, 1 reply; 10+ messages in thread
From: Anand Moon @ 2015-05-28 10:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Hi Krzysztof,
I will take care of these issue in the future.
-Anand Moon
On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On 28.05.2015 17:58, Anand Moon wrote:
>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>>From the schematic pin diagram USB3_0 and USB3_1
>> is regulated by LDO9 and LD011.
>
> Please reformat statement above to proper sentence(s) without ">" before
> "From".
>
>>
>> Fix the boot message of failed.
>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>
>> ---
>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>> ---
>
> I mentioned this already on previous postings. Let's make an exercise.
> Please:
> 1. Save your email as mbox format (from mailer).
> 2. Go to a GIT repo with kernel and checkout base branch.
> 3. git am 0001-the-name-of-file.mbox
> 4. git show
>
> Do you see the signed-off-by in commit?
>
> The patch itself looks good, thanks for fixing this. Just please fix the
> issues with commit message.
>
> By the way:
> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
> driver had regulator consumer implemented.
> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
> should proably mention the vdd-supply property.
>
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-28 10:28 ` Anand Moon
@ 2015-05-28 23:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-28 23:57 UTC (permalink / raw)
To: Anand Moon
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 28.05.2015 19:28, Anand Moon wrote:
> Hi Krzysztof,
>
> I will take care of these issue in the future.
Thanks. I just found that prefix ">" was added by my email client so
never mind about that but still please write proper sentences (ending
with full stop). :)
Best regards,
Krzysztof
>
> -Anand Moon
>
> On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> On 28.05.2015 17:58, Anand Moon wrote:
>>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>> >From the schematic pin diagram USB3_0 and USB3_1
>>> is regulated by LDO9 and LD011.
>>
>> Please reformat statement above to proper sentence(s) without ">" before
>> "From".
>>
>>>
>>> Fix the boot message of failed.
>>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>>
>>> ---
>>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>>> ---
>>
>> I mentioned this already on previous postings. Let's make an exercise.
>> Please:
>> 1. Save your email as mbox format (from mailer).
>> 2. Go to a GIT repo with kernel and checkout base branch.
>> 3. git am 0001-the-name-of-file.mbox
>> 4. git show
>>
>> Do you see the signed-off-by in commit?
>>
>> The patch itself looks good, thanks for fixing this. Just please fix the
>> issues with commit message.
>>
>> By the way:
>> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
>> driver had regulator consumer implemented.
>> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
>> should proably mention the vdd-supply property.
>>
>> Best regards,
>> Krzysztof
>>
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-28 8:58 [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
2015-05-28 9:19 ` Krzysztof Kozlowski
@ 2015-05-29 10:37 ` Krzysztof Kozlowski
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-29 10:37 UTC (permalink / raw)
To: Anand Moon, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, Russell King, Kukjin Kim
Cc: devicetree, linux-samsung-soc, linux-kernel, linux-arm-kernel
W dniu 28.05.2015 o 17:58, Anand Moon pisze:
> Enable regulator for usbdrd3_0 and usbdrd3_1
> From the schematic pin diagram USB3_0 and USB3_1
> is regulated by LDO9 and LD011.
>
> Fix the boot message of failed.
> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>
Tested on Odroid XU3-Lite board:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-28 9:19 ` Krzysztof Kozlowski
2015-05-28 10:28 ` Anand Moon
@ 2015-05-29 13:17 ` Anand Moon
2015-05-30 13:53 ` Anand Moon
2 siblings, 0 replies; 10+ messages in thread
From: Anand Moon @ 2015-05-29 13:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On 28.05.2015 17:58, Anand Moon wrote:
>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>>From the schematic pin diagram USB3_0 and USB3_1
>> is regulated by LDO9 and LD011.
>
> Please reformat statement above to proper sentence(s) without ">" before
> "From".
>
>>
>> Fix the boot message of failed.
>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>
>> ---
>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>> ---
>
> I mentioned this already on previous postings. Let's make an exercise.
> Please:
> 1. Save your email as mbox format (from mailer).
> 2. Go to a GIT repo with kernel and checkout base branch.
> 3. git am 0001-the-name-of-file.mbox
> 4. git show
>
> Do you see the signed-off-by in commit?
>
> The patch itself looks good, thanks for fixing this. Just please fix the
> issues with commit message.
>
> By the way:
> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
> driver had regulator consumer implemented.
> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
> should proably mention the vdd-supply property.
Hi Krzysztof,
Please find the patch already send by Vivek Gautam
<gautam.vivek@samsung.com> which address this issue.
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266418.html
-Anand Moon
>
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-28 9:19 ` Krzysztof Kozlowski
2015-05-28 10:28 ` Anand Moon
2015-05-29 13:17 ` Anand Moon
@ 2015-05-30 13:53 ` Anand Moon
2015-05-31 6:24 ` Krzysztof Kozlowski
2015-06-07 2:50 ` Anand Moon
2 siblings, 2 replies; 10+ messages in thread
From: Anand Moon @ 2015-05-30 13:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, Linux Kernel
On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On 28.05.2015 17:58, Anand Moon wrote:
>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>>From the schematic pin diagram USB3_0 and USB3_1
>> is regulated by LDO9 and LD011.
>
> Please reformat statement above to proper sentence(s) without ">" before
> "From".
>
>>
>> Fix the boot message of failed.
>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>
>> ---
>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>> ---
>
> I mentioned this already on previous postings. Let's make an exercise.
> Please:
> 1. Save your email as mbox format (from mailer).
> 2. Go to a GIT repo with kernel and checkout base branch.
> 3. git am 0001-the-name-of-file.mbox
> 4. git show
>
> Do you see the signed-off-by in commit?
>
> The patch itself looks good, thanks for fixing this. Just please fix the
> issues with commit message.
>
> By the way:
> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
> driver had regulator consumer implemented.
> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
> should proably mention the vdd-supply property.
Hi Krzysztof,
https://patchwork.kernel.org/patch/4420061/
https://patchwork.kernel.org/patch/4420071/
These patch are missing for this changes to make it work correctly.
Can you share you thought on this.
-Anand Moon
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-30 13:53 ` Anand Moon
@ 2015-05-31 6:24 ` Krzysztof Kozlowski
2015-06-07 2:50 ` Anand Moon
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-31 6:24 UTC (permalink / raw)
To: Anand Moon
Cc: Krzysztof Kozlowski, Mark Rutland, devicetree, linux-samsung-soc,
Russell King, Pawel Moll, Ian Campbell, Linux Kernel,
Rob Herring, Kukjin Kim, Kumar Gala, linux-arm-kernel
2015-05-30 22:53 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> On 28.05.2015 17:58, Anand Moon wrote:
>>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>>>From the schematic pin diagram USB3_0 and USB3_1
>>> is regulated by LDO9 and LD011.
>>
>> Please reformat statement above to proper sentence(s) without ">" before
>> "From".
>>
>>>
>>> Fix the boot message of failed.
>>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>>
>>> ---
>>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>>> ---
>>
>> I mentioned this already on previous postings. Let's make an exercise.
>> Please:
>> 1. Save your email as mbox format (from mailer).
>> 2. Go to a GIT repo with kernel and checkout base branch.
>> 3. git am 0001-the-name-of-file.mbox
>> 4. git show
>>
>> Do you see the signed-off-by in commit?
>>
>> The patch itself looks good, thanks for fixing this. Just please fix the
>> issues with commit message.
>>
>> By the way:
>> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
>> driver had regulator consumer implemented.
>> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
>> should proably mention the vdd-supply property.
>
> Hi Krzysztof,
>
> https://patchwork.kernel.org/patch/4420061/
> https://patchwork.kernel.org/patch/4420071/
>
> These patch are missing for this changes to make it work correctly.
>
> Can you share you thought on this.
They look quite old, it is a pity that they were not merged.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-05-30 13:53 ` Anand Moon
2015-05-31 6:24 ` Krzysztof Kozlowski
@ 2015-06-07 2:50 ` Anand Moon
2015-06-07 3:51 ` Krzysztof Kozlowski
1 sibling, 1 reply; 10+ messages in thread
From: Anand Moon @ 2015-06-07 2:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, Linux Kernel
On 30 May 2015 at 19:23, Anand Moon <linux.amoon@gmail.com> wrote:
> On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> On 28.05.2015 17:58, Anand Moon wrote:
>>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>>>From the schematic pin diagram USB3_0 and USB3_1
>>> is regulated by LDO9 and LD011.
>>
>> Please reformat statement above to proper sentence(s) without ">" before
>> "From".
>>
>>>
>>> Fix the boot message of failed.
>>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>>
>>> ---
>>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>>> ---
>>
>> I mentioned this already on previous postings. Let's make an exercise.
>> Please:
>> 1. Save your email as mbox format (from mailer).
>> 2. Go to a GIT repo with kernel and checkout base branch.
>> 3. git am 0001-the-name-of-file.mbox
>> 4. git show
>>
>> Do you see the signed-off-by in commit?
>>
>> The patch itself looks good, thanks for fixing this. Just please fix the
>> issues with commit message.
>>
>> By the way:
>> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
>> driver had regulator consumer implemented.
>> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
>> should proably mention the vdd-supply property.
>
> Hi Krzysztof,
>
> https://patchwork.kernel.org/patch/4420061/
> https://patchwork.kernel.org/patch/4420071/
>
> These patch are missing for this changes to make it work correctly.
>
> Can you share you thought on this.
>
> -Anand Moon
>
>> Best regards,
>> Krzysztof
>>
>>
Hi Krzysztof
Do you want me to resend this. Along with above.
https://patchwork.kernel.org/patch/4420061/
https://patchwork.kernel.org/patch/4420071/
-Anand Moon
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
2015-06-07 2:50 ` Anand Moon
@ 2015-06-07 3:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-07 3:51 UTC (permalink / raw)
To: Anand Moon
Cc: Krzysztof Kozlowski, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Kukjin Kim, devicetree,
linux-arm-kernel, linux-samsung-soc, Linux Kernel
2015-06-07 11:50 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>
> Hi Krzysztof
>
> Do you want me to resend this. Along with above.
>
> https://patchwork.kernel.org/patch/4420061/
> https://patchwork.kernel.org/patch/4420071/
If Vivek is not planning to continue to work on them then sure, please
take care of them and resend. Then I'll review them.
If you have any other patches which were not applied recently, then
please rebase and resend. There were some changes in Odroid DTS.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-06-07 3:51 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-28 8:58 [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
2015-05-28 9:19 ` Krzysztof Kozlowski
2015-05-28 10:28 ` Anand Moon
2015-05-28 23:57 ` Krzysztof Kozlowski
2015-05-29 13:17 ` Anand Moon
2015-05-30 13:53 ` Anand Moon
2015-05-31 6:24 ` Krzysztof Kozlowski
2015-06-07 2:50 ` Anand Moon
2015-06-07 3:51 ` Krzysztof Kozlowski
2015-05-29 10:37 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).