From: Grant Grundler <grundler@chromium.org>
To: Grant Grundler <grundler@chromium.org>, nic_swsd <nic_swsd@realtek.com>
Cc: Oliver Neukum <oliver@neukum.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] net: usb: log errors to dmesg/syslog
Date: Mon, 18 Jan 2021 22:02:02 +0000 [thread overview]
Message-ID: <CANEJEGsAfz1QSDOQK3vvSGStnXm4XS6Ah_fV4iv7Hgh2MWSjGQ@mail.gmail.com> (raw)
In-Reply-To: <20210116052623.3196274-2-grundler@chromium.org>
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler <grundler@chromium.org> wrote:
>
> Errors in protocol should be logged when the driver aborts operations.
> If the driver can carry on and "humor" the device, then emitting
> the message as debug output level is fine.
>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
> ---
> drivers/net/usb/usbnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 1447da1d5729..bc7b93399bd5 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -887,7 +887,7 @@ int usbnet_open (struct net_device *net)
>
> // insist peer be connected
> if (info->check_connect && (retval = info->check_connect (dev)) < 0) {
> - netif_dbg(dev, ifup, dev->net, "can't open; %d\n", retval);
> + netif_err(dev, ifup, dev->net, "can't open; %d\n", retval);
> goto done;
> }
>
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-18 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 5:26 [PATCH 1/3] net: usb: cdc_ncm: emit dev_err on error paths Grant Grundler
2021-01-16 5:26 ` [PATCH 2/3] net: usb: log errors to dmesg/syslog Grant Grundler
2021-01-18 22:02 ` Grant Grundler [this message]
2021-01-16 5:26 ` [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications Grant Grundler
2021-01-18 22:02 ` Grant Grundler
2021-01-19 1:23 ` Hayes Wang
2021-01-19 21:45 ` Jakub Kicinski
2021-01-20 0:55 ` Grant Grundler
2021-01-20 0:59 ` Grant Grundler
2021-01-20 1:05 ` Jakub Kicinski
2021-01-20 1:14 ` Grant Grundler
2021-01-18 22:01 ` [PATCH 1/3] net: usb: cdc_ncm: emit dev_err on error paths Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANEJEGsAfz1QSDOQK3vvSGStnXm4XS6Ah_fV4iv7Hgh2MWSjGQ@mail.gmail.com \
--to=grundler@chromium.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).