From: Hyunchul Lee <hyc.lee@gmail.com>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steve French <sfrench@samba.org>,
linux-cifs <linux-cifs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH] ksmbd: replace usage of found with dedicated list iterator variable
Date: Fri, 25 Mar 2022 15:58:13 +0900 [thread overview]
Message-ID: <CANFS6banUM8ycVyjTz2rHQCbNFttX6HkDHo-2eEwAei9XEu1XQ@mail.gmail.com> (raw)
In-Reply-To: <20220324071301.60228-1-jakobkoschel@gmail.com>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
2022년 3월 24일 (목) 오후 4:13, Jakob Koschel <jakobkoschel@gmail.com>님이 작성:
>
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
> fs/ksmbd/smb2pdu.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
> index 67e8e28e3fc3..be9606b9a944 100644
> --- a/fs/ksmbd/smb2pdu.c
> +++ b/fs/ksmbd/smb2pdu.c
> @@ -6618,8 +6618,7 @@ int smb2_cancel(struct ksmbd_work *work)
> struct ksmbd_conn *conn = work->conn;
> struct smb2_hdr *hdr = smb2_get_msg(work->request_buf);
> struct smb2_hdr *chdr;
> - struct ksmbd_work *cancel_work = NULL;
> - int canceled = 0;
> + struct ksmbd_work *cancel_work = NULL, *iter;
> struct list_head *command_list;
>
> ksmbd_debug(SMB, "smb2 cancel called on mid %llu, async flags 0x%x\n",
> @@ -6629,11 +6628,11 @@ int smb2_cancel(struct ksmbd_work *work)
> command_list = &conn->async_requests;
>
> spin_lock(&conn->request_lock);
> - list_for_each_entry(cancel_work, command_list,
> + list_for_each_entry(iter, command_list,
> async_request_entry) {
> - chdr = smb2_get_msg(cancel_work->request_buf);
> + chdr = smb2_get_msg(iter->request_buf);
>
> - if (cancel_work->async_id !=
> + if (iter->async_id !=
> le64_to_cpu(hdr->Id.AsyncId))
> continue;
>
> @@ -6641,7 +6640,7 @@ int smb2_cancel(struct ksmbd_work *work)
> "smb2 with AsyncId %llu cancelled command = 0x%x\n",
> le64_to_cpu(hdr->Id.AsyncId),
> le16_to_cpu(chdr->Command));
> - canceled = 1;
> + cancel_work = iter;
> break;
> }
> spin_unlock(&conn->request_lock);
> @@ -6649,24 +6648,24 @@ int smb2_cancel(struct ksmbd_work *work)
> command_list = &conn->requests;
>
> spin_lock(&conn->request_lock);
> - list_for_each_entry(cancel_work, command_list, request_entry) {
> - chdr = smb2_get_msg(cancel_work->request_buf);
> + list_for_each_entry(iter, command_list, request_entry) {
> + chdr = smb2_get_msg(iter->request_buf);
>
> if (chdr->MessageId != hdr->MessageId ||
> - cancel_work == work)
> + iter == work)
> continue;
>
> ksmbd_debug(SMB,
> "smb2 with mid %llu cancelled command = 0x%x\n",
> le64_to_cpu(hdr->MessageId),
> le16_to_cpu(chdr->Command));
> - canceled = 1;
> + cancel_work = iter;
> break;
> }
> spin_unlock(&conn->request_lock);
> }
>
> - if (canceled) {
> + if (cancel_work) {
> cancel_work->state = KSMBD_WORK_CANCELLED;
> if (cancel_work->cancel_fn)
> cancel_work->cancel_fn(cancel_work->cancel_argv);
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
> --
> 2.25.1
>
--
Thanks,
Hyunchul
next prev parent reply other threads:[~2022-03-25 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 7:13 [PATCH] ksmbd: replace usage of found with dedicated list iterator variable Jakob Koschel
2022-03-25 6:58 ` Hyunchul Lee [this message]
2022-03-26 0:49 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANFS6banUM8ycVyjTz2rHQCbNFttX6HkDHo-2eEwAei9XEu1XQ@mail.gmail.com \
--to=hyc.lee@gmail.com \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=h.j.bos@vu.nl \
--cc=jakobkoschel@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).