From: Gonsolo <gonsolo@gmail.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: JP <jp@jpvw.nl>, crope@iki.fi, Sean Young <sean@mess.org>,
linux-media@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] si2157: Add support for Logilink VG0022A.
Date: Thu, 3 Oct 2019 21:51:35 +0200 [thread overview]
Message-ID: <CANL0fFRSNbUhcik7rnhjZ0qUe-tZyzcjY+M1J_iGzUa5jNc9_A@mail.gmail.com> (raw)
In-Reply-To: <20191003164426.6da8538f@coco.lan>
> 1) The firmware file is likely at the Windows driver for this device
> (probably using a different format). It should be possible to get
> it from there.
If you tell me how I'm willing to do this. :)
> 2) Another possibility would be to add a way to tell the si2168 driver
> to not try to load a firmware, using the original one. That would
> require adding a field at si2168_config to allow signalizing to it
> that it should not try to load a firmware file, and add a quirk at
> the af9035 that would set such flag for Logilink VG0022A.
I don't get this. Which firmware, si2168 or si2157?
I'm still for option 3: If there is a bogus chip revision number it's
likely the VG0022A and we can safely set fw to NULL, in which case
everything works.
All already working devices will continue to work as before.
With a low probability there are other devices that will return 0xffff
but a) they didn't work until now and b) they receive a clear message
that they return bogus numbers and this works just for the VG0022A, in
which case this hardware can be tested.
At last, *my* VG0022A will work without a custom kernel which I'm a
big fan of. :))
Are there any counterarguments except that it is not the cleanest
solution in the universe? ;)
--
g
next prev parent reply other threads:[~2019-10-03 19:51 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 10:32 DVB-T2 Stick Gonsolo
2019-02-19 21:30 ` Sean Young
2019-10-01 22:19 ` Gonsolo
2019-10-01 23:52 ` Mauro Carvalho Chehab
2019-10-02 14:13 ` [PATCH] si2157: Add support for Logilink VG0022A Gon Solo
2019-10-02 14:13 ` Gon Solo
2019-10-02 14:27 ` Sean Young
2019-10-02 14:44 ` Gonsolo
2019-10-02 15:06 ` Sean Young
2019-10-02 15:21 ` Gonsolo
2019-10-02 17:23 ` JP
2019-10-02 18:49 ` Mauro Carvalho Chehab
2019-10-03 8:06 ` [PATCH 0/1] Testing timing patch " Gon Solo
2019-10-03 8:06 ` [PATCH 1/1] Test Mauros timing patch Gon Solo
2019-10-03 10:13 ` [PATCH] si2157: Add support for Logilink VG0022A Gonsolo
2019-10-03 10:57 ` Gonsolo
2019-10-03 11:17 ` Mauro Carvalho Chehab
2019-10-03 11:41 ` Gonsolo
2019-10-03 12:49 ` Mauro Carvalho Chehab
2019-10-03 12:52 ` Mauro Carvalho Chehab
2019-10-03 13:02 ` Gon Solo
2019-10-03 13:53 ` Gonsolo
2019-10-03 14:05 ` Mauro Carvalho Chehab
2019-10-03 14:29 ` Gonsolo
2019-10-03 12:01 ` Gon Solo
2019-10-03 12:12 ` Mauro Carvalho Chehab
2019-10-03 12:20 ` Gon Solo
2019-10-03 12:45 ` [PATCH 0/3] " Gon Solo
2019-10-03 12:45 ` [PATCH 1/3] [PATCH] af9035: Better explain how i2c bus speed is computed Gon Solo
2019-10-03 12:45 ` [PATCH 2/3] [PATCH] s2157: Handle bogus chip version Gon Solo
2019-10-03 12:45 ` [PATCH 3/3] [PATCH] af9035: Add Logilink VG0022A id Gon Solo
2019-10-03 11:05 ` [PATCH] si2157: Add support for Logilink VG0022A Mauro Carvalho Chehab
2019-10-03 15:00 ` Gonsolo
2019-10-03 15:02 ` Mauro Carvalho Chehab
2019-10-03 15:17 ` Gonsolo
2019-10-03 16:03 ` Gon Solo
2019-10-03 16:09 ` Mauro Carvalho Chehab
2019-10-03 16:23 ` Gon Solo
2019-10-03 17:42 ` Mauro Carvalho Chehab
2019-10-03 17:49 ` Gonsolo
2019-10-03 18:32 ` Gon Solo
2019-10-03 18:42 ` JP
2019-10-03 18:50 ` Gonsolo
2019-10-03 18:53 ` Gonsolo
2019-10-03 19:19 ` Gonsolo
2019-10-03 19:39 ` Mauro Carvalho Chehab
2019-10-03 19:44 ` Mauro Carvalho Chehab
2019-10-03 19:51 ` Gonsolo [this message]
2019-10-03 20:03 ` Mauro Carvalho Chehab
2019-10-03 20:32 ` Gonsolo
2019-10-04 11:50 ` JP
2019-10-04 12:08 ` Mauro Carvalho Chehab
2019-10-04 13:15 ` [PATCH 1/4] media: si2168: use bits instead of bool for flags Mauro Carvalho Chehab
2019-10-04 13:15 ` [PATCH 2/4] media: si2168: add support for not loading a firmware Mauro Carvalho Chehab
2019-10-04 13:15 ` [PATCH 3/4] media: af9035: add support for Logilink VG0022A Mauro Carvalho Chehab
2019-10-09 21:44 ` Gon Solo
2019-10-09 22:04 ` Gon Solo
2019-10-10 8:23 ` Gon Solo
2019-10-10 9:18 ` Gon Solo
2019-10-10 9:50 ` [PATCH 0/4] Add " Gon Solo
2019-10-10 10:10 ` Mauro Carvalho Chehab
2019-10-10 9:51 ` [PATCH 1/4] si2168: Use bits and convert to kernel-doc format Gon Solo
2019-10-10 9:51 ` [PATCH 2/4] si2157: Add option for not downloading firmware Gon Solo
2019-10-10 9:51 ` [PATCH 3/4] af9035: Make speed computation clear Gon Solo
2019-10-10 9:51 ` [PATCH 4/4] Add support for Logilink VG0022A Gon Solo
2019-10-10 11:44 ` Gon Solo
2019-11-15 18:06 ` Gon Solo
2019-10-04 13:15 ` [PATCH 4/4] media: af9035: add the formula used for the I2C speed Mauro Carvalho Chehab
2019-10-10 10:55 ` [PATCH 1/4] media: si2168: use bits instead of bool for flags Gon Solo
2019-10-10 11:34 ` Mauro Carvalho Chehab
2019-10-10 11:42 ` Mauro Carvalho Chehab
2019-10-04 13:50 ` [PATCH] si2157: Add support for Logilink VG0022A JP
2019-10-04 14:16 ` Mauro Carvalho Chehab
2019-10-03 19:40 ` Gonsolo
2019-10-03 19:52 ` Mauro Carvalho Chehab
2019-10-03 19:57 ` Gonsolo
2019-10-02 15:00 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANL0fFRSNbUhcik7rnhjZ0qUe-tZyzcjY+M1J_iGzUa5jNc9_A@mail.gmail.com \
--to=gonsolo@gmail.com \
--cc=crope@iki.fi \
--cc=jp@jpvw.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).