* [PATCH] hwtracing: coresight: constify attribute_group structures.
@ 2017-07-05 5:49 Arvind Yadav
2017-07-07 15:28 ` Mathieu Poirier
2017-07-10 17:01 ` Mathieu Poirier
0 siblings, 2 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-07-05 5:49 UTC (permalink / raw)
To: gregkh, mathieu.poirier; +Cc: linux-arm-kernel, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2573 288 296 3157 c55 coresight-etm-perf.o
File size After adding 'const':
text data bss dec hex filename
2613 224 296 3133 c3d coresight-etm-perf.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 288a423..e97775d 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -60,7 +60,7 @@ struct etm_event_data {
NULL,
};
-static struct attribute_group etm_pmu_format_group = {
+static const struct attribute_group etm_pmu_format_group = {
.name = "format",
.attrs = etm_config_formats_attr,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hwtracing: coresight: constify attribute_group structures.
2017-07-05 5:49 [PATCH] hwtracing: coresight: constify attribute_group structures Arvind Yadav
@ 2017-07-07 15:28 ` Mathieu Poirier
2017-07-10 5:09 ` Arvind Yadav
2017-07-10 17:01 ` Mathieu Poirier
1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2017-07-07 15:28 UTC (permalink / raw)
To: Arvind Yadav; +Cc: Greg KH, linux-arm-kernel, linux-kernel
On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2573 288 296 3157 c55 coresight-etm-perf.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2613 224 296 3133 c3d coresight-etm-perf.o
Hi Arvind,
Did you find this using an automated tool or simply stumbled on it
while reviewing the code? In case of the former it is usually a good
idea to specify which tool was used in the change log.
Thanks,
Mathieu
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
> NULL,
> };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
> .name = "format",
> .attrs = etm_config_formats_attr,
> };
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hwtracing: coresight: constify attribute_group structures.
2017-07-07 15:28 ` Mathieu Poirier
@ 2017-07-10 5:09 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-07-10 5:09 UTC (permalink / raw)
To: Mathieu Poirier; +Cc: Greg KH, linux-arm-kernel, linux-kernel
Hi Mathieu,
On Friday 07 July 2017 08:58 PM, Mathieu Poirier wrote:
> On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>> attribute_groups are not supposed to change at runtime. All functions
>> working with attribute_groups provided by <linux/sysfs.h> work with const
>> attribute_group. So mark the non-const structs as const.
>>
>> File size before:
>> text data bss dec hex filename
>> 2573 288 296 3157 c55 coresight-etm-perf.o
>>
>> File size After adding 'const':
>> text data bss dec hex filename
>> 2613 224 296 3133 c3d coresight-etm-perf.o
> Hi Arvind,
>
> Did you find this using an automated tool or simply stumbled on it
> while reviewing the code? In case of the former it is usually a good
> idea to specify which tool was used in the change log.
Automated tools are not able to caught this kind of error.
I have fixed same changes in zram ( commit - dfc8ed8d6a).
Minchan Kim suggested me to change all the places where have not
used const. It's good idea have a tool which can able to detect these
kind of error. I will try to create a tool.
>
> Thanks,
> Mathieu
>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
>> index 288a423..e97775d 100644
>> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
>> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
>> @@ -60,7 +60,7 @@ struct etm_event_data {
>> NULL,
>> };
>>
>> -static struct attribute_group etm_pmu_format_group = {
>> +static const struct attribute_group etm_pmu_format_group = {
>> .name = "format",
>> .attrs = etm_config_formats_attr,
>> };
>> --
>> 1.9.1
>>
Thanks,
~arvind
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwtracing: coresight: constify attribute_group structures.
2017-07-05 5:49 [PATCH] hwtracing: coresight: constify attribute_group structures Arvind Yadav
2017-07-07 15:28 ` Mathieu Poirier
@ 2017-07-10 17:01 ` Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2017-07-10 17:01 UTC (permalink / raw)
To: Arvind Yadav; +Cc: Greg KH, linux-arm-kernel, linux-kernel
On 4 July 2017 at 23:49, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2573 288 296 3157 c55 coresight-etm-perf.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2613 224 296 3133 c3d coresight-etm-perf.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 288a423..e97775d 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -60,7 +60,7 @@ struct etm_event_data {
> NULL,
> };
>
> -static struct attribute_group etm_pmu_format_group = {
> +static const struct attribute_group etm_pmu_format_group = {
> .name = "format",
> .attrs = etm_config_formats_attr,
> };
> --
> 1.9.1
>
Applied - thanks.
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-10 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 5:49 [PATCH] hwtracing: coresight: constify attribute_group structures Arvind Yadav
2017-07-07 15:28 ` Mathieu Poirier
2017-07-10 5:09 ` Arvind Yadav
2017-07-10 17:01 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).