From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static
Date: Fri, 22 Mar 2019 10:33:57 -0600 [thread overview]
Message-ID: <CANLsYkw_LoPTK_ahV1fGrJ_6Sok8k6wVwvsEg6Q6jffPKR_bYg@mail.gmail.com> (raw)
In-Reply-To: <20190321151852.10216-1-yuehaibing@huawei.com>
On Thu, 21 Mar 2019 at 09:19, Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
> symbol 'catu_helper_ops' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
> symbol 'catu_ops' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
> index 170fbb6..057627a 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, void *__unused)
> return rc;
> }
>
> -const struct coresight_ops_helper catu_helper_ops = {
> +static const struct coresight_ops_helper catu_helper_ops = {
> .enable = catu_enable,
> .disable = catu_disable,
> };
>
> -const struct coresight_ops catu_ops = {
> +static const struct coresight_ops catu_ops = {
> .helper_ops = &catu_helper_ops,
> };
>
Applied thanks.
Mathieu
> --
> 2.7.0
>
>
prev parent reply other threads:[~2019-03-22 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:18 [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static Yue Haibing
2019-03-22 12:31 ` Suzuki K Poulose
2019-03-22 16:33 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANLsYkw_LoPTK_ahV1fGrJ_6Sok8k6wVwvsEg6Q6jffPKR_bYg@mail.gmail.com \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).