* [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static
@ 2019-03-21 15:18 Yue Haibing
2019-03-22 12:31 ` Suzuki K Poulose
2019-03-22 16:33 ` Mathieu Poirier
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-21 15:18 UTC (permalink / raw)
To: mathieu.poirier, suzuki.poulose, alexander.shishkin
Cc: linux-kernel, linux-arm-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
symbol 'catu_helper_ops' was not declared. Should it be static?
drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
symbol 'catu_ops' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
index 170fbb6..057627a 100644
--- a/drivers/hwtracing/coresight/coresight-catu.c
+++ b/drivers/hwtracing/coresight/coresight-catu.c
@@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, void *__unused)
return rc;
}
-const struct coresight_ops_helper catu_helper_ops = {
+static const struct coresight_ops_helper catu_helper_ops = {
.enable = catu_enable,
.disable = catu_disable,
};
-const struct coresight_ops catu_ops = {
+static const struct coresight_ops catu_ops = {
.helper_ops = &catu_helper_ops,
};
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static
2019-03-21 15:18 [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static Yue Haibing
@ 2019-03-22 12:31 ` Suzuki K Poulose
2019-03-22 16:33 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2019-03-22 12:31 UTC (permalink / raw)
To: yuehaibing, mathieu.poirier, alexander.shishkin
Cc: linux-kernel, linux-arm-kernel
On 03/21/2019 03:18 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
> symbol 'catu_helper_ops' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
> symbol 'catu_ops' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
> index 170fbb6..057627a 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, void *__unused)
> return rc;
> }
>
> -const struct coresight_ops_helper catu_helper_ops = {
> +static const struct coresight_ops_helper catu_helper_ops = {
> .enable = catu_enable,
> .disable = catu_disable,
> };
>
> -const struct coresight_ops catu_ops = {
> +static const struct coresight_ops catu_ops = {
> .helper_ops = &catu_helper_ops,
> };
>
>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static
2019-03-21 15:18 [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static Yue Haibing
2019-03-22 12:31 ` Suzuki K Poulose
@ 2019-03-22 16:33 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2019-03-22 16:33 UTC (permalink / raw)
To: Yue Haibing
Cc: Suzuki K. Poulose, Alexander Shishkin, Linux Kernel Mailing List,
linux-arm-kernel
On Thu, 21 Mar 2019 at 09:19, Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/hwtracing/coresight/coresight-catu.c:488:35: warning:
> symbol 'catu_helper_ops' was not declared. Should it be static?
> drivers/hwtracing/coresight/coresight-catu.c:493:28: warning:
> symbol 'catu_ops' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-catu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
> index 170fbb6..057627a 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -485,12 +485,12 @@ static int catu_disable(struct coresight_device *csdev, void *__unused)
> return rc;
> }
>
> -const struct coresight_ops_helper catu_helper_ops = {
> +static const struct coresight_ops_helper catu_helper_ops = {
> .enable = catu_enable,
> .disable = catu_disable,
> };
>
> -const struct coresight_ops catu_ops = {
> +static const struct coresight_ops catu_ops = {
> .helper_ops = &catu_helper_ops,
> };
>
Applied thanks.
Mathieu
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-22 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 15:18 [PATCH -next] coresight: catu: Make catu_helper_ops and catu_ops static Yue Haibing
2019-03-22 12:31 ` Suzuki K Poulose
2019-03-22 16:33 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).