linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vince Weaver <vince@deater.net>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/3] perf, pt, coresight: Clean up address filter structure
Date: Thu, 18 Jan 2018 11:19:21 -0700	[thread overview]
Message-ID: <CANLsYkxZUtxhSV3Z54CUEJ=bKAe7MPjRP142e-=D5n=UUg9p=Q@mail.gmail.com> (raw)
In-Reply-To: <20180118170633.GG12394@arm.com>

On 18 January 2018 at 10:06, Will Deacon <will.deacon@arm.com> wrote:
> On Thu, Jan 18, 2018 at 09:59:26AM -0700, Mathieu Poirier wrote:
>> On 17 January 2018 at 05:31, Alexander Shishkin
>> <alexander.shishkin@linux.intel.com> wrote:
>> > On Tue, Feb 07, 2017 at 10:50:50AM -0700, Mathieu Poirier wrote:
>> >> > index 39106ae61b..d7a11faac1 100644
>> >> > --- a/kernel/events/core.c
>> >> > +++ b/kernel/events/core.c
>> >> > @@ -8194,7 +8194,8 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
>> >> >   *  * for kernel addresses: <start address>[/<size>]
>> >> >   *  * for object files:     <start address>[/<size>]@</path/to/object/file>
>> >> >   *
>> >> > - * if <size> is not specified, the range is treated as a single address.
>> >> > + * if <size> is not specified or is zero, the range is treated as a single
>> >> > + * address; not valid for ACTION=="filter".
>> >>
>> >> Now that a size of 0 can't be specified with a "filter" action, I'm
>> >> good with that statement.
>> >
>> > Hi Mathieu, I completely lost track of this.
>> >
>> > Following is the commit I found dangilng in one of my local branches.
>> > Does this make sense to you? Thanks!
>>
>> Oh boy!  That's a whole year ago...  Give me some time to wrap my
>> brain around it again.
>
> Do we need anything for SPE, or is this only applicable to certain types of
> tracing PMUs?

As far as I can tell spe_pmu->pmu->nr_addr_filters isn't set anywhere.
A such SPE isn't concerned here.

Mathieu

>
> Will

  reply	other threads:[~2018-01-18 18:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  9:40 [PATCH 0/3] perf: Updates for address filters Alexander Shishkin
2017-01-26  9:40 ` [PATCH 1/3] perf, pt, coresight: Clean up address filter structure Alexander Shishkin
2017-01-26 13:02   ` kbuild test robot
2017-01-26 13:24     ` Alexander Shishkin
2017-01-26 18:26   ` Mathieu Poirier
2017-01-27 12:12     ` Alexander Shishkin
2017-01-27 17:17       ` Mathieu Poirier
2017-02-01 12:46         ` Alexander Shishkin
2017-02-01 21:33           ` Mathieu Poirier
2017-02-01 22:15             ` Mathieu Poirier
2017-02-02 10:42               ` Alexander Shishkin
2017-02-02 17:36                 ` Mathieu Poirier
2017-02-02 16:22             ` Alexander Shishkin
2017-02-07 17:50               ` Mathieu Poirier
     [not found]                 ` <20180117123137.3hlmudzu5eogl53n@ukko.fi.intel.com>
2018-01-18 16:59                   ` Mathieu Poirier
2018-01-18 17:06                     ` Will Deacon
2018-01-18 18:19                       ` Mathieu Poirier [this message]
2018-01-19 18:50                   ` Mathieu Poirier
2017-01-26  9:40 ` [PATCH 2/3] perf: Do error out on a kernel filter on an exclude_filter event Alexander Shishkin
2017-01-26 18:32   ` Mathieu Poirier
2017-02-10  8:33   ` [tip:perf/core] perf/core: " tip-bot for Alexander Shishkin
2017-01-26  9:40 ` [PATCH 3/3] perf: Allow kernel filters on cpu events Alexander Shishkin
2017-01-26 21:38   ` Mathieu Poirier
2017-01-27 12:31     ` Alexander Shishkin
2017-01-27 17:38       ` Mathieu Poirier
2017-02-10  8:07   ` Ingo Molnar
2017-02-14 12:59     ` Alexander Shishkin
2017-02-10  8:34   ` [tip:perf/core] perf/core: Allow kernel filters on CPU events tip-bot for Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANLsYkxZUtxhSV3Z54CUEJ=bKAe7MPjRP142e-=D5n=UUg9p=Q@mail.gmail.com' \
    --to=mathieu.poirier@linaro.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=vince@deater.net \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).