From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
jolsa@kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU
Date: Mon, 29 Aug 2016 09:58:51 -0600 [thread overview]
Message-ID: <CANLsYkyzYaF3Z=MPAwevtosN-XU5BK7qSwppaJ1nBNqT-qoCwA@mail.gmail.com> (raw)
In-Reply-To: <20160828141808.GC32293@krava>
On 28 August 2016 at 08:18, Jiri Olsa <jolsa@redhat.com> wrote:
> On Thu, Aug 25, 2016 at 02:20:40PM -0600, Mathieu Poirier wrote:
>
> SNIP
>
>> perf record -e some_event/@cfg1,@cfg2=config/ ...
>>
>> The above are all valid configuration and will see the strings 'cfg1'
>> and 'cfg2=config' sent to the PMU driver for parsing and interpretation
>> using the existing ioctl() mechanism.
>>
>> The primary customers for this feature are the CoreSight drivers where
>> the selection of a sink (where trace data is accumulated) needs to be
>> done in a previous, and separated step, from the launching of the perf
>> command.
>>
>> As such something that used to be a two-step process:
>>
>> # echo 1 > /sys/bus/coresight/devices/20070000.etr/enable_sink
>> # perf record -e cs_etm//u --per-thread uname
>>
>> is integrated in a single command:
>>
>> # perf record -e cs_etm/@20070000.etr/u --per-thread uname
>>
>> Thanks,
>> Mathieu
>>
>> Changes for V6:
>> - Using sysFS rather than an ioctl() to communicate command line
>> parameters to the CoreSight PMU.
>
> apart from few nits it looks good.. but can't say for patch 2/5 ;-)
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
Many thanks for taking the time to look at this set - your time is
much appreciated.
> thanks,
> jirka
prev parent reply other threads:[~2016-08-29 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 20:20 [PATCH V6 0/5] perf: Driver specific configuration for PMU Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 1/5] perf tools: making coresight PMU listable Mathieu Poirier
2016-08-28 14:16 ` Jiri Olsa
2016-08-29 15:56 ` Mathieu Poirier
2016-08-31 6:58 ` Jiri Olsa
2016-08-25 20:20 ` [PATCH V6 2/5] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 3/5] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 4/5] perf tools: Pushing configuration down to PMU driver Mathieu Poirier
2016-08-25 20:20 ` [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm PMU Mathieu Poirier
2016-08-28 14:16 ` Jiri Olsa
2016-08-29 15:57 ` Mathieu Poirier
2016-08-28 14:18 ` [PATCH V6 0/5] perf: Driver specific configuration for PMU Jiri Olsa
2016-08-29 15:58 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLsYkyzYaF3Z=MPAwevtosN-XU5BK7qSwppaJ1nBNqT-qoCwA@mail.gmail.com' \
--to=mathieu.poirier@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).