* [PATCH] platform/chrome: cros_ec: Log wake events during resume
@ 2022-09-12 21:33 Jameson Thies
2022-09-12 21:37 ` Benson Leung
0 siblings, 1 reply; 2+ messages in thread
From: Jameson Thies @ 2022-09-12 21:33 UTC (permalink / raw)
To: chrome-platform
Cc: linux-kernel, pmalani, bleung, groeck, tzungbi, Jameson Thies
Update cros_ec_report_events_during_suspend to log wake events during
resume by calling pm_wakeup_event.
Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
---
drivers/platform/chrome/cros_ec.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 8aace50d446d..110df0fd4b00 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -349,10 +349,16 @@ EXPORT_SYMBOL(cros_ec_suspend);
static void cros_ec_report_events_during_suspend(struct cros_ec_device *ec_dev)
{
+ bool wake_event;
+
while (ec_dev->mkbp_event_supported &&
- cros_ec_get_next_event(ec_dev, NULL, NULL) > 0)
+ cros_ec_get_next_event(ec_dev, &wake_event, NULL) > 0) {
blocking_notifier_call_chain(&ec_dev->event_notifier,
1, ec_dev);
+
+ if (wake_event && device_may_wakeup(ec_dev->dev))
+ pm_wakeup_event(ec_dev->dev, 0);
+ }
}
/**
--
2.37.2.789.g6183377224-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/chrome: cros_ec: Log wake events during resume
2022-09-12 21:33 [PATCH] platform/chrome: cros_ec: Log wake events during resume Jameson Thies
@ 2022-09-12 21:37 ` Benson Leung
0 siblings, 0 replies; 2+ messages in thread
From: Benson Leung @ 2022-09-12 21:37 UTC (permalink / raw)
To: Jameson Thies; +Cc: chrome-platform, linux-kernel, pmalani, groeck, tzungbi
Hi Jameson,
On Mon, Sep 12, 2022 at 2:34 PM Jameson Thies <jthies@google.com> wrote:
>
> Update cros_ec_report_events_during_suspend to log wake events during
> resume by calling pm_wakeup_event.
>
Minor nit, isn't it more accurate to say that this change "signals" or
"notifies" a wakeup event rather than just log? Log indicates some
print to a logging service, which may happen, but as a side effect of
the actual pm_wakeup_event call, which does something real on its own.
Thanks,
Benson
> Signed-off-by: Jameson Thies <jthies@google.com>
> Reviewed-by: Prashant Malani <pmalani@chromium.org>
> ---
> drivers/platform/chrome/cros_ec.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> index 8aace50d446d..110df0fd4b00 100644
> --- a/drivers/platform/chrome/cros_ec.c
> +++ b/drivers/platform/chrome/cros_ec.c
> @@ -349,10 +349,16 @@ EXPORT_SYMBOL(cros_ec_suspend);
>
> static void cros_ec_report_events_during_suspend(struct cros_ec_device *ec_dev)
> {
> + bool wake_event;
> +
> while (ec_dev->mkbp_event_supported &&
> - cros_ec_get_next_event(ec_dev, NULL, NULL) > 0)
> + cros_ec_get_next_event(ec_dev, &wake_event, NULL) > 0) {
> blocking_notifier_call_chain(&ec_dev->event_notifier,
> 1, ec_dev);
> +
> + if (wake_event && device_may_wakeup(ec_dev->dev))
> + pm_wakeup_event(ec_dev->dev, 0);
> + }
> }
>
> /**
> --
> 2.37.2.789.g6183377224-goog
>
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-12 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 21:33 [PATCH] platform/chrome: cros_ec: Log wake events during resume Jameson Thies
2022-09-12 21:37 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).