* [PATCH] platform/chrome: Make i2c_adapter_names static
@ 2013-11-25 21:14 Olof Johansson
2013-11-25 21:25 ` Benson Leung
0 siblings, 1 reply; 2+ messages in thread
From: Olof Johansson @ 2013-11-25 21:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Olof Johansson, Benson Leung
Not used outside of the file, so declaration should be static. Picked up by
sparse:
drivers/platform/chrome/chromeos_laptop.c:44:12: warning: symbol
'i2c_adapter_names' was not declared. Should it be static?
Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: Benson Leung <bleung@chromium.org>
---
drivers/platform/chrome/chromeos_laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
index 1c2747f119d1..446ef0f9c256 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -41,7 +41,7 @@ static struct i2c_client *als;
static struct i2c_client *tp;
static struct i2c_client *ts;
-const char *i2c_adapter_names[] = {
+static const char *i2c_adapter_names[] = {
"SMBus I801 adapter",
"i915 gmbus vga",
"i915 gmbus panel",
--
1.8.4.1.601.g02b3b1d
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/chrome: Make i2c_adapter_names static
2013-11-25 21:14 [PATCH] platform/chrome: Make i2c_adapter_names static Olof Johansson
@ 2013-11-25 21:25 ` Benson Leung
0 siblings, 0 replies; 2+ messages in thread
From: Benson Leung @ 2013-11-25 21:25 UTC (permalink / raw)
To: Olof Johansson; +Cc: linux-kernel
On Mon, Nov 25, 2013 at 1:14 PM, Olof Johansson <olof@lixom.net> wrote:
> Not used outside of the file, so declaration should be static. Picked up by
> sparse:
>
> drivers/platform/chrome/chromeos_laptop.c:44:12: warning: symbol
> 'i2c_adapter_names' was not declared. Should it be static?
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Benson Leung <bleung@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Thanks,
--
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-25 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-25 21:14 [PATCH] platform/chrome: Make i2c_adapter_names static Olof Johansson
2013-11-25 21:25 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).