* [PATCH] platform: chrome: Fix cros-usbpd-notify notifier
@ 2020-03-04 23:21 Gwendal Grignou
2020-03-05 0:03 ` Benson Leung
2020-03-06 18:46 ` Benson Leung
0 siblings, 2 replies; 3+ messages in thread
From: Gwendal Grignou @ 2020-03-04 23:21 UTC (permalink / raw)
To: bleung, enric.balletbo, jflat; +Cc: linux-kernel, Gwendal Grignou
cros-usbpd-notify notifier was returning NOTIFY_BAD when no host event
was available in the MKBP message.
But MKBP messages are used to transmit other information, so return
NOTIFY_DONE instead, to allow other notifier to be called.
Fixes: ec2daf6e33f9f ("platform: chrome: Add cros-usbpd-notify driver")
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
drivers/platform/chrome/cros_usbpd_notify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
index 3851bbd6e9a39..ca2c0181a1dbf 100644
--- a/drivers/platform/chrome/cros_usbpd_notify.c
+++ b/drivers/platform/chrome/cros_usbpd_notify.c
@@ -84,7 +84,7 @@ static int cros_usbpd_notify_plat(struct notifier_block *nb,
u32 host_event = cros_ec_get_host_event(ec_dev);
if (!host_event)
- return NOTIFY_BAD;
+ return NOTIFY_DONE;
if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
blocking_notifier_call_chain(&cros_usbpd_notifier_list,
--
2.25.0.265.gbab2e86ba0-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform: chrome: Fix cros-usbpd-notify notifier
2020-03-04 23:21 [PATCH] platform: chrome: Fix cros-usbpd-notify notifier Gwendal Grignou
@ 2020-03-05 0:03 ` Benson Leung
2020-03-06 18:46 ` Benson Leung
1 sibling, 0 replies; 3+ messages in thread
From: Benson Leung @ 2020-03-05 0:03 UTC (permalink / raw)
To: Gwendal Grignou
Cc: Enric Balletbo i Serra, Jon Flatley, Linux Kernel, Prashant Malani
Thanks Gwendal. Copying +Prashant Malani as well.
On Wed, Mar 4, 2020 at 3:21 PM Gwendal Grignou <gwendal@chromium.org> wrote:
>
> cros-usbpd-notify notifier was returning NOTIFY_BAD when no host event
> was available in the MKBP message.
> But MKBP messages are used to transmit other information, so return
> NOTIFY_DONE instead, to allow other notifier to be called.
>
> Fixes: ec2daf6e33f9f ("platform: chrome: Add cros-usbpd-notify driver")
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> drivers/platform/chrome/cros_usbpd_notify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
> index 3851bbd6e9a39..ca2c0181a1dbf 100644
> --- a/drivers/platform/chrome/cros_usbpd_notify.c
> +++ b/drivers/platform/chrome/cros_usbpd_notify.c
> @@ -84,7 +84,7 @@ static int cros_usbpd_notify_plat(struct notifier_block *nb,
> u32 host_event = cros_ec_get_host_event(ec_dev);
>
> if (!host_event)
> - return NOTIFY_BAD;
> + return NOTIFY_DONE;
>
> if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
> blocking_notifier_call_chain(&cros_usbpd_notifier_list,
> --
> 2.25.0.265.gbab2e86ba0-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform: chrome: Fix cros-usbpd-notify notifier
2020-03-04 23:21 [PATCH] platform: chrome: Fix cros-usbpd-notify notifier Gwendal Grignou
2020-03-05 0:03 ` Benson Leung
@ 2020-03-06 18:46 ` Benson Leung
1 sibling, 0 replies; 3+ messages in thread
From: Benson Leung @ 2020-03-06 18:46 UTC (permalink / raw)
To: Gwendal Grignou; +Cc: bleung, enric.balletbo, jflat, linux-kernel, pmalani
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
Hi Gwendal,
On Wed, Mar 04, 2020 at 03:21:08PM -0800, Gwendal Grignou wrote:
> cros-usbpd-notify notifier was returning NOTIFY_BAD when no host event
> was available in the MKBP message.
> But MKBP messages are used to transmit other information, so return
> NOTIFY_DONE instead, to allow other notifier to be called.
>
> Fixes: ec2daf6e33f9f ("platform: chrome: Add cros-usbpd-notify driver")
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Queued for v5.7.
Thank you,
Benson
> ---
> drivers/platform/chrome/cros_usbpd_notify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
> index 3851bbd6e9a39..ca2c0181a1dbf 100644
> --- a/drivers/platform/chrome/cros_usbpd_notify.c
> +++ b/drivers/platform/chrome/cros_usbpd_notify.c
> @@ -84,7 +84,7 @@ static int cros_usbpd_notify_plat(struct notifier_block *nb,
> u32 host_event = cros_ec_get_host_event(ec_dev);
>
> if (!host_event)
> - return NOTIFY_BAD;
> + return NOTIFY_DONE;
>
> if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
> blocking_notifier_call_chain(&cros_usbpd_notifier_list,
> --
> 2.25.0.265.gbab2e86ba0-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-06 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 23:21 [PATCH] platform: chrome: Fix cros-usbpd-notify notifier Gwendal Grignou
2020-03-05 0:03 ` Benson Leung
2020-03-06 18:46 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).