linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wanpeng Li <kernellwp@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Rik van Riel" <riel@redhat.com>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>, "Wanpeng Li" <wanpeng.li@hotmail.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting
Date: Wed, 8 Jun 2016 16:04:51 +0800	[thread overview]
Message-ID: <CANRm+CxKOM7Y0rg3=n5=8Z-h3bHRrg3V=LN9gP8dQZupP27c_w@mail.gmail.com> (raw)
In-Reply-To: <20160608075210.GA8970@gmail.com>

2016-06-08 15:52 GMT+08:00 Ingo Molnar <mingo@kernel.org>:
>
> * Wanpeng Li <kernellwp@gmail.com> wrote:
>
>> 2016-06-08 15:22 GMT+08:00 Ingo Molnar <mingo@kernel.org>:
>> >
>> > * Wanpeng Li <kernellwp@gmail.com> wrote:
>> >
>> >> From: Wanpeng Li <wanpeng.li@hotmail.com>
>> >>
>> >> This patch adds guest steal-time support to full dynticks CPU
>> >> time accounting. After the following commit:
>> >>
>> >> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")
>> >>
>> >> ... time sampling became jiffy based, even if it's still listened
>> >> to ring boundaries, so steal_account_process_tick() is reused
>> >> to account how many 'ticks' are stolen-time, after the last accumulation.
>> >
>> > So the 'ring boundary' part still doesn't parse (neither grammatically nor
>> > logically) - please rephrase it because I have no idea what you want to say here.
>>
>> It is original from this slides.
>> http://ertl.jp/~shinpei/conf/ospert13/slides/FredericWeisbecker.pdf,
>> slide 28.
>
> Yes, I now understand that this is meant as 'context tracking is active', but I
> don't understand the way you use it in this changelog's context.
>
> Btw., the grammatically correct way to add that phrase would have been:
>
>  ... time sampling became jiffy based, even if it's still listening to ring
>  boundaries, so steal_account_process_tick() is reused to account how many
>  'ticks' are stolen-time, after the last accumulation.

Thanks, Ingo!

>
> But I still don't understand it, nor did Paolo understand it.
>
> Nor is there any 0/3 boilerplace description that gives some context about what
> these changes are about. Exactly what do you mean by 'add steal-time support' - we
> clearly had that before. So is your patch lifting some limitation? Or was
> steal-time accounting totally inactive with certain dynticks configurations? The
> changelog does not tell us anything about that...

Now I understand why you said "write-only code". vtime(depends on
context tracking) which is just used in full dynamic doesn't account
steal time, however, periodic/nohz idle which not use vtime have codes
account steal time in cputime.c, this patch add the steal time
acccount support in vtime which will be used in full dynamic guest.

Regards,
Wanpeng Li

  reply	other threads:[~2016-06-08  8:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  3:05 [PATCH v5 1/3] KVM: fix steal clock warp during guest cpu hotplug Wanpeng Li
2016-06-08  3:05 ` [PATCH v5 2/3] sched/cputime: Fix prev steal time accouting during " Wanpeng Li
2016-06-08 10:01   ` Paolo Bonzini
2016-06-08 10:59     ` Wanpeng Li
2016-06-08  3:05 ` [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting Wanpeng Li
2016-06-08  7:22   ` Ingo Molnar
2016-06-08  7:27     ` Wanpeng Li
2016-06-08  7:52       ` Ingo Molnar
2016-06-08  8:04         ` Wanpeng Li [this message]
2016-06-08  8:12           ` Wanpeng Li
2016-06-08 10:14   ` Paolo Bonzini
2016-06-08 11:11     ` Wanpeng Li
2016-06-13  3:38     ` Wanpeng Li
2016-06-13  7:55       ` Paolo Bonzini
2016-06-13  8:09         ` Wanpeng Li
2016-06-08 19:05   ` Rik van Riel
2016-06-08 23:57     ` Wanpeng Li
2016-06-09  1:20       ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANRm+CxKOM7Y0rg3=n5=8Z-h3bHRrg3V=LN9gP8dQZupP27c_w@mail.gmail.com' \
    --to=kernellwp@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wanpeng.li@hotmail.com \
    --subject='Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).