linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>, "Wanpeng Li" <wanpeng.li@hotmail.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Rik van Riel" <riel@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting
Date: Mon, 13 Jun 2016 09:55:56 +0200	[thread overview]
Message-ID: <c74951dc-dbbe-3a75-a31b-a1c303520b4b@redhat.com> (raw)
In-Reply-To: <CANRm+CxFRAY8HBAt=OBHpuiyJmtSM+sVBAmB+25dLcDOL=gcPA@mail.gmail.com>



On 13/06/2016 05:38, Wanpeng Li wrote:
> + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap);
> + steal_jiffies = jiffies_to_cputime(steal_account_process_tick(delta_jiffies));

Without jiffies_to_cputime here.  Apart from this, yes, this is what I
meant.

Paolo

>   WARN_ON_ONCE(tsk->vtime_snap_whence == VTIME_INACTIVE);
>   tsk->vtime_snap = now;
> 
> - return jiffies_to_cputime(delta);
> + return jiffies_to_cputime(delta_jiffies - steal_jiffies);

  reply	other threads:[~2016-06-13  7:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  3:05 [PATCH v5 1/3] KVM: fix steal clock warp during guest cpu hotplug Wanpeng Li
2016-06-08  3:05 ` [PATCH v5 2/3] sched/cputime: Fix prev steal time accouting during " Wanpeng Li
2016-06-08 10:01   ` Paolo Bonzini
2016-06-08 10:59     ` Wanpeng Li
2016-06-08  3:05 ` [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting Wanpeng Li
2016-06-08  7:22   ` Ingo Molnar
2016-06-08  7:27     ` Wanpeng Li
2016-06-08  7:52       ` Ingo Molnar
2016-06-08  8:04         ` Wanpeng Li
2016-06-08  8:12           ` Wanpeng Li
2016-06-08 10:14   ` Paolo Bonzini
2016-06-08 11:11     ` Wanpeng Li
2016-06-13  3:38     ` Wanpeng Li
2016-06-13  7:55       ` Paolo Bonzini [this message]
2016-06-13  8:09         ` Wanpeng Li
2016-06-08 19:05   ` Rik van Riel
2016-06-08 23:57     ` Wanpeng Li
2016-06-09  1:20       ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c74951dc-dbbe-3a75-a31b-a1c303520b4b@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wanpeng.li@hotmail.com \
    --subject='Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).