From: Wanpeng Li <kernellwp@gmail.com>
To: linmiaohe <linmiaohe@huawei.com>
Cc: Liran Alon <liran.alon@oracle.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"sean.j.christopherson@intel.com"
<sean.j.christopherson@intel.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"jmattson@google.com" <jmattson@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr_feature()
Date: Fri, 6 Dec 2019 11:10:32 +0800 [thread overview]
Message-ID: <CANRm+CyOxq9S4pjcGzjuTdE+Vp8H+oq3JezihV3CRm8XFXc-ww@mail.gmail.com> (raw)
In-Reply-To: <833788ce05014084af1e6160fb81e5cd@huawei.com>
On Fri, 6 Dec 2019 at 09:54, linmiaohe <linmiaohe@huawei.com> wrote:
>
> >
> >I personally just prefer to remove the “default” case and change this “return 0;” to “return 1;”.
> >But it’s a matter of taste of course.
> >
> Yes. As what " Turnip greens, all have love " said. ^_^
Actually it is a great appreciated to introduce something more useful
instead of tons of cleanups, I saw guys did one cleanup and can incur
several bugs before.
Wanpeng
next prev parent reply other threads:[~2019-12-06 3:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 1:53 [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr_feature() linmiaohe
2019-12-06 3:10 ` Wanpeng Li [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-07 6:53 linmiaohe
2019-12-06 3:41 linmiaohe
2019-12-06 9:58 ` Paolo Bonzini
2019-12-05 2:24 linmiaohe
2019-12-05 10:17 ` Paolo Bonzini
2019-12-05 13:43 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANRm+CyOxq9S4pjcGzjuTdE+Vp8H+oq3JezihV3CRm8XFXc-ww@mail.gmail.com \
--to=kernellwp@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).