From: Paolo Bonzini <pbonzini@redhat.com>
To: linmiaohe <linmiaohe@huawei.com>, Wanpeng Li <kernellwp@gmail.com>
Cc: Liran Alon <liran.alon@oracle.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"sean.j.christopherson@intel.com"
<sean.j.christopherson@intel.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"jmattson@google.com" <jmattson@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr_feature()
Date: Fri, 6 Dec 2019 10:58:53 +0100 [thread overview]
Message-ID: <f7b20a96-0b75-32a4-0448-30c6061fc6cb@redhat.com> (raw)
In-Reply-To: <6c7423896f6f49f2a2b439afe809db08@huawei.com>
On 06/12/19 04:41, linmiaohe wrote:
> Wanpeng Li <kernellwp@gmail.com> wrote:
>>>
>>>>
>>>> I personally just prefer to remove the “default” case and change this “return 0;” to “return 1;”.
>>>> But it’s a matter of taste of course.
>>>>
>>> Yes. As what " Turnip greens, all have love " said. ^_^
>>
>> Actually it is a great appreciated to introduce something more useful instead of tons of cleanups, I saw guys did one cleanup and can incur several bugs before.
>>
> I'd like to introduce something more useful, but side corner cleanups may be hard to
> found out something to introduce. And such cleanups can also be validated by code inspection
> to avoid something bad. Many thanks.
>
Yeah, I think you have been doing a good job. Usually, when the
cleanups introduce bugs there are many other "suspicious" things. For
me it's clear that you're learning the code and not just messing around.
Paolo
next prev parent reply other threads:[~2019-12-06 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 3:41 [PATCH] KVM: vmx: remove unreachable statement in vmx_get_msr_feature() linmiaohe
2019-12-06 9:58 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-07 6:53 linmiaohe
2019-12-06 1:53 linmiaohe
2019-12-06 3:10 ` Wanpeng Li
2019-12-05 2:24 linmiaohe
2019-12-05 10:17 ` Paolo Bonzini
2019-12-05 13:43 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b20a96-0b75-32a4-0448-30c6061fc6cb@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).