* [PATCH] remove unnecessary cache flush on v6 copypage
@ 2011-07-07 2:19 heechul Yun
2011-07-07 9:02 ` Catalin Marinas
0 siblings, 1 reply; 3+ messages in thread
From: heechul Yun @ 2011-07-07 2:19 UTC (permalink / raw)
To: Russell King - ARM Linux, Catalin Marinas; +Cc: linux-arm-kernel, linux-kernel
ARM: mm: remove unnecessary cache flush on v6 copypage
Signed-off-by: Heechul Yun <heechul@illinois.edu>
--
arch/arm/mm/copypage-v6.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/copypage-v6.c b/arch/arm/mm/copypage-v6.c
index bdba6c6..63cca00 100644
--- a/arch/arm/mm/copypage-v6.c
+++ b/arch/arm/mm/copypage-v6.c
@@ -41,7 +41,6 @@ static void v6_copy_user_highpage_nonaliasing(struct page *to,
kfrom = kmap_atomic(from, KM_USER0);
kto = kmap_atomic(to, KM_USER1);
copy_page(kto, kfrom);
- __cpuc_flush_dcache_area(kto, PAGE_SIZE);
kunmap_atomic(kto, KM_USER1);
kunmap_atomic(kfrom, KM_USER0);
}
--
Heechul
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remove unnecessary cache flush on v6 copypage
2011-07-07 2:19 [PATCH] remove unnecessary cache flush on v6 copypage heechul Yun
@ 2011-07-07 9:02 ` Catalin Marinas
2011-07-07 10:31 ` saeed bishara
0 siblings, 1 reply; 3+ messages in thread
From: Catalin Marinas @ 2011-07-07 9:02 UTC (permalink / raw)
To: heechul Yun; +Cc: Russell King - ARM Linux, linux-arm-kernel, linux-kernel
On Thursday, July 7, 2011, heechul Yun <heechul@illinois.edu> wrote:
> ARM: mm: remove unnecessary cache flush on v6 copypage
>
> Signed-off-by: Heechul Yun <heechul@illinois.edu>
I would clarify the commit log a bit stating that this flush is no
longer necessary because of commit c0177800. We had a good reason for
adding the flush initially.
Otherwise,
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove unnecessary cache flush on v6 copypage
2011-07-07 9:02 ` Catalin Marinas
@ 2011-07-07 10:31 ` saeed bishara
0 siblings, 0 replies; 3+ messages in thread
From: saeed bishara @ 2011-07-07 10:31 UTC (permalink / raw)
To: Catalin Marinas
Cc: heechul Yun, Russell King - ARM Linux, linux-arm-kernel, linux-kernel
On Thu, Jul 7, 2011 at 12:02 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> On Thursday, July 7, 2011, heechul Yun <heechul@illinois.edu> wrote:
>> ARM: mm: remove unnecessary cache flush on v6 copypage
I think you better mention that this is regarding v6 nonaliasing mode.
>>
>> Signed-off-by: Heechul Yun <heechul@illinois.edu>
>
> I would clarify the commit log a bit stating that this flush is no
> longer necessary because of commit c0177800. We had a good reason for
> adding the flush initially.
I agree, but I would also mention that the flush was needed in order
to coherent between dcache and icache, and now this is being handled
by __sync_icache_dcache
saeed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-07 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-07 2:19 [PATCH] remove unnecessary cache flush on v6 copypage heechul Yun
2011-07-07 9:02 ` Catalin Marinas
2011-07-07 10:31 ` saeed bishara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).