* [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line
@ 2018-02-25 12:46 Miguel Ojeda
2018-02-25 18:13 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2018-02-25 12:46 UTC (permalink / raw)
To: triad, linux-kernel
There was a missing first line and a missing member,
which gave a warning under W=1:
CC drivers/auxdisplay/arm-charlcd.o
drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand
* @dev: a pointer back to containing device on line 57 - I thought
it was a doc line
Cc: Linus Walleij <triad@df.lth.se>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
---
Please let me know if anyone does not want this in 4.17.
drivers/auxdisplay/arm-charlcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
index b3176ee92b90..27cf08a05e93 100644
--- a/drivers/auxdisplay/arm-charlcd.c
+++ b/drivers/auxdisplay/arm-charlcd.c
@@ -54,12 +54,14 @@
#define HD_BUSY_FLAG 0x80U
/**
+ * struct charlcd
* @dev: a pointer back to containing device
* @phybase: the offset to the controller in physical memory
* @physize: the size of the physical page
* @virtbase: the offset to the controller in virtual memory
* @irq: reserved interrupt number
* @complete: completion structure for the last LCD command
+ * @init_work: delayed work structure to initialize the display on boot
*/
struct charlcd {
struct device *dev;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line
2018-02-25 12:46 [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line Miguel Ojeda
@ 2018-02-25 18:13 ` Randy Dunlap
2018-02-25 19:49 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2018-02-25 18:13 UTC (permalink / raw)
To: Miguel Ojeda, triad, linux-kernel
On 02/25/2018 04:46 AM, Miguel Ojeda wrote:
> There was a missing first line and a missing member,
> which gave a warning under W=1:
>
> CC drivers/auxdisplay/arm-charlcd.o
> drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand
> * @dev: a pointer back to containing device on line 57 - I thought
> it was a doc line
>
> Cc: Linus Walleij <triad@df.lth.se>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> ---
> Please let me know if anyone does not want this in 4.17.
>
> drivers/auxdisplay/arm-charlcd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
> index b3176ee92b90..27cf08a05e93 100644
> --- a/drivers/auxdisplay/arm-charlcd.c
> +++ b/drivers/auxdisplay/arm-charlcd.c
> @@ -54,12 +54,14 @@
> #define HD_BUSY_FLAG 0x80U
>
> /**
> + * struct charlcd
Can you make that more like:
* struct charlcd - <some brief description>
please. And merged soon would be fine.
> * @dev: a pointer back to containing device
> * @phybase: the offset to the controller in physical memory
> * @physize: the size of the physical page
> * @virtbase: the offset to the controller in virtual memory
> * @irq: reserved interrupt number
> * @complete: completion structure for the last LCD command
> + * @init_work: delayed work structure to initialize the display on boot
> */
> struct charlcd {
> struct device *dev;
>
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line
2018-02-25 18:13 ` Randy Dunlap
@ 2018-02-25 19:49 ` Miguel Ojeda
0 siblings, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2018-02-25 19:49 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linus Walleij, linux-kernel
On Sun, Feb 25, 2018 at 7:13 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 02/25/2018 04:46 AM, Miguel Ojeda wrote:
>> There was a missing first line and a missing member,
>> which gave a warning under W=1:
>>
>> CC drivers/auxdisplay/arm-charlcd.o
>> drivers/auxdisplay/arm-charlcd.c:57: warning: Cannot understand
>> * @dev: a pointer back to containing device on line 57 - I thought
>> it was a doc line
>>
>> Cc: Linus Walleij <triad@df.lth.se>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>> ---
>> Please let me know if anyone does not want this in 4.17.
>>
>> drivers/auxdisplay/arm-charlcd.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
>> index b3176ee92b90..27cf08a05e93 100644
>> --- a/drivers/auxdisplay/arm-charlcd.c
>> +++ b/drivers/auxdisplay/arm-charlcd.c
>> @@ -54,12 +54,14 @@
>> #define HD_BUSY_FLAG 0x80U
>>
>> /**
>> + * struct charlcd
>
> Can you make that more like:
> * struct charlcd - <some brief description>
>
> please. And merged soon would be fine.
>
Sure! I will do:
/**
+ * struct charlcd - Private data structure
* @dev: a pointer back to containing device
Cheers,
Miguel
>> * @dev: a pointer back to containing device
>> * @phybase: the offset to the controller in physical memory
>> * @physize: the size of the physical page
>> * @virtbase: the offset to the controller in virtual memory
>> * @irq: reserved interrupt number
>> * @complete: completion structure for the last LCD command
>> + * @init_work: delayed work structure to initialize the display on boot
>> */
>> struct charlcd {
>> struct device *dev;
>>
>
> thanks,
> --
> ~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-25 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-25 12:46 [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line Miguel Ojeda
2018-02-25 18:13 ` Randy Dunlap
2018-02-25 19:49 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).