* [PATCH TRIVIAL] Punctuation fixes @ 2018-09-12 3:53 Diego Viola 2018-09-22 15:56 ` Diego Viola 0 siblings, 1 reply; 8+ messages in thread From: Diego Viola @ 2018-09-12 3:53 UTC (permalink / raw) To: corbet; +Cc: linux-kernel, trivial, Diego Viola Signed-off-by: Diego Viola <diego.viola@gmail.com> --- CREDITS | 2 +- MAINTAINERS | 2 +- Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CREDITS b/CREDITS index 5befd2d71..b82efb36d 100644 --- a/CREDITS +++ b/CREDITS @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/ W: http://www.linuxdiskcert.org/ D: Random SMP kernel hacker... D: Uniform Multi-Platform E-IDE driver -D: Active-ATA-Chipset maddness.......... +D: Active-ATA-Chipset maddness... D: Ultra DMA 133/100/66/33 w/48-bit Addressing D: ATA-Disconnect, ATA-TCQ D: ATA-Smart Kernel Daemon diff --git a/MAINTAINERS b/MAINTAINERS index d870cb57c..6567bf245 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -93,7 +93,7 @@ Descriptions of section entries: Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. Odd Fixes: It has a maintainer but they don't have time to do - much other than throw the odd patch in. See below.. + much other than throw the odd patch in. See below. Orphan: No current maintainer [but maybe you could take the role as you write your new code]. Obsolete: Old code. Something tagged obsolete generally means diff --git a/Makefile b/Makefile index 4d5c883a9..7b5c5d634 100644 --- a/Makefile +++ b/Makefile @@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic prepare0: archprepare gcc-plugins $(Q)$(MAKE) $(build)=. -# All the preparing.. +# All the preparing... prepare: prepare0 prepare-objtool # Support for using generic headers in asm-generic -- 2.19.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-12 3:53 [PATCH TRIVIAL] Punctuation fixes Diego Viola @ 2018-09-22 15:56 ` Diego Viola 2018-09-23 0:58 ` Miguel Ojeda 0 siblings, 1 reply; 8+ messages in thread From: Diego Viola @ 2018-09-22 15:56 UTC (permalink / raw) To: corbet; +Cc: linux-kernel, trivial On Wed, Sep 12, 2018 at 12:54 AM Diego Viola <diego.viola@gmail.com> wrote: > > Signed-off-by: Diego Viola <diego.viola@gmail.com> > --- > CREDITS | 2 +- > MAINTAINERS | 2 +- > Makefile | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/CREDITS b/CREDITS > index 5befd2d71..b82efb36d 100644 > --- a/CREDITS > +++ b/CREDITS > @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/ > W: http://www.linuxdiskcert.org/ > D: Random SMP kernel hacker... > D: Uniform Multi-Platform E-IDE driver > -D: Active-ATA-Chipset maddness.......... > +D: Active-ATA-Chipset maddness... > D: Ultra DMA 133/100/66/33 w/48-bit Addressing > D: ATA-Disconnect, ATA-TCQ > D: ATA-Smart Kernel Daemon > diff --git a/MAINTAINERS b/MAINTAINERS > index d870cb57c..6567bf245 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -93,7 +93,7 @@ Descriptions of section entries: > Supported: Someone is actually paid to look after this. > Maintained: Someone actually looks after it. > Odd Fixes: It has a maintainer but they don't have time to do > - much other than throw the odd patch in. See below.. > + much other than throw the odd patch in. See below. > Orphan: No current maintainer [but maybe you could take the > role as you write your new code]. > Obsolete: Old code. Something tagged obsolete generally means > diff --git a/Makefile b/Makefile > index 4d5c883a9..7b5c5d634 100644 > --- a/Makefile > +++ b/Makefile > @@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic > prepare0: archprepare gcc-plugins > $(Q)$(MAKE) $(build)=. > > -# All the preparing.. > +# All the preparing... > prepare: prepare0 prepare-objtool > > # Support for using generic headers in asm-generic > -- > 2.19.0 > Jonathan, can you please merge my patch? After you merge this one, I'll go through the rest of the documentation to make it more consistent. Diego ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-22 15:56 ` Diego Viola @ 2018-09-23 0:58 ` Miguel Ojeda 2018-09-23 8:59 ` Richard Weinberger 2018-09-24 23:33 ` Diego Viola 0 siblings, 2 replies; 8+ messages in thread From: Miguel Ojeda @ 2018-09-23 0:58 UTC (permalink / raw) To: Diego Viola; +Cc: Jonathan Corbet, linux-kernel, trivial Hi Diego, A few things, since it looks like this is your first patch. On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola <diego.viola@gmail.com> wrote: > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola <diego.viola@gmail.com> wrote: >> >> Signed-off-by: Diego Viola <diego.viola@gmail.com> >> --- >> CREDITS | 2 +- >> MAINTAINERS | 2 +- >> Makefile | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/CREDITS b/CREDITS >> index 5befd2d71..b82efb36d 100644 >> --- a/CREDITS >> +++ b/CREDITS >> @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/ >> W: http://www.linuxdiskcert.org/ >> D: Random SMP kernel hacker... >> D: Uniform Multi-Platform E-IDE driver >> -D: Active-ATA-Chipset maddness.......... >> +D: Active-ATA-Chipset maddness... I think the extra dots is what was intended here :) >> D: Ultra DMA 133/100/66/33 w/48-bit Addressing >> D: ATA-Disconnect, ATA-TCQ >> D: ATA-Smart Kernel Daemon >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d870cb57c..6567bf245 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -93,7 +93,7 @@ Descriptions of section entries: >> Supported: Someone is actually paid to look after this. >> Maintained: Someone actually looks after it. >> Odd Fixes: It has a maintainer but they don't have time to do >> - much other than throw the odd patch in. See below.. >> + much other than throw the odd patch in. See below. >> Orphan: No current maintainer [but maybe you could take the >> role as you write your new code]. >> Obsolete: Old code. Something tagged obsolete generally means >> diff --git a/Makefile b/Makefile >> index 4d5c883a9..7b5c5d634 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic >> prepare0: archprepare gcc-plugins >> $(Q)$(MAKE) $(build)=. >> >> -# All the preparing.. >> +# All the preparing... >> prepare: prepare0 prepare-objtool >> >> # Support for using generic headers in asm-generic >> -- >> 2.19.0 >> > > Jonathan, > > can you please merge my patch? After you merge this one, I'll go > through the rest of the documentation to make it more consistent. Jonathan is not responsible for these files. Jiri Kosina is the maintainer of the trivial tree. There are 1700+ instances of a "two-stops ellipsis" in the kernel. I am not sure they were mistakes, given their prevalence, even if they are not formal/common English. Also, I am not sure a commit for each 3 is really appropriate! :) Maybe do the full sweep of the Documentation ones in a single patch? Also, typically you would note in the subject that this is a "v2" of your previous patch (if I am not wrong, you sent a first version fixing only one of the 3 mistakes). Thanks for your first patch! Cheers, Miguel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-23 0:58 ` Miguel Ojeda @ 2018-09-23 8:59 ` Richard Weinberger 2018-09-23 11:24 ` Miguel Ojeda 2018-09-25 0:09 ` Diego Viola 2018-09-24 23:33 ` Diego Viola 1 sibling, 2 replies; 8+ messages in thread From: Richard Weinberger @ 2018-09-23 8:59 UTC (permalink / raw) To: Miguel Ojeda Sandonis Cc: Diego Viola, Jonathan Corbet, LKML, Trivial patch monkey On Sun, Sep 23, 2018 at 3:00 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > Hi Diego, > > A few things, since it looks like this is your first patch. git log... > On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola <diego.viola@gmail.com> wrote: > > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola <diego.viola@gmail.com> wrote: > >> > >> Signed-off-by: Diego Viola <diego.viola@gmail.com> > >> --- > >> CREDITS | 2 +- > >> MAINTAINERS | 2 +- > >> Makefile | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/CREDITS b/CREDITS > >> index 5befd2d71..b82efb36d 100644 > >> --- a/CREDITS > >> +++ b/CREDITS > >> @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/ > >> W: http://www.linuxdiskcert.org/ > >> D: Random SMP kernel hacker... > >> D: Uniform Multi-Platform E-IDE driver > >> -D: Active-ATA-Chipset maddness.......... > >> +D: Active-ATA-Chipset maddness... > > I think the extra dots is what was intended here :) Diego, I know you can do better. :-) How about running linux-next and hunting down regressions? I think we suggested this already on IRC. -- Thanks, //richard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-23 8:59 ` Richard Weinberger @ 2018-09-23 11:24 ` Miguel Ojeda 2018-09-25 0:09 ` Diego Viola 1 sibling, 0 replies; 8+ messages in thread From: Miguel Ojeda @ 2018-09-23 11:24 UTC (permalink / raw) To: Richard Weinberger Cc: Diego Viola, Jonathan Corbet, LKML, Trivial patch monkey Hi Richard, On Sun, Sep 23, 2018 at 10:59 AM, Richard Weinberger <richard.weinberger@gmail.com> wrote: > On Sun, Sep 23, 2018 at 3:00 AM Miguel Ojeda > <miguel.ojeda.sandonis@gmail.com> wrote: >> >> Hi Diego, >> >> A few things, since it looks like this is your first patch. > > git log... Oops! I guess I mistyped the search string, sorry Diego! Cheers, Miguel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-23 8:59 ` Richard Weinberger 2018-09-23 11:24 ` Miguel Ojeda @ 2018-09-25 0:09 ` Diego Viola 2018-09-25 6:41 ` Richard Weinberger 1 sibling, 1 reply; 8+ messages in thread From: Diego Viola @ 2018-09-25 0:09 UTC (permalink / raw) To: richard.weinberger; +Cc: miguel.ojeda.sandonis, corbet, linux-kernel, trivial On Sun, Sep 23, 2018 at 5:59 AM Richard Weinberger <richard.weinberger@gmail.com> wrote: > > On Sun, Sep 23, 2018 at 3:00 AM Miguel Ojeda > <miguel.ojeda.sandonis@gmail.com> wrote: > > > > Hi Diego, > > > > A few things, since it looks like this is your first patch. > > git log... > > > On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola <diego.viola@gmail.com> wrote: > > > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola <diego.viola@gmail.com> wrote: > > >> > > >> Signed-off-by: Diego Viola <diego.viola@gmail.com> > > >> --- > > >> CREDITS | 2 +- > > >> MAINTAINERS | 2 +- > > >> Makefile | 2 +- > > >> 3 files changed, 3 insertions(+), 3 deletions(-) > > >> > > >> diff --git a/CREDITS b/CREDITS > > >> index 5befd2d71..b82efb36d 100644 > > >> --- a/CREDITS > > >> +++ b/CREDITS > > >> @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/ > > >> W: http://www.linuxdiskcert.org/ > > >> D: Random SMP kernel hacker... > > >> D: Uniform Multi-Platform E-IDE driver > > >> -D: Active-ATA-Chipset maddness.......... > > >> +D: Active-ATA-Chipset maddness... > > > > I think the extra dots is what was intended here :) > > Diego, I know you can do better. :-) > How about running linux-next and hunting down regressions? > I think we suggested this already on IRC. OK. I'll do that after I'm done with the documentation. > > -- > Thanks, > //richard Thanks, Diego ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-25 0:09 ` Diego Viola @ 2018-09-25 6:41 ` Richard Weinberger 0 siblings, 0 replies; 8+ messages in thread From: Richard Weinberger @ 2018-09-25 6:41 UTC (permalink / raw) To: Diego Viola, miguel.ojeda.sandonis; +Cc: corbet, linux-kernel, trivial Am Dienstag, 25. September 2018, 02:09:20 CEST schrieb Diego Viola: > > Diego, I know you can do better. :-) > > How about running linux-next and hunting down regressions? > > I think we suggested this already on IRC. > > OK. I'll do that after I'm done with the documentation. By the definition of done. ;-) If you want to help, Documentation/virtual/uml/UserModeLinux-HOWTO.txt needs an update. Thanks, //richard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH TRIVIAL] Punctuation fixes 2018-09-23 0:58 ` Miguel Ojeda 2018-09-23 8:59 ` Richard Weinberger @ 2018-09-24 23:33 ` Diego Viola 1 sibling, 0 replies; 8+ messages in thread From: Diego Viola @ 2018-09-24 23:33 UTC (permalink / raw) To: miguel.ojeda.sandonis, jikos; +Cc: corbet, linux-kernel, trivial Hi Miguel, On Sat, Sep 22, 2018 at 9:59 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > Hi Diego, > > A few things, since it looks like this is your first patch. > > On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola <diego.viola@gmail.com> wrote: > > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola <diego.viola@gmail.com> wrote: > >> > >> Signed-off-by: Diego Viola <diego.viola@gmail.com> > >> --- > >> CREDITS | 2 +- > >> MAINTAINERS | 2 +- > >> Makefile | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/CREDITS b/CREDITS > >> index 5befd2d71..b82efb36d 100644 > >> --- a/CREDITS > >> +++ b/CREDITS > >> @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/ > >> W: http://www.linuxdiskcert.org/ > >> D: Random SMP kernel hacker... > >> D: Uniform Multi-Platform E-IDE driver > >> -D: Active-ATA-Chipset maddness.......... > >> +D: Active-ATA-Chipset maddness... > > I think the extra dots is what was intended here :) OK. > > >> D: Ultra DMA 133/100/66/33 w/48-bit Addressing > >> D: ATA-Disconnect, ATA-TCQ > >> D: ATA-Smart Kernel Daemon > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index d870cb57c..6567bf245 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -93,7 +93,7 @@ Descriptions of section entries: > >> Supported: Someone is actually paid to look after this. > >> Maintained: Someone actually looks after it. > >> Odd Fixes: It has a maintainer but they don't have time to do > >> - much other than throw the odd patch in. See below.. > >> + much other than throw the odd patch in. See below. > >> Orphan: No current maintainer [but maybe you could take the > >> role as you write your new code]. > >> Obsolete: Old code. Something tagged obsolete generally means > >> diff --git a/Makefile b/Makefile > >> index 4d5c883a9..7b5c5d634 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic > >> prepare0: archprepare gcc-plugins > >> $(Q)$(MAKE) $(build)=. > >> > >> -# All the preparing.. > >> +# All the preparing... > >> prepare: prepare0 prepare-objtool > >> > >> # Support for using generic headers in asm-generic > >> -- > >> 2.19.0 > >> > > > > Jonathan, > > > > can you please merge my patch? After you merge this one, I'll go > > through the rest of the documentation to make it more consistent. > > Jonathan is not responsible for these files. Jiri Kosina is the > maintainer of the trivial tree. OK, I'm CCing him with this email. > > There are 1700+ instances of a "two-stops ellipsis" in the kernel. I > am not sure they were mistakes, given their prevalence, even if they are > not formal/common English. Also, I am not sure a commit for each 3 is > really appropriate! :) Maybe do the full sweep of the Documentation > ones in a single patch? Good idea, do you know what approach I can use for the full sweep? sed perhaps? Doing this manually would be very tedious and using sed might be error prone. > > Also, typically you would note in the subject that this is a "v2" of > your previous patch (if I am not wrong, you sent a first version > fixing only one of the 3 mistakes). Correct, this is my V2 of the first patch. Sorry for not specifying that. > > Thanks for your first patch! > > Cheers, > Miguel Thanks, Diego ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-25 6:41 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-12 3:53 [PATCH TRIVIAL] Punctuation fixes Diego Viola 2018-09-22 15:56 ` Diego Viola 2018-09-23 0:58 ` Miguel Ojeda 2018-09-23 8:59 ` Richard Weinberger 2018-09-23 11:24 ` Miguel Ojeda 2018-09-25 0:09 ` Diego Viola 2018-09-25 6:41 ` Richard Weinberger 2018-09-24 23:33 ` Diego Viola
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).