* [PATCH] rust: error: fix the description for `ECHILD`
@ 2023-09-30 14:49 Wedson Almeida Filho
2023-09-30 17:30 ` Trevor Gross
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Wedson Almeida Filho @ 2023-09-30 14:49 UTC (permalink / raw)
To: rust-for-linux
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
linux-kernel, Wedson Almeida Filho
From: Wedson Almeida Filho <walmeida@microsoft.com>
A mistake was made and the description of `ECHILD` is wrong (it reuses
the description of `ENOEXEC`). This fixes it to reflect what's in
`errno-base.h`.
Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
---
rust/kernel/error.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index 05fcab6abfe6..bab2c043fc42 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -37,7 +37,7 @@ macro_rules! declare_err {
declare_err!(E2BIG, "Argument list too long.");
declare_err!(ENOEXEC, "Exec format error.");
declare_err!(EBADF, "Bad file number.");
- declare_err!(ECHILD, "Exec format error.");
+ declare_err!(ECHILD, "No child process.");
declare_err!(EAGAIN, "Try again.");
declare_err!(ENOMEM, "Out of memory.");
declare_err!(EACCES, "Permission denied.");
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
@ 2023-09-30 17:30 ` Trevor Gross
2023-09-30 22:42 ` Martin Rodriguez Reboredo
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Trevor Gross @ 2023-09-30 17:30 UTC (permalink / raw)
To: Wedson Almeida Filho
Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
linux-kernel, Wedson Almeida Filho
On Sat, Sep 30, 2023 at 10:50 AM Wedson Almeida Filho
<wedsonaf@gmail.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
Reviewed-by: Trevor Gross <tmgross@umich.edu>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
2023-09-30 17:30 ` Trevor Gross
@ 2023-09-30 22:42 ` Martin Rodriguez Reboredo
2023-10-01 11:40 ` Alice Ryhl
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Martin Rodriguez Reboredo @ 2023-09-30 22:42 UTC (permalink / raw)
To: Wedson Almeida Filho, rust-for-linux
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
linux-kernel, Wedson Almeida Filho
On 9/30/23 11:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
2023-09-30 17:30 ` Trevor Gross
2023-09-30 22:42 ` Martin Rodriguez Reboredo
@ 2023-10-01 11:40 ` Alice Ryhl
2023-10-02 15:12 ` Finn Behrens
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Alice Ryhl @ 2023-10-01 11:40 UTC (permalink / raw)
To: Wedson Almeida Filho, rust-for-linux
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
linux-kernel, Wedson Almeida Filho
On 9/30/23 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
` (2 preceding siblings ...)
2023-10-01 11:40 ` Alice Ryhl
@ 2023-10-02 15:12 ` Finn Behrens
2023-10-08 20:01 ` Miguel Ojeda
2023-10-09 14:54 ` Benno Lossin
5 siblings, 0 replies; 8+ messages in thread
From: Finn Behrens @ 2023-10-02 15:12 UTC (permalink / raw)
To: Wedson Almeida Filho
Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
linux-kernel, Wedson Almeida Filho
On 30 Sep 2023, at 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
Reviewed-by: Finn Behrens <me@kloenk.dev>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
` (3 preceding siblings ...)
2023-10-02 15:12 ` Finn Behrens
@ 2023-10-08 20:01 ` Miguel Ojeda
2023-10-09 14:54 ` Benno Lossin
5 siblings, 0 replies; 8+ messages in thread
From: Miguel Ojeda @ 2023-10-08 20:01 UTC (permalink / raw)
To: Wedson Almeida Filho
Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
linux-kernel, Wedson Almeida Filho
On Sat, Sep 30, 2023 at 4:50 PM Wedson Almeida Filho <wedsonaf@gmail.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
Applied to `rust-fixes`, thanks everyone!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
` (4 preceding siblings ...)
2023-10-08 20:01 ` Miguel Ojeda
@ 2023-10-09 14:54 ` Benno Lossin
2023-10-12 21:00 ` Miguel Ojeda
5 siblings, 1 reply; 8+ messages in thread
From: Benno Lossin @ 2023-10-09 14:54 UTC (permalink / raw)
To: Wedson Almeida Filho, rust-for-linux
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, linux-kernel,
Wedson Almeida Filho
On 30.09.23 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
> rust/kernel/error.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..bab2c043fc42 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -37,7 +37,7 @@ macro_rules! declare_err {
> declare_err!(E2BIG, "Argument list too long.");
> declare_err!(ENOEXEC, "Exec format error.");
> declare_err!(EBADF, "Bad file number.");
> - declare_err!(ECHILD, "Exec format error.");
> + declare_err!(ECHILD, "No child process.");
Strictly speaking, `errno-base.h` documents this as "No child
processes" (note the plural), but I am fine with taking it as-is.
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rust: error: fix the description for `ECHILD`
2023-10-09 14:54 ` Benno Lossin
@ 2023-10-12 21:00 ` Miguel Ojeda
0 siblings, 0 replies; 8+ messages in thread
From: Miguel Ojeda @ 2023-10-12 21:00 UTC (permalink / raw)
To: Benno Lossin
Cc: Wedson Almeida Filho, rust-for-linux, Miguel Ojeda, Alex Gaynor,
Boqun Feng, Gary Guo, Björn Roy Baron, Andreas Hindborg,
Alice Ryhl, linux-kernel, Wedson Almeida Filho
On Mon, Oct 9, 2023 at 4:54 PM Benno Lossin <benno.lossin@proton.me> wrote:
>
> Strictly speaking, `errno-base.h` documents this as "No child
> processes" (note the plural), but I am fine with taking it as-is.
Good catch.
POSIX seems to use both (General Information vs. `<errno.h>`), so
perhaps that is where Wedson picked it from.
Given the kernel uses the plural, and that the commit message says it
mimics `errno-base.h`, I have amended it.
Cheers,
Miguel
1: 77983c791960 ! 1: 17bfcd6a8153 rust: error: fix the description
for `ECHILD`
@@ Commit message
Fixes: 266def2a0f5b ("rust: error: add codes from `errno-base.h`")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230930144958.46051-1-wedsonaf@gmail.com
+ [ Use the plural, as noticed by Benno. ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
## rust/kernel/error.rs ##
@@ rust/kernel/error.rs: macro_rules! declare_err {
declare_err!(ENOEXEC, "Exec format error.");
declare_err!(EBADF, "Bad file number.");
- declare_err!(ECHILD, "Exec format error.");
-+ declare_err!(ECHILD, "No child process.");
++ declare_err!(ECHILD, "No child processes.");
declare_err!(EAGAIN, "Try again.");
declare_err!(ENOMEM, "Out of memory.");
declare_err!(EACCES, "Permission denied.");
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-12 21:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-30 14:49 [PATCH] rust: error: fix the description for `ECHILD` Wedson Almeida Filho
2023-09-30 17:30 ` Trevor Gross
2023-09-30 22:42 ` Martin Rodriguez Reboredo
2023-10-01 11:40 ` Alice Ryhl
2023-10-02 15:12 ` Finn Behrens
2023-10-08 20:01 ` Miguel Ojeda
2023-10-09 14:54 ` Benno Lossin
2023-10-12 21:00 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).