* [PATCH] remove comment about sparse not supporting __has_attribute
@ 2020-08-24 23:25 Luc Van Oostenryck
2020-08-27 7:49 ` Miguel Ojeda
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2020-08-24 23:25 UTC (permalink / raw)
To: Miguel Ojeda; +Cc: linux-kernel, Luc Van Oostenryck
Sparse supports __has_attribute() since 2018-08-31, so the comment
is not true anymore but more importantly is rather confusing.
So remove it.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
include/linux/compiler_attributes.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
index 6122efdad6ad..af7a58c19e20 100644
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -24,12 +24,6 @@
* __has_attribute is supported on gcc >= 5, clang >= 2.9 and icc >= 17.
* In the meantime, to support 4.6 <= gcc < 5, we implement __has_attribute
* by hand.
- *
- * sparse does not support __has_attribute (yet) and defines __GNUC_MINOR__
- * depending on the compiler used to build it; however, these attributes have
- * no semantic effects for sparse, so it does not matter. Also note that,
- * in order to avoid sparse's warnings, even the unsupported ones must be
- * defined to 0.
*/
#ifndef __has_attribute
# define __has_attribute(x) __GCC4_has_attribute_##x
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remove comment about sparse not supporting __has_attribute
2020-08-24 23:25 [PATCH] remove comment about sparse not supporting __has_attribute Luc Van Oostenryck
@ 2020-08-27 7:49 ` Miguel Ojeda
0 siblings, 0 replies; 2+ messages in thread
From: Miguel Ojeda @ 2020-08-27 7:49 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: linux-kernel
Hi Luc,
On Tue, Aug 25, 2020 at 1:25 AM Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> Sparse supports __has_attribute() since 2018-08-31, so the comment
> is not true anymore but more importantly is rather confusing.
>
> So remove it.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Thanks! Queuing it.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-27 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 23:25 [PATCH] remove comment about sparse not supporting __has_attribute Luc Van Oostenryck
2020-08-27 7:49 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).