From: Alan Tull <atull@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga
Date: Tue, 15 Jan 2019 12:06:36 -0600 [thread overview]
Message-ID: <CANk1AXQQUVUBfSHCEQbiVEe4ud=K6s75CTmAoBfamkj1oiQ=NQ@mail.gmail.com> (raw)
In-Reply-To: <0574de1a-a238-7ad3-1bc2-24d27ff50cba@kernel.org>
On Tue, Jan 15, 2019 at 11:47 AM Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> minor nit
>
> On 1/14/19 4:33 PM, Alan Tull wrote:
> > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA
> > since it can be used on other platforms such as Stratix10.
> >
> > Signed-off-by: Alan Tull <atull@kernel.org>
> > ---
> > drivers/fpga/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index 0bb7b5c..da5786a 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
> >
> > config ALTERA_FREEZE_BRIDGE
> > tristate "Altera FPGA Freeze Bridge"
> > - depends on ARCH_SOCFPGA && FPGA_BRIDGE
> > + depends on FPGA_BRIDGE
> > + depends on HAS_IOMEM
>
> can just be:
>
> depends on FPGA_BRIDGE && HAS_IOMEM
I agree.
>
> Dinh
prev parent reply other threads:[~2019-01-15 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 22:33 [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga Alan Tull
2019-01-15 17:47 ` Dinh Nguyen
2019-01-15 18:06 ` Alan Tull [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANk1AXQQUVUBfSHCEQbiVEe4ud=K6s75CTmAoBfamkj1oiQ=NQ@mail.gmail.com' \
--to=atull@kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).