* [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga
@ 2019-01-14 22:33 Alan Tull
2019-01-15 17:47 ` Dinh Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Alan Tull @ 2019-01-14 22:33 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Dinh Nguyen, Alan Tull, linux-kernel, linux-fpga
The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA
since it can be used on other platforms such as Stratix10.
Signed-off-by: Alan Tull <atull@kernel.org>
---
drivers/fpga/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 0bb7b5c..da5786a 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
config ALTERA_FREEZE_BRIDGE
tristate "Altera FPGA Freeze Bridge"
- depends on ARCH_SOCFPGA && FPGA_BRIDGE
+ depends on FPGA_BRIDGE
+ depends on HAS_IOMEM
help
Say Y to enable drivers for Altera FPGA Freeze bridges. A
freeze bridge is a bridge that exists in the FPGA fabric to
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga
2019-01-14 22:33 [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga Alan Tull
@ 2019-01-15 17:47 ` Dinh Nguyen
2019-01-15 18:06 ` Alan Tull
0 siblings, 1 reply; 3+ messages in thread
From: Dinh Nguyen @ 2019-01-15 17:47 UTC (permalink / raw)
To: Alan Tull, Moritz Fischer; +Cc: linux-kernel, linux-fpga
minor nit
On 1/14/19 4:33 PM, Alan Tull wrote:
> The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA
> since it can be used on other platforms such as Stratix10.
>
> Signed-off-by: Alan Tull <atull@kernel.org>
> ---
> drivers/fpga/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 0bb7b5c..da5786a 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
>
> config ALTERA_FREEZE_BRIDGE
> tristate "Altera FPGA Freeze Bridge"
> - depends on ARCH_SOCFPGA && FPGA_BRIDGE
> + depends on FPGA_BRIDGE
> + depends on HAS_IOMEM
can just be:
depends on FPGA_BRIDGE && HAS_IOMEM
Dinh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga
2019-01-15 17:47 ` Dinh Nguyen
@ 2019-01-15 18:06 ` Alan Tull
0 siblings, 0 replies; 3+ messages in thread
From: Alan Tull @ 2019-01-15 18:06 UTC (permalink / raw)
To: Dinh Nguyen; +Cc: Moritz Fischer, linux-kernel, linux-fpga
On Tue, Jan 15, 2019 at 11:47 AM Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> minor nit
>
> On 1/14/19 4:33 PM, Alan Tull wrote:
> > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA
> > since it can be used on other platforms such as Stratix10.
> >
> > Signed-off-by: Alan Tull <atull@kernel.org>
> > ---
> > drivers/fpga/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index 0bb7b5c..da5786a 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
> >
> > config ALTERA_FREEZE_BRIDGE
> > tristate "Altera FPGA Freeze Bridge"
> > - depends on ARCH_SOCFPGA && FPGA_BRIDGE
> > + depends on FPGA_BRIDGE
> > + depends on HAS_IOMEM
>
> can just be:
>
> depends on FPGA_BRIDGE && HAS_IOMEM
I agree.
>
> Dinh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-15 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 22:33 [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga Alan Tull
2019-01-15 17:47 ` Dinh Nguyen
2019-01-15 18:06 ` Alan Tull
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).