From: Alan Tull <atull@kernel.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH v2 15/16] fpga: region: add fpga_region_class_find
Date: Wed, 3 May 2017 15:08:25 -0500 [thread overview]
Message-ID: <CANk1AXQSg7qTxfnqx+VA2Le7PU3qZMygq0qsKhmJzP0L4NSnPg@mail.gmail.com> (raw)
In-Reply-To: <CAAtXAHej5XsMUD7peenuPcG2fZcR8PHiyX3fjo7UVq0JkZgNjw@mail.gmail.com>
On Wed, May 3, 2017 at 10:44 AM, Moritz Fischer <mdf@kernel.org> wrote:
> On Thu, Apr 20, 2017 at 7:10 AM, Alan Tull <atull@kernel.org> wrote:
>> Add a function for searching the fpga-region class. This
>> will be useful when device tree code is no longer in the
>> same file that declares the fpga-region class. Another
>> step in separating common FPGA region code from device
>> tree support.
>>
>> Signed-off-by: Alan Tull <atull@kernel.org>
> Acked-by: Moritz Fischer <mdf@kernel.org>
Hi Moritz,
Thanks!
Alan
>> ---
>> v2: split out from another patch
>> ---
>> drivers/fpga/fpga-region.c | 23 +++++++++++++++--------
>> include/linux/fpga/fpga-region.h | 4 ++++
>> 2 files changed, 19 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
>> index e2a3fe6..7ffb8c1 100644
>> --- a/drivers/fpga/fpga-region.c
>> +++ b/drivers/fpga/fpga-region.c
>> @@ -30,6 +30,20 @@
>> static DEFINE_IDA(fpga_region_ida);
>> static struct class *fpga_region_class;
>>
>> +struct fpga_region *fpga_region_class_find(
>> + struct device *start, const void *data,
>> + int (*match)(struct device *, const void *))
>> +{
>> + struct device *dev;
>> +
>> + dev = class_find_device(fpga_region_class, start, data, match);
>> + if (!dev)
>> + return NULL;
>> +
>> + return to_fpga_region(dev);
>> +}
>> +EXPORT_SYMBOL_GPL(fpga_region_class_find);
>> +
>> static const struct of_device_id fpga_region_of_match[] = {
>> { .compatible = "fpga-region", },
>> {},
>> @@ -51,14 +65,7 @@ static int fpga_region_of_node_match(struct device *dev, const void *data)
>> */
>> static struct fpga_region *of_fpga_region_find(struct device_node *np)
>> {
>> - struct device *dev;
>> -
>> - dev = class_find_device(fpga_region_class, NULL, np,
>> - fpga_region_of_node_match);
>> - if (!dev)
>> - return NULL;
>> -
>> - return to_fpga_region(dev);
>> + return fpga_region_class_find(NULL, np, fpga_region_of_node_match);
>> }
>>
>> /**
>> diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h
>> index 35e7e09..4966bb2 100644
>> --- a/include/linux/fpga/fpga-region.h
>> +++ b/include/linux/fpga/fpga-region.h
>> @@ -28,6 +28,10 @@ struct fpga_region {
>>
>> #define to_fpga_region(d) container_of(d, struct fpga_region, dev)
>>
>> +struct fpga_region *fpga_region_class_find(
>> + struct device *start, const void *data,
>> + int (*match)(struct device *, const void *));
>> +
>> int fpga_region_program_fpga(struct fpga_region *region,
>> struct fpga_image_info *image_info);
>>
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2017-05-03 20:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:09 [PATCH v2 00/16] Enable upper layers using FPGA region w/o device tree Alan Tull
2017-04-20 14:09 ` [PATCH v2 01/16] doc: fpga: update documents for the FPGA API Alan Tull
2017-04-20 14:09 ` [PATCH v2 02/16] fpga: bridge: support getting bridge from device Alan Tull
2017-05-03 11:58 ` Wu Hao
2017-05-03 20:07 ` Alan Tull
2017-05-04 9:20 ` Wu Hao
2017-05-04 21:31 ` Alan Tull
2017-05-08 8:44 ` Wu, Hao
2017-05-08 20:44 ` Alan Tull
2017-05-08 20:52 ` Moritz Fischer
2017-05-08 21:02 ` Alan Tull
2017-05-08 21:11 ` Moritz Fischer
2017-05-08 21:20 ` Alan Tull
2017-05-08 21:55 ` Moritz Fischer
2017-05-09 7:16 ` Wu Hao
2017-04-20 14:09 ` [PATCH v2 03/16] fpga: mgr: API change to replace fpga load functions with single function Alan Tull
2017-04-21 20:08 ` Alan Tull
2017-04-20 14:09 ` [PATCH v2 04/16] fpga: mgr: separate getting/locking FPGA manager Alan Tull
2017-04-20 14:09 ` [PATCH v2 05/16] fpga: region: use dev_err instead of pr_err Alan Tull
2017-04-20 14:09 ` [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put Alan Tull
2017-05-05 17:08 ` Moritz Fischer
2017-04-20 14:09 ` [PATCH v2 07/16] fpga: region: get mgr early on Alan Tull
2017-04-20 14:09 ` [PATCH v2 08/16] fpga: region: check for child regions before allocing image info Alan Tull
2017-05-05 20:59 ` Moritz Fischer
2017-05-08 21:03 ` Alan Tull
2017-04-20 14:09 ` [PATCH v2 09/16] fpga: region: fix slow warning with more than one overlay Alan Tull
2017-04-20 14:09 ` [PATCH v2 10/16] fpga: region: use image info as parameter for programming region Alan Tull
2017-05-09 15:25 ` Alan Tull
2017-04-20 14:09 ` [PATCH v2 11/16] fpga: region: separate out code that parses the overlay Alan Tull
2017-04-20 14:09 ` [PATCH v2 12/16] fpga: region: add fpga-region.h header Alan Tull
2017-04-20 14:09 ` [PATCH v2 13/16] fpga: region: rename some functions prior to moving Alan Tull
2017-04-20 14:09 ` [PATCH v2 14/16] fpga: region: add register/unregister functions Alan Tull
2017-04-20 14:10 ` [PATCH v2 15/16] fpga: region: add fpga_region_class_find Alan Tull
2017-05-03 15:44 ` Moritz Fischer
2017-05-03 20:08 ` Alan Tull [this message]
2017-04-20 14:10 ` [PATCH v2 16/16] fpga: region: move device tree support to of-fpga-region.c Alan Tull
2017-04-28 6:38 ` Wu Hao
2017-04-28 17:37 ` Alan Tull
2017-04-20 14:16 ` [PATCH v2 00/16] Enable upper layers using FPGA region w/o device tree Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXQSg7qTxfnqx+VA2Le7PU3qZMygq0qsKhmJzP0L4NSnPg@mail.gmail.com \
--to=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).