From: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: menglong8.dong@gmail.com, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org,
imagedong@tencent.com, ycheng@google.com, kuniyu@amazon.co.jp,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: snmp: add statistics for tcp small queue check
Date: Mon, 29 Nov 2021 08:37:50 -0800 [thread overview]
Message-ID: <CANn89iJ0Txbb7wvgKSPMLhHE0X8cadayN8ULZJkEvrC8YTwkow@mail.gmail.com> (raw)
In-Reply-To: <20211129075707.47ab0ffe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Nov 29, 2021 at 7:57 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun, 28 Nov 2021 14:01:02 +0800 menglong8.dong@gmail.com wrote:
> > Once tcp small queue check failed in tcp_small_queue_check(), the
> > throughput of tcp will be limited, and it's hard to distinguish
> > whether it is out of tcp congestion control.
> >
> > Add statistics of LINUX_MIB_TCPSMALLQUEUEFAILURE for this scene.
>
> Isn't this going to trigger all the time and alarm users because of the
> "Failure" in the TCPSmallQueueFailure name? Isn't it perfectly fine
> for TCP to bake full TSQ amount of data and have it paced out onto the
> wire? What's your link speed?
Yes, I would be curious to have some instructions on how this new SNMP
variable can be used,
in a concrete case.
Like, how getting these SNMP values can translate to an action, giving
more throughput ?
next prev parent reply other threads:[~2021-11-29 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 6:01 [PATCH v2 net-next] net: snmp: add statistics for tcp small queue check menglong8.dong
2021-11-29 13:10 ` patchwork-bot+netdevbpf
2021-11-29 15:57 ` Jakub Kicinski
2021-11-29 16:37 ` Eric Dumazet [this message]
2021-11-30 14:36 ` Menglong Dong
2021-11-30 15:23 ` Jakub Kicinski
2021-11-30 15:55 ` Eric Dumazet
2021-12-01 2:05 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJ0Txbb7wvgKSPMLhHE0X8cadayN8ULZJkEvrC8YTwkow@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).