From: Marco Elver <elver@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@kernel.org>, "Will Deacon" <will@kernel.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Jürgen Groß" <jgross@suse.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
rjw@rjwysocki.net, "Joel Fernandes" <joel@joelfernandes.org>,
svens@linux.ibm.com, "Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage
Date: Fri, 21 Aug 2020 09:05:46 +0200 [thread overview]
Message-ID: <CANpmjNOnopd8usQJk0Y1mxSNrQ15e0GboNfwop4qUDCwMnQQZQ@mail.gmail.com> (raw)
In-Reply-To: <20200821065413.GG1362448@hirez.programming.kicks-ass.net>
On Fri, 21 Aug 2020 at 08:54, <peterz@infradead.org> wrote:
>
> On Thu, Aug 20, 2020 at 07:20:46PM +0200, Marco Elver wrote:
> > From 4ec9dd472c978e1eba622fb22bc04e4357f10421 Mon Sep 17 00:00:00 2001
> > From: Marco Elver <elver@google.com>
> > Date: Thu, 20 Aug 2020 19:06:09 +0200
> > Subject: [PATCH] sched: Turn inline into __always_inline due to noinstr use
> >
> > is_idle_task() may be used from noinstr functions such as
> > irqentry_enter(). Since the compiler is free to not inline regular
> > inline functions, switch to using __always_inline.
> >
> > Signed-off-by: Marco Elver <elver@google.com>
>
> Fair enough I suppose; didn't that generate an objtool warning on your
> build? (of course that requires PARAVIRT=n, I should get back to fixing
> that)
It does now after turning on VMLINUX_VALIDATION.
Although note that this patch (and the other, which I'll send
separately) wasn't required after the rcuidle fix. I suppose there is
still a small chance things can go wrong though, but syzkaller wasn't
able to find such a case (yet).
Thanks,
-- Marco
next prev parent reply other threads:[~2020-08-21 7:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 7:30 [PATCH 0/9] TRACE_IRQFLAGS wreckage Peter Zijlstra
2020-08-20 7:30 ` [PATCH 1/9] lockdep: Use raw_cpu_*() for per-cpu variables Peter Zijlstra
2020-08-20 13:54 ` Steven Rostedt
2020-08-20 7:30 ` [PATCH 2/9] sched,idle,rcu: Push rcu_idle deeper into the idle path Peter Zijlstra
2020-08-20 13:58 ` Steven Rostedt
2020-08-20 7:30 ` [PATCH 3/9] cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic Peter Zijlstra
2020-08-20 7:30 ` [PATCH 4/9] cpuidle: Move trace_cpu_idle() into generic code Peter Zijlstra
2020-08-20 7:30 ` [PATCH 5/9] x86/entry: Remove unused THUNKs Peter Zijlstra
2020-08-20 7:30 ` [PATCH 6/9] locking/lockdep: Cleanup Peter Zijlstra
2020-08-20 7:30 ` [PATCH 7/9] nds32: Implement arch_irqs_disabled() Peter Zijlstra
2020-08-20 7:30 ` [PATCH 8/9] lockdep: Only trace IRQ edges Peter Zijlstra
2020-08-20 7:30 ` [PATCH 9/9] lockdep,trace: Expose tracepoints Peter Zijlstra
2020-08-20 14:36 ` [PATCH 0/9] TRACE_IRQFLAGS wreckage Steven Rostedt
2020-08-20 14:39 ` Steven Rostedt
2020-08-20 14:49 ` Marco Elver
2020-08-20 14:58 ` peterz
2020-08-20 16:53 ` Steven Rostedt
2020-08-20 17:20 ` Marco Elver
2020-08-20 19:59 ` Steven Rostedt
2020-08-21 6:37 ` Marco Elver
2020-08-21 6:54 ` peterz
2020-08-21 7:05 ` Marco Elver [this message]
2020-08-27 7:54 ` [tip: sched/urgent] sched: Use __always_inline on is_idle_task() tip-bot2 for Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpmjNOnopd8usQJk0Y1mxSNrQ15e0GboNfwop4qUDCwMnQQZQ@mail.gmail.com \
--to=elver@google.com \
--cc=jgross@suse.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).