* [PATCH] memfd_test: Add missing argument to printf()
@ 2014-08-31 18:00 Pranith Kumar
2014-09-01 11:30 ` David Herrmann
0 siblings, 1 reply; 2+ messages in thread
From: Pranith Kumar @ 2014-08-31 18:00 UTC (permalink / raw)
To: Hugh Dickins, David Herrmann, Andrew Morton, open list
Add a missing path argument buf to printf()
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
tools/testing/selftests/memfd/memfd_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 3634c90..c343df8 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
sprintf(buf, "/proc/self/fd/%d", fd);
r = open(buf, flags, mode);
if (r >= 0) {
- printf("open(%s) didn't fail as expected\n");
+ printf("open(%s) didn't fail as expected\n", buf);
abort();
}
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memfd_test: Add missing argument to printf()
2014-08-31 18:00 [PATCH] memfd_test: Add missing argument to printf() Pranith Kumar
@ 2014-09-01 11:30 ` David Herrmann
0 siblings, 0 replies; 2+ messages in thread
From: David Herrmann @ 2014-09-01 11:30 UTC (permalink / raw)
To: Pranith Kumar; +Cc: Hugh Dickins, Andrew Morton, open list
Hi
On Sun, Aug 31, 2014 at 8:00 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Add a missing path argument buf to printf()
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Looks good:
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks
David
> ---
> tools/testing/selftests/memfd/memfd_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 3634c90..c343df8 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
> sprintf(buf, "/proc/self/fd/%d", fd);
> r = open(buf, flags, mode);
> if (r >= 0) {
> - printf("open(%s) didn't fail as expected\n");
> + printf("open(%s) didn't fail as expected\n", buf);
> abort();
> }
> }
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-01 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-31 18:00 [PATCH] memfd_test: Add missing argument to printf() Pranith Kumar
2014-09-01 11:30 ` David Herrmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).