linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
@ 2012-08-28 11:30 Axel Lin
  2012-08-31  0:05 ` Linus Walleij
  2012-08-31 23:19 ` Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2012-08-28 11:30 UTC (permalink / raw)
  To: Linus Walleij, Grant Likely; +Cc: Magnus Damm, linux-kernel

irq_alloc_descs() returns negative error code on failure.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/gpio/gpio-em.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index ae37181..ec48ed5 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -247,9 +247,9 @@ static int __devinit em_gio_irq_domain_init(struct em_gio_priv *p)
 
 	p->irq_base = irq_alloc_descs(pdata->irq_base, 0,
 				      pdata->number_of_pins, numa_node_id());
-	if (IS_ERR_VALUE(p->irq_base)) {
+	if (p->irq_base < 0) {
 		dev_err(&pdev->dev, "cannot get irq_desc\n");
-		return -ENXIO;
+		return p->irq_base;
 	}
 	pr_debug("gio: hw base = %d, nr = %d, sw base = %d\n",
 		 pdata->gpio_base, pdata->number_of_pins, p->irq_base);
-- 
1.7.9.5




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
  2012-08-28 11:30 [PATCH] gpio: em: Fix checking return value of irq_alloc_descs Axel Lin
@ 2012-08-31  0:05 ` Linus Walleij
  2012-08-31  1:23   ` Magnus Damm
  2012-08-31 23:19 ` Linus Walleij
  1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2012-08-31  0:05 UTC (permalink / raw)
  To: Axel Lin, Magnus Damm; +Cc: Grant Likely, linux-kernel

On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin <axel.lin@gmail.com> wrote:

> irq_alloc_descs() returns negative error code on failure.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Magnuis can I have your ACK on this?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
  2012-08-31  0:05 ` Linus Walleij
@ 2012-08-31  1:23   ` Magnus Damm
  0 siblings, 0 replies; 4+ messages in thread
From: Magnus Damm @ 2012-08-31  1:23 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Axel Lin, Magnus Damm, Grant Likely, linux-kernel

On Fri, Aug 31, 2012 at 9:05 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Aug 28, 2012 at 4:30 AM, Axel Lin <axel.lin@gmail.com> wrote:
>
>> irq_alloc_descs() returns negative error code on failure.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Magnuis can I have your ACK on this?

Yes, of course! I never disagree with bug fixes =)

Acked-by: Magnus Damm <damm@opensource.se>

Thanks a lot to both Axel and you!

/ magnus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs
  2012-08-28 11:30 [PATCH] gpio: em: Fix checking return value of irq_alloc_descs Axel Lin
  2012-08-31  0:05 ` Linus Walleij
@ 2012-08-31 23:19 ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2012-08-31 23:19 UTC (permalink / raw)
  To: Axel Lin; +Cc: Grant Likely, Magnus Damm, linux-kernel

On Tue, Aug 28, 2012 at 1:30 PM, Axel Lin <axel.lin@gmail.com> wrote:

> irq_alloc_descs() returns negative error code on failure.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied with Magnus' ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-08-31 23:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-28 11:30 [PATCH] gpio: em: Fix checking return value of irq_alloc_descs Axel Lin
2012-08-31  0:05 ` Linus Walleij
2012-08-31  1:23   ` Magnus Damm
2012-08-31 23:19 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).