* [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID
@ 2019-04-25 7:39 Yue Haibing
2019-04-25 7:42 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-04-25 7:39 UTC (permalink / raw)
To: jikos, benjamin.tissoires, hdegoede; +Cc: linux-kernel, linux-input, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
During randconfig builds, I occasionally run into an invalid configuration
drivers/hid/hid-logitech-dj.o: In function `logi_dj_probe':
hid-logitech-dj.c:(.text+0x32dc): undefined reference to `usb_hid_driver'
This is because CONFIG_USB_HID is not set, So this
patch selects it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: da12b224b7d5 ("HID: logitech-dj: deal with some KVMs adding an extra interface to the usbdev")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 76d8206..c3c390c 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -521,6 +521,7 @@ config HID_LOGITECH
config HID_LOGITECH_DJ
tristate "Logitech Unifying receivers full support"
+ depends on USB_HID
depends on HIDRAW
depends on HID_LOGITECH
select HID_LOGITECH_HIDPP
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID
2019-04-25 7:39 [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID Yue Haibing
@ 2019-04-25 7:42 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2019-04-25 7:42 UTC (permalink / raw)
To: Yue Haibing; +Cc: Jiri Kosina, Hans de Goede, lkml, open list:HID CORE LAYER
Hi,
On Thu, Apr 25, 2019 at 9:40 AM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> During randconfig builds, I occasionally run into an invalid configuration
>
> drivers/hid/hid-logitech-dj.o: In function `logi_dj_probe':
> hid-logitech-dj.c:(.text+0x32dc): undefined reference to `usb_hid_driver'
>
> This is because CONFIG_USB_HID is not set, So this
> patch selects it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: da12b224b7d5 ("HID: logitech-dj: deal with some KVMs adding an extra interface to the usbdev")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks a lot, but I already scheduled
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/logitech&id=c08f38e9fd0b5486957ed42438ec8fa9b6ebbf4f
in for-next.
It's weird it doesn't show up in your bot... :/
Cheers,
Benjamin
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 76d8206..c3c390c 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -521,6 +521,7 @@ config HID_LOGITECH
>
> config HID_LOGITECH_DJ
> tristate "Logitech Unifying receivers full support"
> + depends on USB_HID
> depends on HIDRAW
> depends on HID_LOGITECH
> select HID_LOGITECH_HIDPP
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-25 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25 7:39 [PATCH] HID: logitech-dj: Fix build error without CONFIG_USB_HID Yue Haibing
2019-04-25 7:42 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).