* [PATCH 3/4 v3] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings
@ 2022-09-09 23:21 Julius Werner
2022-09-13 14:30 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Julius Werner @ 2022-09-09 23:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Dmitry Osipenko, Doug Anderson, Jian-Jia Su,
devicetree, linux-kernel, Julius Werner
This patch adds bindings for LPDDR4 and LPDDR5 memory analogous to the
existing bindings for LPDDR2 and LPDDR3. For now, the new types are only
needed for topology description, so other properties like timing
parameters are omitted. They can be added later if needed.
Signed-off-by: Julius Werner <jwerner@chromium.org>
---
.../ddr/jedec,lpddr-props.yaml | 4 ++
.../memory-controllers/ddr/jedec,lpddr4.yaml | 35 ++++++++++++++
.../memory-controllers/ddr/jedec,lpddr5.yaml | 46 +++++++++++++++++++
3 files changed, 85 insertions(+)
create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
Changelog:
- v2
- removed minItems
- moved `$ref` below `maintainers`
- renamed example node from `lpddr4` to `lpddr`
- v3
- removed manufacturer-id property from examples
diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
index 4114cfa8de67f1..92ef660888f318 100644
--- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
@@ -45,9 +45,13 @@ properties:
- 512
- 1024
- 2048
+ - 3072
- 4096
+ - 6144
- 8192
+ - 12288
- 16384
+ - 24576
- 32768
io-width:
diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
new file mode 100644
index 00000000000000..fa9b30ee89cb81
--- /dev/null
+++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/memory-controllers/ddr/jedec,lpddr4.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LPDDR4 SDRAM compliant to JEDEC JESD209-4
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+allOf:
+ - $ref: "jedec,lpddr-props.yaml#"
+
+properties:
+ compatible:
+ items:
+ - pattern: "^lpddr4-[0-9a-f]{2},[0-9a-f]{4}$"
+ - const: jedec,lpddr4
+
+required:
+ - compatible
+ - density
+ - io-width
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ lpddr {
+ compatible = "lpddr4-ff,0100", "jedec,lpddr4";
+ density = <8192>;
+ io-width = <16>;
+ revision-id = <1 0>;
+ };
diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
new file mode 100644
index 00000000000000..01e11aabc5a3f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/memory-controllers/ddr/jedec,lpddr5.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LPDDR5 SDRAM compliant to JEDEC JESD209-5
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+allOf:
+ - $ref: "jedec,lpddr-props.yaml#"
+
+properties:
+ compatible:
+ items:
+ - pattern: "^lpddr5-[0-9a-f]{2},[0-9a-f]{4}$"
+ - const: jedec,lpddr5
+
+ serial-id:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ Serial IDs read from Mode Registers 47 through 54. One byte per uint32
+ cell (i.e. <MR47 MR48 MR49 MR50 MR51 MR52 MR53 MR54>).
+ maxItems: 8
+ items:
+ minimum: 0
+ maximum: 255
+
+required:
+ - compatible
+ - density
+ - io-width
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ lpddr {
+ compatible = "lpddr5-01,0200", "jedec,lpddr5";
+ density = <8192>;
+ io-width = <8>;
+ revision-id = <2 0>;
+ serial-id = <3 1 0 0 0 0 0 0>;
+ };
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4 v3] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings
2022-09-09 23:21 [PATCH 3/4 v3] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings Julius Werner
@ 2022-09-13 14:30 ` Rob Herring
2022-09-15 0:32 ` Julius Werner
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-09-13 14:30 UTC (permalink / raw)
To: Julius Werner
Cc: Krzysztof Kozlowski, Dmitry Osipenko, Doug Anderson, Jian-Jia Su,
devicetree, linux-kernel
On Fri, Sep 09, 2022 at 04:21:39PM -0700, Julius Werner wrote:
> This patch adds bindings for LPDDR4 and LPDDR5 memory analogous to the
> existing bindings for LPDDR2 and LPDDR3. For now, the new types are only
> needed for topology description, so other properties like timing
> parameters are omitted. They can be added later if needed.
I only see patch 3. Please only send complete series.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
> .../ddr/jedec,lpddr-props.yaml | 4 ++
> .../memory-controllers/ddr/jedec,lpddr4.yaml | 35 ++++++++++++++
> .../memory-controllers/ddr/jedec,lpddr5.yaml | 46 +++++++++++++++++++
> 3 files changed, 85 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
>
> Changelog:
>
> - v2
> - removed minItems
> - moved `$ref` below `maintainers`
> - renamed example node from `lpddr4` to `lpddr`
> - v3
> - removed manufacturer-id property from examples
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
> index 4114cfa8de67f1..92ef660888f318 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
> @@ -45,9 +45,13 @@ properties:
> - 512
> - 1024
> - 2048
> + - 3072
> - 4096
> + - 6144
> - 8192
> + - 12288
> - 16384
> + - 24576
> - 32768
>
> io-width:
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
> new file mode 100644
> index 00000000000000..fa9b30ee89cb81
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr4.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/ddr/jedec,lpddr4.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LPDDR4 SDRAM compliant to JEDEC JESD209-4
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +allOf:
> + - $ref: "jedec,lpddr-props.yaml#"
Drop quotes.
> +
> +properties:
> + compatible:
> + items:
> + - pattern: "^lpddr4-[0-9a-f]{2},[0-9a-f]{4}$"
> + - const: jedec,lpddr4
> +
> +required:
> + - compatible
> + - density
> + - io-width
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + lpddr {
> + compatible = "lpddr4-ff,0100", "jedec,lpddr4";
> + density = <8192>;
> + io-width = <16>;
> + revision-id = <1 0>;
> + };
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
> new file mode 100644
> index 00000000000000..01e11aabc5a3f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr5.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/ddr/jedec,lpddr5.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LPDDR5 SDRAM compliant to JEDEC JESD209-5
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +allOf:
> + - $ref: "jedec,lpddr-props.yaml#"
And here.
> +
> +properties:
> + compatible:
> + items:
> + - pattern: "^lpddr5-[0-9a-f]{2},[0-9a-f]{4}$"
> + - const: jedec,lpddr5
> +
> + serial-id:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + Serial IDs read from Mode Registers 47 through 54. One byte per uint32
> + cell (i.e. <MR47 MR48 MR49 MR50 MR51 MR52 MR53 MR54>).
> + maxItems: 8
> + items:
> + minimum: 0
> + maximum: 255
> +
> +required:
> + - compatible
> + - density
> + - io-width
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + lpddr {
> + compatible = "lpddr5-01,0200", "jedec,lpddr5";
> + density = <8192>;
> + io-width = <8>;
> + revision-id = <2 0>;
> + serial-id = <3 1 0 0 0 0 0 0>;
> + };
> --
> 2.31.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4 v3] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings
2022-09-13 14:30 ` Rob Herring
@ 2022-09-15 0:32 ` Julius Werner
0 siblings, 0 replies; 3+ messages in thread
From: Julius Werner @ 2022-09-15 0:32 UTC (permalink / raw)
To: Rob Herring
Cc: Julius Werner, Krzysztof Kozlowski, Dmitry Osipenko,
Doug Anderson, Jian-Jia Su,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
> I only see patch 3. Please only send complete series.
Sorry, I thought it would be enough to just respin the one patch that
changed. Resending everything as v4 now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-15 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 23:21 [PATCH 3/4 v3] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings Julius Werner
2022-09-13 14:30 ` Rob Herring
2022-09-15 0:32 ` Julius Werner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).