From: Philippe Ombredanne <pombredanne@nexb.com>
To: Rob Herring <rob.herring@linaro.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/
Date: Tue, 24 Oct 2017 12:36:07 +0200 [thread overview]
Message-ID: <CAOFm3uFu_yJs9e1RxJ8aTKPf2Ni6thQC86Z1oE4KsxTfCJWnTg@mail.gmail.com> (raw)
In-Reply-To: <20171021074841.GB19934@kroah.com>
Rob:
On Sat, Oct 21, 2017 at 9:48 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Oct 20, 2017 at 10:26:22AM -0500, Rob Herring wrote:
>> On Thu, Oct 19, 2017 at 3:38 AM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > It's good to have SPDX identifiers in all files to make it easier to
>> > audit the kernel tree for correct licenses. This patch adds these
>> > identifiers to all files in drivers/usb/ based on a script and data from
>> > Thomas Gleixner, Philippe Ombredanne, and Kate Stewart.
>> >
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: Kate Stewart <kstewart@linuxfoundation.org>
>> > Cc: Philippe Ombredanne <pombredanne@nexb.com>
>> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> > ---
>> > Unless someone really complains, I'm going to add this to my tree for
>> > 4.15-rc1.
>>
>> Glad to see this. I've been suggesting folks use SPDX tags on dts
>> files as those are often dual licensed, so we have lots of license
>> boilerplate. But I've had some push back[1] but it's not something I
>> care to spend cycles on. It would be good to have some statement on
>> the use of tags. Anything new should use them (I can dust off my
>> checkpatch.pl check for this)? This is a good task for newbies? It's
>> each maintainer's decision? It's the copyright holder's (and their
>> lawyer's) decision?
>
> As for what type of a task this is, we have a script and a huge database
> that has been worked on by some people to make a lot of this pretty
> "automatic" to apply.
I am one of the people that worked on scanning kernels for licenses
using my scancode tool [1] to help there.
Regarding checkpatch.pl and tooling to help review patches I can think of
two things:
1. when there is SPDX identifier in a patch, it could be checked for validity
I have a library for this [2] (this is in Python not Perl) but the checks needed
should be fairly trivial since there is not an open number of license
variations in the kernel: this could be re-written in Perl alright.
2. scancode can detect the licenses fairly accurately to spit and suggest
an SPDX license identifier and/or provide input to remove boilerplate either
for new patches or existing code. Not sure how to best integrate this as a
patch check step. Docs? Server-side tool? Any idea?
What would be the best thing to do next?
[1] https://github.com/nexB/scancode-toolkit
[2] https://github.com/nexB/license-expression/
--
Cordially
Philippe Ombredanne
next prev parent reply other threads:[~2017-10-24 10:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 8:38 [PATCH] USB: add SPDX identifiers to all files in drivers/usb/ Greg Kroah-Hartman
2017-10-19 8:49 ` Geert Uytterhoeven
2017-10-19 8:52 ` Greg Kroah-Hartman
2017-10-19 9:10 ` Geert Uytterhoeven
2017-10-19 9:15 ` Thomas Gleixner
2017-10-19 9:27 ` Felipe Balbi
2017-10-19 8:50 ` Thomas Gleixner
2017-10-19 8:57 ` Greg Kroah-Hartman
2017-10-19 8:59 ` Greg Kroah-Hartman
2017-10-19 9:01 ` Thomas Gleixner
2017-10-19 9:10 ` Greg Kroah-Hartman
2017-10-19 10:55 ` Philippe Ombredanne
2017-10-20 17:49 ` Alan Cox
2017-10-21 7:46 ` Greg Kroah-Hartman
2017-10-20 15:26 ` Rob Herring
2017-10-21 7:48 ` Greg Kroah-Hartman
2017-10-24 10:36 ` Philippe Ombredanne [this message]
2017-11-03 10:28 ` [PATCH v2] USB: add SPDX identifiers to all remaining " Greg Kroah-Hartman
2017-11-03 10:29 ` Greg Kroah-Hartman
2017-11-03 10:50 ` Felipe Balbi
2017-11-03 12:08 ` Greg Kroah-Hartman
2017-11-03 16:53 ` Johan Hovold
2017-11-04 10:40 ` Greg Kroah-Hartman
2017-11-05 12:53 ` Philippe Ombredanne
2017-11-05 13:51 ` Greg Kroah-Hartman
2017-11-05 15:39 ` Philippe Ombredanne
2017-11-06 8:17 ` Greg Kroah-Hartman
2017-11-09 9:51 ` Pavel Machek
2017-11-09 10:40 ` Greg Kroah-Hartman
2017-11-09 10:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFm3uFu_yJs9e1RxJ8aTKPf2Ni6thQC86Z1oE4KsxTfCJWnTg@mail.gmail.com \
--to=pombredanne@nexb.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).