From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/
Date: Thu, 9 Nov 2017 11:42:37 +0100 [thread overview]
Message-ID: <20171109104236.GA10048@amd> (raw)
In-Reply-To: <20171109104028.GA13751@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
On Thu 2017-11-09 11:40:28, Greg Kroah-Hartman wrote:
> On Thu, Nov 09, 2017 at 10:51:48AM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > It's good to have SPDX identifiers in all files to make it easier to
> > > audit the kernel tree for correct licenses.
> > >
> > > Update the drivers/usb/ and include/linux/usb* files with the correct
> > > SPDX license identifier based on the license text in the file itself.
> > > The SPDX identifier is a legally binding shorthand, which can be used
> > > instead of the full boiler plate text.
> > >
> > > This work is based on a script and data from Thomas Gleixner, Philippe
> > > Ombredanne, and Kate Stewart.
> > >
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Kate Stewart <kstewart@linuxfoundation.org>
> > > Cc: Philippe Ombredanne <pombredanne@nexb.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > > v2: Use the "standard" format of putting the identifier at the top of
> > > the file, and use // for .c and .h files.
> > > Removed the files already marked in Linus's tree.
> > >
> > > Unless someone really complains, I'm going to add this to my tree for
> > > 4.15-rc1.
> >
> > as you said in some other email... this stands out a bit too
> > much.
>
> That is the goal, sorry.
Then it is bad goal.
Automated tools can pick it up whereever it is. No need to grab
attention with poor placing.
> > What about using normal c comments, and put it near the original
> > license text? It is not exactly the most important thing...
> >
> > Or maybe near the MODULE_LICENSE, so the two don't get out of sync?
>
> No, the top of the file is best, thanks.
No, it is not, thanks.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-11-09 10:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 8:38 [PATCH] USB: add SPDX identifiers to all files in drivers/usb/ Greg Kroah-Hartman
2017-10-19 8:49 ` Geert Uytterhoeven
2017-10-19 8:52 ` Greg Kroah-Hartman
2017-10-19 9:10 ` Geert Uytterhoeven
2017-10-19 9:15 ` Thomas Gleixner
2017-10-19 9:27 ` Felipe Balbi
2017-10-19 8:50 ` Thomas Gleixner
2017-10-19 8:57 ` Greg Kroah-Hartman
2017-10-19 8:59 ` Greg Kroah-Hartman
2017-10-19 9:01 ` Thomas Gleixner
2017-10-19 9:10 ` Greg Kroah-Hartman
2017-10-19 10:55 ` Philippe Ombredanne
2017-10-20 17:49 ` Alan Cox
2017-10-21 7:46 ` Greg Kroah-Hartman
2017-10-20 15:26 ` Rob Herring
2017-10-21 7:48 ` Greg Kroah-Hartman
2017-10-24 10:36 ` Philippe Ombredanne
2017-11-03 10:28 ` [PATCH v2] USB: add SPDX identifiers to all remaining " Greg Kroah-Hartman
2017-11-03 10:29 ` Greg Kroah-Hartman
2017-11-03 10:50 ` Felipe Balbi
2017-11-03 12:08 ` Greg Kroah-Hartman
2017-11-03 16:53 ` Johan Hovold
2017-11-04 10:40 ` Greg Kroah-Hartman
2017-11-05 12:53 ` Philippe Ombredanne
2017-11-05 13:51 ` Greg Kroah-Hartman
2017-11-05 15:39 ` Philippe Ombredanne
2017-11-06 8:17 ` Greg Kroah-Hartman
2017-11-09 9:51 ` Pavel Machek
2017-11-09 10:40 ` Greg Kroah-Hartman
2017-11-09 10:42 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109104236.GA10048@amd \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).