[PATCH v2] iio: mma8452: replace license description with SPDX specifier

[PATCH v2] iio: mma8452: replace license description with SPDX specifier

[Martin Kepplinger]

This replaces the custom license information text with the appropriate
SPDX identifier. While the information here stays the same, it is easier
to read.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
---

Sorry I had forgotten to add the mailing lists and got Peter's Ack
privately. -.-  But thanks Peter for the quick response!

Again, an Acked-by from Harinath would be good here too.

thanks

                             martin

revision history
----------------
v2: adds Peter's Acked-by and adds all mailing lists to CC


 drivers/iio/accel/mma8452.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index bfd4bc806fc2..62c0d4646c16 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * mma8452.c - Support for following Freescale / NXP 3-axis accelerometers:
  *
@@ -13,9 +14,6 @@
  * Copyright 2015 Martin Kepplinger <martink@posteo.de>
  * Copyright 2014 Peter Meerwald <pmeerw@pmeerw.net>
  *
- * This file is subject to the terms and conditions of version 2 of
- * the GNU General Public License.  See the file COPYING in the main
- * directory of this archive for more details.
  *
  * TODO: orientation events
  */
-- 
2.11.0

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

[Jonathan Cameron]

On Sat, 18 Nov 2017 10:10:11 +0100
Martin Kepplinger <martink@posteo.de> wrote:

> This replaces the custom license information text with the appropriate
> SPDX identifier. While the information here stays the same, it is easier
> to read.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>

I'm not 100% sure the intent of the SPDX work is to remove
existing licence text.  So far the big sets have only been
adding tags to files missing their licenses entirely...

Anyone found any specific guidance on this?

Jonathan
> ---
> 
> Sorry I had forgotten to add the mailing lists and got Peter's Ack
> privately. -.-  But thanks Peter for the quick response!
> 
> Again, an Acked-by from Harinath would be good here too.
> 
> thanks
> 
>                              martin
> 
> revision history
> ----------------
> v2: adds Peter's Acked-by and adds all mailing lists to CC
> 
> 
>  drivers/iio/accel/mma8452.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index bfd4bc806fc2..62c0d4646c16 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * mma8452.c - Support for following Freescale / NXP 3-axis accelerometers:
>   *
> @@ -13,9 +14,6 @@
>   * Copyright 2015 Martin Kepplinger <martink@posteo.de>
>   * Copyright 2014 Peter Meerwald <pmeerw@pmeerw.net>
>   *
> - * This file is subject to the terms and conditions of version 2 of
> - * the GNU General Public License.  See the file COPYING in the main
> - * directory of this archive for more details.
>   *
>   * TODO: orientation events
>   */

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

[Philippe Ombredanne]

On Sat, Nov 18, 2017 at 4:53 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On Sat, 18 Nov 2017 10:10:11 +0100
> Martin Kepplinger <martink@posteo.de> wrote:
>
>> This replaces the custom license information text with the appropriate
>> SPDX identifier. While the information here stays the same, it is easier
>> to read.
>>
>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>> Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
>
> I'm not 100% sure the intent of the SPDX work is to remove
> existing licence text.  So far the big sets have only been
> adding tags to files missing their licenses entirely...
>
> Anyone found any specific guidance on this?

Jonathan:
you might want to check the doc patches from tglx [1] as well as
several related patches from greg k-h such as these  [2] and his
initial pull [3]

To get a lot of details you can check all the recent SPDX-related posts too [4]

[1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
[2] https://marc.info/?l=linux-kernel&m=151068111802610&w=2
[3] https://marc.info/?l=linux-kernel&m=150963579219623&w=2
[4] https://marc.info/?l=linux-kernel&w=2&r=1&s=spdx&q=b
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

[harinath Nampally]

> This replaces the custom license information text with the appropriate
> SPDX identifier. While the information here stays the same, it is easier
> to read.
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Acked-by: Harinath Nampally <harinath922@gmail.com>

On Sat, Nov 18, 2017 at 11:29 AM, Philippe Ombredanne
<pombredanne@nexb.com> wrote:
> On Sat, Nov 18, 2017 at 4:53 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On Sat, 18 Nov 2017 10:10:11 +0100
>> Martin Kepplinger <martink@posteo.de> wrote:
>>
>>> This replaces the custom license information text with the appropriate
>>> SPDX identifier. While the information here stays the same, it is easier
>>> to read.
>>>
>>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>>> Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
>>
>> I'm not 100% sure the intent of the SPDX work is to remove
>> existing licence text.  So far the big sets have only been
>> adding tags to files missing their licenses entirely...
>>
>> Anyone found any specific guidance on this?
>
> Jonathan:
> you might want to check the doc patches from tglx [1] as well as
> several related patches from greg k-h such as these  [2] and his
> initial pull [3]
>
> To get a lot of details you can check all the recent SPDX-related posts too [4]
>
> [1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
> [2] https://marc.info/?l=linux-kernel&m=151068111802610&w=2
> [3] https://marc.info/?l=linux-kernel&m=150963579219623&w=2
> [4] https://marc.info/?l=linux-kernel&w=2&r=1&s=spdx&q=b
> --
> Cordially
> Philippe Ombredanne

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

[Jonathan Cameron]

On Sat, 18 Nov 2017 23:23:57 -0500
harinath Nampally <harinath922@gmail.com> wrote:

> > This replaces the custom license information text with the appropriate
> > SPDX identifier. While the information here stays the same, it is easier
> > to read.
> > Signed-off-by: Martin Kepplinger <martink@posteo.de>
> > Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>  
> Acked-by: Harinath Nampally <harinath922@gmail.com>

Applied.  I still not totally sure that the intent of introducing SPDX
specifiers was to replace rather than supplement the license text.
It's been pointed out for instance that some of the BSD licenses have
explicit names in the text relevant to a particular file.  For GPL v2
that isn't the case though so I suppose this one does no harm.

Jonathan
> 
> On Sat, Nov 18, 2017 at 11:29 AM, Philippe Ombredanne
> <pombredanne@nexb.com> wrote:
> > On Sat, Nov 18, 2017 at 4:53 PM, Jonathan Cameron <jic23@kernel.org> wrote:  
> >> On Sat, 18 Nov 2017 10:10:11 +0100
> >> Martin Kepplinger <martink@posteo.de> wrote:
> >>  
> >>> This replaces the custom license information text with the appropriate
> >>> SPDX identifier. While the information here stays the same, it is easier
> >>> to read.
> >>>
> >>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> >>> Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>  
> >>
> >> I'm not 100% sure the intent of the SPDX work is to remove
> >> existing licence text.  So far the big sets have only been
> >> adding tags to files missing their licenses entirely...
> >>
> >> Anyone found any specific guidance on this?  
> >
> > Jonathan:
> > you might want to check the doc patches from tglx [1] as well as
> > several related patches from greg k-h such as these  [2] and his
> > initial pull [3]
> >
> > To get a lot of details you can check all the recent SPDX-related posts too [4]
> >
> > [1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
> > [2] https://marc.info/?l=linux-kernel&m=151068111802610&w=2
> > [3] https://marc.info/?l=linux-kernel&m=150963579219623&w=2
> > [4] https://marc.info/?l=linux-kernel&w=2&r=1&s=spdx&q=b
> > --
> > Cordially
> > Philippe Ombredanne  

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

[Philippe Ombredanne]

On Sun, Dec 10, 2017 at 4:08 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On Sat, 18 Nov 2017 23:23:57 -0500
> harinath Nampally <harinath922@gmail.com> wrote:
>
>> > This replaces the custom license information text with the appropriate
>> > SPDX identifier. While the information here stays the same, it is easier
>> > to read.
>> > Signed-off-by: Martin Kepplinger <martink@posteo.de>
>> > Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
>> Acked-by: Harinath Nampally <harinath922@gmail.com>
>
> Applied.  I still not totally sure that the intent of introducing SPDX
> specifiers was to replace rather than supplement the license text.
> It's been pointed out for instance that some of the BSD licenses have
> explicit names in the text relevant to a particular file.  For GPL v2
> that isn't the case though so I suppose this one does no harm.

Thanks!
There might be indeed a few corner cases that would require some
discussions and the best way would be to have a proper sign off of the
authors when possible in these cases (or all cases)
But to me at least, reducing the boilerplate to the max (such as
replacing 50 lines of legalese with a single SPDX id line) is a big
boost of content/noise ratio that we should thrive for.
-- 
Cordially
Philippe Ombredanne