[PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[rkir]

From: Roman Kiryanov <rkir@google.com>

The only user of RTC_DRV_GOLDFISH is
the MIPS flavor of Android Studio Emulator
(goldfish) which should be also retired.

Signed-off-by: Roman Kiryanov <rkir@google.com>
---
 arch/riscv/Kconfig.socs    |   1 -
 drivers/rtc/Kconfig        |  10 --
 drivers/rtc/Makefile       |   1 -
 drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
 4 files changed, 228 deletions(-)
 delete mode 100644 drivers/rtc/rtc-goldfish.c

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 8a55f6156661..9c4c2abb2011 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -17,7 +17,6 @@ config SOC_VIRT
 	select POWER_RESET_SYSCON
 	select POWER_RESET_SYSCON_POWEROFF
 	select GOLDFISH
-	select RTC_DRV_GOLDFISH if RTC_CLASS
 	select SIFIVE_PLIC
 	help
 	  This enables support for QEMU Virt Machine.
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 65ad9d0b47ab..e574f24f3b08 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1932,16 +1932,6 @@ config RTC_DRV_HID_SENSOR_TIME
 	  If this driver is compiled as a module, it will be named
 	  rtc-hid-sensor-time.
 
-config RTC_DRV_GOLDFISH
-	tristate "Goldfish Real Time Clock"
-	depends on OF && HAS_IOMEM
-	depends on GOLDFISH || COMPILE_TEST
-	help
-	  Say yes to enable RTC driver for the Goldfish based virtual platform.
-
-	  Goldfish is a code name for the virtual platform developed by Google
-	  for Android emulation.
-
 config RTC_DRV_WILCO_EC
 	tristate "Wilco EC RTC"
 	depends on WILCO_EC
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index bfb57464118d..1730d0676096 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -71,7 +71,6 @@ obj-$(CONFIG_RTC_DRV_FM3130)	+= rtc-fm3130.o
 obj-$(CONFIG_RTC_DRV_FSL_FTM_ALARM)	+= rtc-fsl-ftm-alarm.o
 obj-$(CONFIG_RTC_DRV_FTRTC010)	+= rtc-ftrtc010.o
 obj-$(CONFIG_RTC_DRV_GENERIC)	+= rtc-generic.o
-obj-$(CONFIG_RTC_DRV_GOLDFISH)	+= rtc-goldfish.o
 obj-$(CONFIG_RTC_DRV_HID_SENSOR_TIME) += rtc-hid-sensor-time.o
 obj-$(CONFIG_RTC_DRV_HYM8563)	+= rtc-hym8563.o
 obj-$(CONFIG_RTC_DRV_IMXDI)	+= rtc-imxdi.o
diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
deleted file mode 100644
index 6349d2cd3680..000000000000
--- a/drivers/rtc/rtc-goldfish.c
+++ /dev/null
@@ -1,216 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* drivers/rtc/rtc-goldfish.c
- *
- * Copyright (C) 2007 Google, Inc.
- * Copyright (C) 2017 Imagination Technologies Ltd.
- */
-
-#include <linux/io.h>
-#include <linux/module.h>
-#include <linux/of.h>
-#include <linux/platform_device.h>
-#include <linux/rtc.h>
-
-#define TIMER_TIME_LOW		0x00	/* get low bits of current time  */
-					/*   and update TIMER_TIME_HIGH  */
-#define TIMER_TIME_HIGH	0x04	/* get high bits of time at last */
-					/*   TIMER_TIME_LOW read         */
-#define TIMER_ALARM_LOW	0x08	/* set low bits of alarm and     */
-					/*   activate it                 */
-#define TIMER_ALARM_HIGH	0x0c	/* set high bits of next alarm   */
-#define TIMER_IRQ_ENABLED	0x10
-#define TIMER_CLEAR_ALARM	0x14
-#define TIMER_ALARM_STATUS	0x18
-#define TIMER_CLEAR_INTERRUPT	0x1c
-
-struct goldfish_rtc {
-	void __iomem *base;
-	int irq;
-	struct rtc_device *rtc;
-};
-
-static int goldfish_rtc_read_alarm(struct device *dev,
-				   struct rtc_wkalrm *alrm)
-{
-	u64 rtc_alarm;
-	u64 rtc_alarm_low;
-	u64 rtc_alarm_high;
-	void __iomem *base;
-	struct goldfish_rtc *rtcdrv;
-
-	rtcdrv = dev_get_drvdata(dev);
-	base = rtcdrv->base;
-
-	rtc_alarm_low = readl(base + TIMER_ALARM_LOW);
-	rtc_alarm_high = readl(base + TIMER_ALARM_HIGH);
-	rtc_alarm = (rtc_alarm_high << 32) | rtc_alarm_low;
-
-	do_div(rtc_alarm, NSEC_PER_SEC);
-	memset(alrm, 0, sizeof(struct rtc_wkalrm));
-
-	rtc_time64_to_tm(rtc_alarm, &alrm->time);
-
-	if (readl(base + TIMER_ALARM_STATUS))
-		alrm->enabled = 1;
-	else
-		alrm->enabled = 0;
-
-	return 0;
-}
-
-static int goldfish_rtc_set_alarm(struct device *dev,
-				  struct rtc_wkalrm *alrm)
-{
-	struct goldfish_rtc *rtcdrv;
-	u64 rtc_alarm64;
-	u64 rtc_status_reg;
-	void __iomem *base;
-
-	rtcdrv = dev_get_drvdata(dev);
-	base = rtcdrv->base;
-
-	if (alrm->enabled) {
-		rtc_alarm64 = rtc_tm_to_time64(&alrm->time) * NSEC_PER_SEC;
-		writel((rtc_alarm64 >> 32), base + TIMER_ALARM_HIGH);
-		writel(rtc_alarm64, base + TIMER_ALARM_LOW);
-		writel(1, base + TIMER_IRQ_ENABLED);
-	} else {
-		/*
-		 * if this function was called with enabled=0
-		 * then it could mean that the application is
-		 * trying to cancel an ongoing alarm
-		 */
-		rtc_status_reg = readl(base + TIMER_ALARM_STATUS);
-		if (rtc_status_reg)
-			writel(1, base + TIMER_CLEAR_ALARM);
-	}
-
-	return 0;
-}
-
-static int goldfish_rtc_alarm_irq_enable(struct device *dev,
-					 unsigned int enabled)
-{
-	void __iomem *base;
-	struct goldfish_rtc *rtcdrv;
-
-	rtcdrv = dev_get_drvdata(dev);
-	base = rtcdrv->base;
-
-	if (enabled)
-		writel(1, base + TIMER_IRQ_ENABLED);
-	else
-		writel(0, base + TIMER_IRQ_ENABLED);
-
-	return 0;
-}
-
-static irqreturn_t goldfish_rtc_interrupt(int irq, void *dev_id)
-{
-	struct goldfish_rtc *rtcdrv = dev_id;
-	void __iomem *base = rtcdrv->base;
-
-	writel(1, base + TIMER_CLEAR_INTERRUPT);
-
-	rtc_update_irq(rtcdrv->rtc, 1, RTC_IRQF | RTC_AF);
-
-	return IRQ_HANDLED;
-}
-
-static int goldfish_rtc_read_time(struct device *dev, struct rtc_time *tm)
-{
-	struct goldfish_rtc *rtcdrv;
-	void __iomem *base;
-	u64 time_high;
-	u64 time_low;
-	u64 time;
-
-	rtcdrv = dev_get_drvdata(dev);
-	base = rtcdrv->base;
-
-	time_low = readl(base + TIMER_TIME_LOW);
-	time_high = readl(base + TIMER_TIME_HIGH);
-	time = (time_high << 32) | time_low;
-
-	do_div(time, NSEC_PER_SEC);
-
-	rtc_time64_to_tm(time, tm);
-
-	return 0;
-}
-
-static int goldfish_rtc_set_time(struct device *dev, struct rtc_time *tm)
-{
-	struct goldfish_rtc *rtcdrv;
-	void __iomem *base;
-	u64 now64;
-
-	rtcdrv = dev_get_drvdata(dev);
-	base = rtcdrv->base;
-
-	now64 = rtc_tm_to_time64(tm) * NSEC_PER_SEC;
-	writel((now64 >> 32), base + TIMER_TIME_HIGH);
-	writel(now64, base + TIMER_TIME_LOW);
-
-	return 0;
-}
-
-static const struct rtc_class_ops goldfish_rtc_ops = {
-	.read_time	= goldfish_rtc_read_time,
-	.set_time	= goldfish_rtc_set_time,
-	.read_alarm	= goldfish_rtc_read_alarm,
-	.set_alarm	= goldfish_rtc_set_alarm,
-	.alarm_irq_enable = goldfish_rtc_alarm_irq_enable
-};
-
-static int goldfish_rtc_probe(struct platform_device *pdev)
-{
-	struct goldfish_rtc *rtcdrv;
-	int err;
-
-	rtcdrv = devm_kzalloc(&pdev->dev, sizeof(*rtcdrv), GFP_KERNEL);
-	if (!rtcdrv)
-		return -ENOMEM;
-
-	platform_set_drvdata(pdev, rtcdrv);
-	rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(rtcdrv->base))
-		return PTR_ERR(rtcdrv->base);
-
-	rtcdrv->irq = platform_get_irq(pdev, 0);
-	if (rtcdrv->irq < 0)
-		return -ENODEV;
-
-	rtcdrv->rtc = devm_rtc_allocate_device(&pdev->dev);
-	if (IS_ERR(rtcdrv->rtc))
-		return PTR_ERR(rtcdrv->rtc);
-
-	rtcdrv->rtc->ops = &goldfish_rtc_ops;
-	rtcdrv->rtc->range_max = U64_MAX / NSEC_PER_SEC;
-
-	err = devm_request_irq(&pdev->dev, rtcdrv->irq,
-			       goldfish_rtc_interrupt,
-			       0, pdev->name, rtcdrv);
-	if (err)
-		return err;
-
-	return rtc_register_device(rtcdrv->rtc);
-}
-
-static const struct of_device_id goldfish_rtc_of_match[] = {
-	{ .compatible = "google,goldfish-rtc", },
-	{},
-};
-MODULE_DEVICE_TABLE(of, goldfish_rtc_of_match);
-
-static struct platform_driver goldfish_rtc = {
-	.probe = goldfish_rtc_probe,
-	.driver = {
-		.name = "goldfish_rtc",
-		.of_match_table = goldfish_rtc_of_match,
-	}
-};
-
-module_platform_driver(goldfish_rtc);
-
-MODULE_LICENSE("GPL v2");
-- 
2.29.2.299.gdc1121823c-goog

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Rob Herring]

On Fri, Nov 13, 2020 at 12:52:33PM -0800, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
> 
> The only user of RTC_DRV_GOLDFISH is
> the MIPS flavor of Android Studio Emulator
> (goldfish) which should be also retired.
> 
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
>  arch/riscv/Kconfig.socs    |   1 -
>  drivers/rtc/Kconfig        |  10 --
>  drivers/rtc/Makefile       |   1 -
>  drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
>  4 files changed, 228 deletions(-)
>  delete mode 100644 drivers/rtc/rtc-goldfish.c

What about the binding and MAINTAINERS?

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Roman Kiryanov]

Hi Rob, thank you for looking into this.

On Fri, Nov 13, 2020 at 1:07 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Nov 13, 2020 at 12:52:33PM -0800, rkir@google.com wrote:
> > From: Roman Kiryanov <rkir@google.com>
> >
> > The only user of RTC_DRV_GOLDFISH is
> > the MIPS flavor of Android Studio Emulator
> > (goldfish) which should be also retired.
> >
> > Signed-off-by: Roman Kiryanov <rkir@google.com>
> > ---
> >  arch/riscv/Kconfig.socs    |   1 -
> >  drivers/rtc/Kconfig        |  10 --
> >  drivers/rtc/Makefile       |   1 -
> >  drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
> >  4 files changed, 228 deletions(-)
> >  delete mode 100644 drivers/rtc/rtc-goldfish.c
>
> What about the binding and MAINTAINERS?

My bad, I will update those files too.

Regards,
Roman.

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Rob Herring]

On Fri, Nov 13, 2020 at 3:13 PM Roman Kiryanov <rkir@google.com> wrote:
>
> Hi Rob, thank you for looking into this.
>
> On Fri, Nov 13, 2020 at 1:07 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, Nov 13, 2020 at 12:52:33PM -0800, rkir@google.com wrote:
> > > From: Roman Kiryanov <rkir@google.com>
> > >
> > > The only user of RTC_DRV_GOLDFISH is
> > > the MIPS flavor of Android Studio Emulator
> > > (goldfish) which should be also retired.
> > >
> > > Signed-off-by: Roman Kiryanov <rkir@google.com>
> > > ---
> > >  arch/riscv/Kconfig.socs    |   1 -
> > >  drivers/rtc/Kconfig        |  10 --
> > >  drivers/rtc/Makefile       |   1 -
> > >  drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
> > >  4 files changed, 228 deletions(-)
> > >  delete mode 100644 drivers/rtc/rtc-goldfish.c
> >
> > What about the binding and MAINTAINERS?
>
> My bad, I will update those files too.

Though the binding is still used in arch/mips/generic/board-ranchu.c
and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The
latter was just added recently, so maybe premature to remove things?

Rob

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Roman Kiryanov]

Hi Hancai,

I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which
refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
We (Android Studio Emulator aka "goldfish") do not support MIPS anymore.
Do you know if goldfish-rtc still works and is assumed to be available?

On Fri, Nov 13, 2020 at 1:18 PM Rob Herring <robh@kernel.org> wrote:
>
> > > What about the binding and MAINTAINERS?
> >
> > My bad, I will update those files too.
>
> Though the binding is still used in arch/mips/generic/board-ranchu.c
> and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The
> latter was just added recently, so maybe premature to remove things?

Thank you for catching this.

Regards,
Roman.

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Roman Kiryanov]

+Greg KH

On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov <rkir@google.com> wrote:
>
> Hi Hancai,
>
> I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which
> refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
> We (Android Studio Emulator aka "goldfish") do not support MIPS anymore.
> Do you know if goldfish-rtc still works and is assumed to be available?
>
> On Fri, Nov 13, 2020 at 1:18 PM Rob Herring <robh@kernel.org> wrote:
> >
> > > > What about the binding and MAINTAINERS?
> > >
> > > My bad, I will update those files too.
> >
> > Though the binding is still used in arch/mips/generic/board-ranchu.c
> > and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The
> > latter was just added recently, so maybe premature to remove things?
>
> Thank you for catching this.
>
> Regards,
> Roman.

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Greg KH]

On Fri, Nov 13, 2020 at 03:36:49PM -0800, Roman Kiryanov wrote:
> +Greg KH
> 
> On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov <rkir@google.com> wrote:
> >
> > Hi Hancai,
> >
> > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which
> > refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
> > We (Android Studio Emulator aka "goldfish") do not support MIPS anymore.
> > Do you know if goldfish-rtc still works and is assumed to be available?

I've dropped this patch from my trees now, please feel free to resend
when you have an updated version.

thanks,

greg k-h

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Greg KH]

On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
> Hi, All,
> 
> Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
> as well, so I think  we should keep it in kernel.

But does anyone actually use it for anything?  Having something in qemu
is nice, but not required if it doesn't provide something that is
already there for other virtual devices, right?

thanks,

greg k-h

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Greg KH]

On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
> Hi, All,
> 
> Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
> as well, so I think  we should keep it in kernel.

And more importantly, if you rely on this, are you willing to maintain
it?

thanks,

gre gk-h

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Huacai Chen]

Hi, Greg,

On Sat, Nov 14, 2020 at 4:16 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
> > Hi, All,
> >
> > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
> > as well, so I think  we should keep it in kernel.
>
> And more importantly, if you rely on this, are you willing to maintain
> it?
I think it will break the booting of MIPS/RISCV QEMU virtual machines,
because RTC is an necessary device.

For the maintenance, I don't know whether Goldfish RTC depends on the
code under drivers/platform/goldfish. If not, I think I can maintain
it (I think other parts of Goldfish will be removed, I'm able to
maintain RTC but I'm not able to maintain the whole).

Huacai

>
> thanks,
>
> gre gk-h

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Jiaxun Yang]

在 2020/11/14 下午4:15, Greg KH 写道:

+ qemu-riscv list and QEMU device maintainers of goldfish_rtc

> On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
>> Hi, All,
>>
>> Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
>> as well, so I think  we should keep it in kernel.
> But does anyone actually use it for anything?  Having something in qemu
> is nice, but not required if it doesn't provide something that is
> already there for other virtual devices, right?

Hi all,

Both QEMU MIPS loongson3-virt and riscv virt machine are using 
goldfish_rtc as sole RTC
device, it have been hardcoded in QEMU for a long while and sudden drop 
in kernel would
break these machines.
RTC is essential for virt machines to keep time synchronized with host.

Given that it is the simplest RTC implementation for now, it won't give 
us much maintenance
overhead.

Thus I do think it shouldn't be retired as for now. If nobody comes in 
I'd also willing to maintain
it.

Thanks

- Jiaxun

>
> thanks,
>
> greg k-h
>

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Greg KH]

On Sat, Nov 14, 2020 at 05:47:47PM +0800, Jiaxun Yang wrote:
> 
> 
> 在 2020/11/14 下午4:15, Greg KH 写道:
> 
> + qemu-riscv list and QEMU device maintainers of goldfish_rtc
> 
> > On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
> > > Hi, All,
> > > 
> > > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
> > > as well, so I think  we should keep it in kernel.
> > But does anyone actually use it for anything?  Having something in qemu
> > is nice, but not required if it doesn't provide something that is
> > already there for other virtual devices, right?
> 
> Hi all,
> 
> Both QEMU MIPS loongson3-virt and riscv virt machine are using goldfish_rtc
> as sole RTC
> device, it have been hardcoded in QEMU for a long while and sudden drop in
> kernel would
> break these machines.
> RTC is essential for virt machines to keep time synchronized with host.
> 
> Given that it is the simplest RTC implementation for now, it won't give us
> much maintenance
> overhead.
> 
> Thus I do think it shouldn't be retired as for now. If nobody comes in I'd
> also willing to maintain
> it.

Ok, can someone submit a patch to update the MAINTAINERS file for this
so we know who to route issues to over time?

thanks,

greg k-h

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Roman Kiryanov]

Hi Hancai,

do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a
patch to retire it.

Regards,
Roman.

On Sat, Nov 14, 2020 at 12:06 AM 陈华才 <chenhc@lemote.com> wrote:
>
> Hi, All,
>
> Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think  we should keep it in kernel.
>
> Huacai
>
>
> ------------------ Original ------------------
> From:  "Greg KH"<gregkh@linuxfoundation.org>;
> Date:  Sat, Nov 14, 2020 07:43 AM
> To:  "Roman Kiryanov"<rkir@google.com>;
> Cc:  "chenhc"<chenhc@lemote.com>; "Paul Walmsley"<paul.walmsley@sifive.com>; "LKML"<linux-kernel@vger.kernel.org>; "Lingfeng Yang"<lfy@google.com>; "Rob Herring"<robh@kernel.org>;
> Subject:  Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
>
>
>
> On Fri, Nov 13, 2020 at 03:36:49PM -0800, Roman Kiryanov wrote:
> > +Greg KH
> >
> > On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov <rkir@google.com> wrote:
> > >
> > > Hi Hancai,
> > >
> > > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which
> > > refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
> > > We (Android Studio Emulator aka "goldfish") do not support MIPS anymore.
> > > Do you know if goldfish-rtc still works and is assumed to be available?
>
> I've dropped this patch from my trees now, please feel free to resend
> when you have an updated version.
>
> thanks,
>
> greg k-h

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Roman Kiryanov]

> > Thus I do think it shouldn't be retired as for now. If nobody comes in I'd
> > also willing to maintain
> > it.
>
> Ok, can someone submit a patch to update the MAINTAINERS file for this
> so we know who to route issues to over time?

I will send a patch to update MAINTAINERS for goldfish-rtc.

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Huacai Chen]

Hi, Roman,

On Sun, Nov 15, 2020 at 6:02 AM Roman Kiryanov <rkir@google.com> wrote:
>
> Hi Hancai,
>
> do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a
> patch to retire it.
Not required for MIPS.

Huacai
>
> Regards,
> Roman.
>
> On Sat, Nov 14, 2020 at 12:06 AM 陈华才 <chenhc@lemote.com> wrote:
> >
> > Hi, All,
> >
> > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think  we should keep it in kernel.
> >
> > Huacai
> >
> >
> > ------------------ Original ------------------
> > From:  "Greg KH"<gregkh@linuxfoundation.org>;
> > Date:  Sat, Nov 14, 2020 07:43 AM
> > To:  "Roman Kiryanov"<rkir@google.com>;
> > Cc:  "chenhc"<chenhc@lemote.com>; "Paul Walmsley"<paul.walmsley@sifive.com>; "LKML"<linux-kernel@vger.kernel.org>; "Lingfeng Yang"<lfy@google.com>; "Rob Herring"<robh@kernel.org>;
> > Subject:  Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
> >
> >
> >
> > On Fri, Nov 13, 2020 at 03:36:49PM -0800, Roman Kiryanov wrote:
> > > +Greg KH
> > >
> > > On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov <rkir@google.com> wrote:
> > > >
> > > > Hi Hancai,
> > > >
> > > > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which
> > > > refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
> > > > We (Android Studio Emulator aka "goldfish") do not support MIPS anymore.
> > > > Do you know if goldfish-rtc still works and is assumed to be available?
> >
> > I've dropped this patch from my trees now, please feel free to resend
> > when you have an updated version.
> >
> > thanks,
> >
> > greg k-h

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Roman Kiryanov]

On Sat, Nov 14, 2020 at 1:48 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> Thus I do think it shouldn't be retired as for now. If nobody comes in
> I'd also willing to maintain

Hi Jiaxun and Hancai,

I sent a patch to add you to MAINTAINERS for goldfish-rtc. Could you
please ack there?

Regards,
Roman.

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

[Jiaxun Yang]

于 2020年12月9日 GMT+08:00 上午6:28:11, Roman Kiryanov <rkir@google.com> 写到:
>On Sat, Nov 14, 2020 at 1:48 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>> Thus I do think it shouldn't be retired as for now. If nobody comes in
>> I'd also willing to maintain
>
>Hi Jiaxun and Hancai,
>
>I sent a patch to add you to MAINTAINERS for goldfish-rtc. Could you
>please ack there?

Hi Roman,

My patch modifying Maintainers had been accepted by rtc tree.

Thanks.

- Jiaxun

>
>Regards,
>Roman.