From: Pekka Enberg <penberg@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shuah.khan@hp.com,
"Christoph Lameter (Open Source)" <cl@linux.com>,
glommer@parallels.com, js1304@gmail.com,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
shuahkhan@gmail.com
Subject: Re: [PATCH v3] mm: Restructure kmem_cache_create() to move debug cache integrity checks into a new function
Date: Thu, 16 Aug 2012 09:40:10 +0300 [thread overview]
Message-ID: <CAOJsxLFkrNVLhojV=id67xuhXDHyEzZiDo=_peRJtgcfAjC9bg@mail.gmail.com> (raw)
In-Reply-To: <20120815165324.f6e16eee.akpm@linux-foundation.org>
On Thu, Aug 16, 2012 at 2:53 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sun, 12 Aug 2012 10:40:18 -0600
> Shuah Khan <shuah.khan@hp.com> wrote:
>
>> kmem_cache_create() does cache integrity checks when CONFIG_DEBUG_VM
>> is defined. These checks interspersed with the regular code path has
>> lead to compile time warnings when compiled without CONFIG_DEBUG_VM
>> defined. Restructuring the code to move the integrity checks in to a new
>> function would eliminate the current compile warning problem and also
>> will allow for future changes to the debug only code to evolve without
>> introducing new warnings in the regular path. This restructuring work
>> is based on the discussion in the following thread:
>
> Your patch appears to be against some ancient old kernel, such as 3.5.
> I did this:
>
> --- a/mm/slab_common.c~mm-slab_commonc-restructure-kmem_cache_create-to-move-debug-cache-integrity-checks-into-a-new-function-fix
> +++ a/mm/slab_common.c
> @@ -101,15 +101,8 @@ struct kmem_cache *kmem_cache_create(con
>
> get_online_cpus();
> mutex_lock(&slab_mutex);
> -
> - if (kmem_cache_sanity_check(name, size))
> - goto oops;
> -
> - s = __kmem_cache_create(name, size, align, flags, ctor);
> -
> -#ifdef CONFIG_DEBUG_VM
> -oops:
> -#endif
> + if (kmem_cache_sanity_check(name, size) == 0)
> + s = __kmem_cache_create(name, size, align, flags, ctor);
> mutex_unlock(&slab_mutex);
> put_online_cpus();
Yup. Shuah, care to spin another version against slab/next?
next prev parent reply other threads:[~2012-08-16 6:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 23:12 [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create() Shuah Khan
2012-07-14 9:18 ` David Rientjes
2012-07-14 12:01 ` Pekka Enberg
2012-07-16 3:04 ` Shuah Khan
2012-07-16 9:58 ` David Rientjes
2012-07-16 14:17 ` Christoph Lameter
2012-07-16 15:56 ` Shuah Khan
2012-07-16 19:58 ` David Rientjes
2012-07-16 20:14 ` Christoph Lameter
2012-07-16 23:48 ` David Rientjes
2012-07-17 14:36 ` Christoph Lameter
2012-07-17 14:46 ` Pekka Enberg
2012-07-17 15:11 ` Christoph Lameter
2012-07-23 7:04 ` Glauber Costa
2012-07-25 15:28 ` Christoph Lameter
2012-07-17 16:52 ` Shuah Khan
2012-07-30 10:18 ` Pekka Enberg
2012-07-30 19:56 ` David Rientjes
2012-07-30 20:41 ` Pekka Enberg
2012-07-31 2:07 ` David Rientjes
2012-07-31 6:05 ` Pekka Enberg
2012-08-06 3:41 ` Shuah Khan
2012-08-06 15:14 ` [PATCH RESEND] mm: Restructure kmem_cache_create() to move debug cache integrity checks into a new function Shuah Khan
2012-08-06 16:49 ` JoonSoo Kim
2012-08-06 17:03 ` Shuah Khan
2012-08-06 21:13 ` [PATCH v2] " Shuah Khan
2012-08-09 14:06 ` Shuah Khan
2012-08-09 14:13 ` Christoph Lameter (Open Source)
2012-08-09 17:01 ` Shuah Khan
2012-08-09 19:08 ` Christoph Lameter (Open Source)
2012-08-09 19:33 ` Shuah Khan
2012-08-12 16:40 ` [PATCH v3] " Shuah Khan
2012-08-12 17:36 ` Christoph
2012-08-15 23:53 ` Andrew Morton
2012-08-16 6:40 ` Pekka Enberg [this message]
2012-08-08 14:14 ` [PATCH RESEND] " Christoph Lameter (Open Source)
2012-08-08 15:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOJsxLFkrNVLhojV=id67xuhXDHyEzZiDo=_peRJtgcfAjC9bg@mail.gmail.com' \
--to=penberg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).