From: David Rientjes <rientjes@google.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: shuah.khan@hp.com, cl@linux.com, glommer@parallels.com,
js1304@gmail.com, shuahkhan@gmail.com, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()
Date: Mon, 30 Jul 2012 19:07:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1207301904520.24929@chino.kir.corp.google.com> (raw)
In-Reply-To: <CAOJsxLHw8G0ChnOeBv1nNr3tqNPPjdnkY=RStyo3rRqC1bdDAA@mail.gmail.com>
On Mon, 30 Jul 2012, Pekka Enberg wrote:
> > -Wunused-label is overridden in gcc for a label that is conditionally
> > referenced by using __maybe_unused in the kernel. I'm not sure what's so
> > obscure about
> >
> > out: __maybe_unused
> >
> > Are label attributes really that obsecure?
>
> I think they are.
>
> The real problem, however, is that label attributes would just paper
> over the badly thought out control flow in the function and not make the
> code any better or easier to read.
>
So much for compromise, I thought we had agreed that at least some of the
checks for !name, in_interrupt() or bad size values should be moved out
from under the #ifdef CONFIG_DEBUG_VM, but this wasn't done. This
discussion would be irrelevent if we actually did what we talked about.
next prev parent reply other threads:[~2012-07-31 2:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 23:12 [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create() Shuah Khan
2012-07-14 9:18 ` David Rientjes
2012-07-14 12:01 ` Pekka Enberg
2012-07-16 3:04 ` Shuah Khan
2012-07-16 9:58 ` David Rientjes
2012-07-16 14:17 ` Christoph Lameter
2012-07-16 15:56 ` Shuah Khan
2012-07-16 19:58 ` David Rientjes
2012-07-16 20:14 ` Christoph Lameter
2012-07-16 23:48 ` David Rientjes
2012-07-17 14:36 ` Christoph Lameter
2012-07-17 14:46 ` Pekka Enberg
2012-07-17 15:11 ` Christoph Lameter
2012-07-23 7:04 ` Glauber Costa
2012-07-25 15:28 ` Christoph Lameter
2012-07-17 16:52 ` Shuah Khan
2012-07-30 10:18 ` Pekka Enberg
2012-07-30 19:56 ` David Rientjes
2012-07-30 20:41 ` Pekka Enberg
2012-07-31 2:07 ` David Rientjes [this message]
2012-07-31 6:05 ` Pekka Enberg
2012-08-06 3:41 ` Shuah Khan
2012-08-06 15:14 ` [PATCH RESEND] mm: Restructure kmem_cache_create() to move debug cache integrity checks into a new function Shuah Khan
2012-08-06 16:49 ` JoonSoo Kim
2012-08-06 17:03 ` Shuah Khan
2012-08-06 21:13 ` [PATCH v2] " Shuah Khan
2012-08-09 14:06 ` Shuah Khan
2012-08-09 14:13 ` Christoph Lameter (Open Source)
2012-08-09 17:01 ` Shuah Khan
2012-08-09 19:08 ` Christoph Lameter (Open Source)
2012-08-09 19:33 ` Shuah Khan
2012-08-12 16:40 ` [PATCH v3] " Shuah Khan
2012-08-12 17:36 ` Christoph
2012-08-15 23:53 ` Andrew Morton
2012-08-16 6:40 ` Pekka Enberg
2012-08-08 14:14 ` [PATCH RESEND] " Christoph Lameter (Open Source)
2012-08-08 15:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1207301904520.24929@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=shuah.khan@hp.com \
--cc=shuahkhan@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).