Re: [PATCH v2 1/2] Making si_swapinfo exportable

[Pekka Enberg <penberg@kernel.org>]

On Tue, Jan 17, 2012 at 3:22 PM, Leonid Moiseichuk
<leonid.moiseichuk@nokia.com> wrote:
> If we will make si_swapinfo() exportable it could be called from modules.
> Otherwise modules have no interface to obtain information about swap usage.
> Change made in the same way as si_meminfo() declared.
>
> Signed-off-by: Leonid Moiseichuk <leonid.moiseichuk@nokia.com>
> ---
>  mm/swapfile.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index b1cd120..192cc25 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -5,10 +5,12 @@
>  *  Swap reorganised 29.12.95, Stephen Tweedie
>  */
>
> +#include <linux/export.h>
>  #include <linux/mm.h>
>  #include <linux/hugetlb.h>
>  #include <linux/mman.h>
>  #include <linux/slab.h>
> +#include <linux/kernel.h>
>  #include <linux/kernel_stat.h>
>  #include <linux/swap.h>
>  #include <linux/vmalloc.h>
> @@ -2177,6 +2179,7 @@ void si_swapinfo(struct sysinfo *val)
>        val->totalswap = total_swap_pages + nr_to_be_unused;
>        spin_unlock(&swap_lock);
>  }
> +EXPORT_SYMBOL(si_swapinfo);

FWIW, I'm completely OK with this export:

  Acked-by: Pekka Enberg <penberg@kernel.org>