linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Leonid Moiseichuk <leonid.moiseichuk@nokia.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	cesarb@cesarb.net, kamezawa.hiroyu@jp.fujitsu.com,
	emunson@mgebm.net, aarcange@redhat.com, riel@redhat.com,
	mel@csn.ul.ie, rientjes@google.com, dima@android.com,
	rebecca@android.com, san@google.com, akpm@linux-foundation.org,
	vesa.jaaskelainen@nokia.com
Subject: Re: [PATCH v2 1/2] Making si_swapinfo exportable
Date: Wed, 18 Jan 2012 07:00:07 -0800	[thread overview]
Message-ID: <20120118150007.GA18315@suse.de> (raw)
In-Reply-To: <20120118144618.GA7438@phenom.dumpdata.com>

On Wed, Jan 18, 2012 at 09:46:18AM -0500, Konrad Rzeszutek Wilk wrote:
> > > > +EXPORT_SYMBOL(si_swapinfo);
> > 
> > EXPORT_SYMBOL_GPL() perhaps?
> 
> Greg,
> 
> So.. could you tell when are suppose to do _GPL and when not? Is there
> a policy of "new code must be _GPL" ? Or is there some extra "if .. then"
> conditions?

It's up to the author of the code, what their preference is.

I just generally prefer _GPL for new exports.

thanks,

greg k-h

  reply	other threads:[~2012-01-18 15:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-17 13:22 [PATCH v2 0/2] Memory notification pseudo-device module Leonid Moiseichuk
2012-01-17 13:22 ` [PATCH v2 1/2] Making si_swapinfo exportable Leonid Moiseichuk
2012-01-18 10:34   ` Pekka Enberg
2012-01-18 14:09     ` Greg KH
2012-01-18 14:46       ` Konrad Rzeszutek Wilk
2012-01-18 15:00         ` Greg KH [this message]
2012-01-18 14:47       ` leonid.moiseichuk
2012-01-18 15:00         ` Greg KH
2012-01-18 15:20           ` Pekka Enberg
2012-01-17 13:22 ` [PATCH v2 2/2] Memory notification pseudo-device module Leonid Moiseichuk
2012-01-17 13:32   ` Pekka Enberg
2012-01-17 13:45     ` leonid.moiseichuk
2012-01-17 13:58       ` Pekka Enberg
2012-01-17 14:28         ` leonid.moiseichuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118150007.GA18315@suse.de \
    --to=gregkh@suse.de \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cesarb@cesarb.net \
    --cc=dima@android.com \
    --cc=emunson@mgebm.net \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=konrad.wilk@oracle.com \
    --cc=leonid.moiseichuk@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=penberg@kernel.org \
    --cc=rebecca@android.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=san@google.com \
    --cc=vesa.jaaskelainen@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).