From: Tianyu Lan <lantianyu1986@gmail.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Lan Tianyu <Tianyu.Lan@microsoft.com>,
mchehab+samsung@kernel.org, davem@davemloft.net,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
akpm@linux-foundation.org, nicolas.ferre@microchip.com,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org, michael.h.kelley@microsoft.com,
kys@microsoft.com, Vitaly Kuznetsov <vkuznets@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver
Date: Sat, 2 Feb 2019 10:51:23 +0800 [thread overview]
Message-ID: <CAOLK0pw3zaanNbzJ67sqPQ=ETctM39+=kSh99euq0wmz-ehrUA@mail.gmail.com> (raw)
In-Reply-To: <20190201163443.GS32526@8bytes.org>
Hi Joerg:
Thanks for your review.
On Sat, Feb 2, 2019 at 12:34 AM Joerg Roedel <joro@8bytes.org> wrote:
>
> Hi,
>
> On Thu, Jan 31, 2019 at 06:17:32PM +0800, lantianyu1986@gmail.com wrote:
> > +config HYPERV_IOMMU
> > + bool "Hyper-V stub IOMMU support"
>
> This is not a real IOMMU driver, it only implements IRQ remapping
> capabilities. Please change the name to reflect that, e.g. to
> "Hyper-V IRQ Remapping Support" or something like that.
Yes, that makes sense. Will update.
>
> > +static int __init hyperv_prepare_irq_remapping(void)
> > +{
> > + struct fwnode_handle *fn;
> > + u32 apic_id;
> > + int i;
> > +
> > + if (x86_hyper_type != X86_HYPER_MS_HYPERV ||
> > + !x2apic_supported())
> > + return -ENODEV;
> > +
> > + fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
> > + if (!fn)
> > + return -EFAULT;
>
> Why does this return -EFAULT? I guess there is no fault happening in
> irq_domain_alloc_named_id_fwnode()...
Yes, “-ENOMEM” should be more accurate.
--
Best regards
Tianyu Lan
next prev parent reply other threads:[~2019-02-02 2:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 10:17 [PATCH 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode lantianyu1986
2019-01-31 10:17 ` [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available lantianyu1986
2019-01-31 11:57 ` Greg KH
2019-01-31 12:02 ` Tianyu Lan
2019-02-01 7:06 ` Dan Carpenter
2019-02-01 7:10 ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver lantianyu1986
2019-01-31 11:59 ` Greg KH
2019-01-31 12:08 ` Tianyu Lan
2019-01-31 14:04 ` Vitaly Kuznetsov
2019-02-01 5:45 ` Tianyu Lan
2019-02-01 16:34 ` Joerg Roedel
2019-02-02 2:51 ` Tianyu Lan [this message]
2019-02-01 17:00 ` Robin Murphy
2019-02-02 6:20 ` Tianyu Lan
[not found] ` <20190201145130.GW3973@sasha-vm>
2019-02-02 6:02 ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 3/3] MAINTAINERS: Add Hyper-V IOMMU driver into Hyper-V CORE AND DRIVERS scope lantianyu1986
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLK0pw3zaanNbzJ67sqPQ=ETctM39+=kSh99euq0wmz-ehrUA@mail.gmail.com' \
--to=lantianyu1986@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=nicolas.ferre@microchip.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).