From: Tianyu Lan <lantianyu1986@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
mchehab+samsung@kernel.org, sashal@kernel.org,
sthemmin@microsoft.com, Joerg Roedel <joro@8bytes.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
michael.h.kelley@microsoft.com, Ingo Molnar <mingo@redhat.com>,
Lan Tianyu <Tianyu.Lan@microsoft.com>,
Arnd Bergmann <arnd@arndb.de>,
haiyangz@microsoft.com,
Alex Williamson <alex.williamson@redhat.com>,
bp@alien8.de, Thomas Gleixner <tglx@linutronix.de>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
nicolas.ferre@microchip.com, iommu@lists.linux-foundation.org,
devel@linuxdriverproject.org, akpm@linux-foundation.org,
davem@davemloft.net
Subject: Re: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available
Date: Fri, 1 Feb 2019 15:10:55 +0800 [thread overview]
Message-ID: <CAOLK0pyET5GGqMcoK7u5781mf_U1js6LtfoYxMpntwVCfGO3Zg@mail.gmail.com> (raw)
In-Reply-To: <20190201070655.GA14343@kadam>
On Fri, Feb 1, 2019 at 3:07 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1986@gmail.com wrote:
> >
> >
>
> This comment needs to be indented one tab or it looks like we're outside
> the funciton.
>
> > +/*
> > + * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic,
> > + * set x2apic destination mode to physcial mode when x2apic is available
> > + * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs
> > + * have 8-bit APIC id.
> > + */
> > +# if IS_ENABLED(CONFIG_HYPERV_IOMMU)
> > + if (x2apic_supported())
> > + x2apic_phys = 1;
> > +# endif
>
> The IS_ENABLED() macro is really magical. You could write this like so:
>
> if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported())
> x2apic_phys = 1;
>
> It works the same and is slightly more pleasant to look at.
Yes, that will better. Thanks for your suggestion. Dan
--
Best regards
Tianyu Lan
next prev parent reply other threads:[~2019-02-01 7:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 10:17 [PATCH 0/3] x86/Hyper-V/IOMMU: Add Hyper-V IOMMU driver to support x2apic mode lantianyu1986
2019-01-31 10:17 ` [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available lantianyu1986
2019-01-31 11:57 ` Greg KH
2019-01-31 12:02 ` Tianyu Lan
2019-02-01 7:06 ` Dan Carpenter
2019-02-01 7:10 ` Tianyu Lan [this message]
2019-01-31 10:17 ` [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver lantianyu1986
2019-01-31 11:59 ` Greg KH
2019-01-31 12:08 ` Tianyu Lan
2019-01-31 14:04 ` Vitaly Kuznetsov
2019-02-01 5:45 ` Tianyu Lan
2019-02-01 16:34 ` Joerg Roedel
2019-02-02 2:51 ` Tianyu Lan
2019-02-01 17:00 ` Robin Murphy
2019-02-02 6:20 ` Tianyu Lan
[not found] ` <20190201145130.GW3973@sasha-vm>
2019-02-02 6:02 ` Tianyu Lan
2019-01-31 10:17 ` [PATCH 3/3] MAINTAINERS: Add Hyper-V IOMMU driver into Hyper-V CORE AND DRIVERS scope lantianyu1986
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOLK0pyET5GGqMcoK7u5781mf_U1js6LtfoYxMpntwVCfGO3Zg@mail.gmail.com \
--to=lantianyu1986@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=nicolas.ferre@microchip.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).