* [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
@ 2017-11-30 20:14 ` tyler
2017-12-01 20:10 ` Fabio Estevam
2017-11-30 20:14 ` [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb tyler
` (6 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker, Ilya Ledvich
From: Tyler Baker <tyler@opensourcefoundries.com>
The Compulab IoT Gateway is based on an NXP i.MX7D, dual core
Cortex-A7 clocking at 1GHz. It supports up to 2GB of DDR3,
and 32GB of eMMC flash. Onboard, there are two gigabit
ethernet controllers, 4 x USB2, RS485, and CAN.
This platform is based on the imx7d-cl-som-imx7 module but
includes a baseboard with additional peripherals
which is what this device tree is meant to describe.
This work has been derrived from the Compulab Linux sources
based on v4.1.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
---
arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts | 238 +++++++++++++++++++++++++++++++
1 file changed, 238 insertions(+)
create mode 100644 arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts
diff --git a/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts b/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts
new file mode 100644
index 0000000..50dfdd3
--- /dev/null
+++ b/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts
@@ -0,0 +1,238 @@
+/*
+ * Support for CompuLab SBC-IOT-iMX7 Single Board Computer
+ *
+ * Copyright (C) 2017 CompuLab Ltd. - http://www.compulab.co.il/
+ * Author: Ilya Ledvich <ilya@compulab.co.il>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "imx7d-cl-som-imx7.dts"
+
+/ {
+ model = "CompuLab SBC-IOT-iMX7";
+ compatible = "compulab,sbc-iot-imx7", "compulab,cl-som-imx7", "fsl,imx7d";
+
+ aliases {
+ lcdif = &lcdif;
+ };
+};
+
+&ecspi3 {
+ fsl,spi-num-chipselects = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi3 &pinctrl_ecspi3_cs>;
+ cs-gpios = <&gpio4 11 0>;
+ status = "okay";
+};
+
+&i2c3 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3>;
+ status = "okay";
+};
+
+&i2c4 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c4>;
+ status = "okay";
+
+ eeprom_iot@54 {
+ compatible = "atmel,24c08";
+ reg = <0x54>;
+ pagesize = <16>;
+ };
+
+ dvicape@39 {
+ compatible = "sil164_simple";
+ reg = <0x39>;
+ };
+};
+
+&iomuxc {
+ pinctrl_xpen: xpengrp {
+ fsl,pins = <
+ MX7D_PAD_LCD_DATA13__GPIO3_IO18 0x34 /* P7-4 - gpio82 */
+ MX7D_PAD_LCD_DATA12__GPIO3_IO17 0x34 /* P7-5 - gpio81 */
+ >;
+ };
+
+ pinctrl_ecspi3: ecspi3grp {
+ fsl,pins = <
+ MX7D_PAD_I2C1_SDA__ECSPI3_MOSI 0xf /* P7-8 */
+ MX7D_PAD_I2C1_SCL__ECSPI3_MISO 0xf /* P7-7 */
+ MX7D_PAD_I2C2_SCL__ECSPI3_SCLK 0xf /* P7-6 */
+ >;
+ };
+
+ pinctrl_ecspi3_cs: ecspi3_cs_grp {
+ fsl,pins = <
+ MX7D_PAD_I2C2_SDA__GPIO4_IO11 0x34 /* P7-9 */
+ >;
+ };
+
+ pinctrl_i2c3: i2c3grp {
+ fsl,pins = <
+ MX7D_PAD_GPIO1_IO09__I2C3_SDA 0x4000000f /* P7-3 */
+ MX7D_PAD_GPIO1_IO08__I2C3_SCL 0x4000000f /* P7-2 */
+ >;
+ };
+
+ pinctrl_i2c4: i2c4grp {
+ fsl,pins = <
+ MX7D_PAD_GPIO1_IO11__I2C4_SDA 0x4000000f
+ MX7D_PAD_GPIO1_IO10__I2C4_SCL 0x4000000f
+ >;
+ };
+
+ pinctrl_lcdif_dat: lcdifdatgrp {
+ fsl,pins = <
+ MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79
+ MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79
+ MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79
+ MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79
+ MX7D_PAD_EPDC_DATA04__LCD_DATA4 0x79
+ MX7D_PAD_EPDC_DATA05__LCD_DATA5 0x79
+ MX7D_PAD_EPDC_DATA06__LCD_DATA6 0x79
+ MX7D_PAD_EPDC_DATA07__LCD_DATA7 0x79
+ MX7D_PAD_EPDC_DATA08__LCD_DATA8 0x79
+ MX7D_PAD_EPDC_DATA09__LCD_DATA9 0x79
+ MX7D_PAD_EPDC_DATA10__LCD_DATA10 0x79
+ MX7D_PAD_EPDC_DATA11__LCD_DATA11 0x79
+ MX7D_PAD_EPDC_DATA12__LCD_DATA12 0x79
+ MX7D_PAD_EPDC_DATA13__LCD_DATA13 0x79
+ MX7D_PAD_EPDC_DATA14__LCD_DATA14 0x79
+ MX7D_PAD_EPDC_DATA15__LCD_DATA15 0x79
+ MX7D_PAD_LCD_DATA16__LCD_DATA16 0x79
+ MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79
+ MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79
+ MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79
+ MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79
+ MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79
+ MX7D_PAD_LCD_DATA22__LCD_DATA22 0x79
+ MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79
+ >;
+ };
+
+ pinctrl_lcdif_ctrl: lcdifctrlgrp {
+ fsl,pins = <
+ MX7D_PAD_EPDC_DATA00__LCD_CLK 0x79
+ MX7D_PAD_EPDC_DATA01__LCD_ENABLE 0x79
+ MX7D_PAD_EPDC_DATA02__LCD_VSYNC 0x79
+ MX7D_PAD_EPDC_DATA03__LCD_HSYNC 0x79
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX7D_PAD_LCD_ENABLE__UART2_DCE_TX 0x79 /* P7-12 */
+ MX7D_PAD_LCD_CLK__UART2_DCE_RX 0x79 /* P7-13 */
+ MX7D_PAD_LCD_VSYNC__UART2_DCE_CTS 0x79 /* P7-11 */
+ MX7D_PAD_LCD_HSYNC__UART2_DCE_RTS 0x79 /* P7-10 */
+ >;
+ };
+
+ pinctrl_uart5: uart5grp {
+ fsl,pins = <
+ MX7D_PAD_I2C4_SDA__UART5_DCE_TX 0x79 /* RS232-TX */
+ MX7D_PAD_I2C4_SCL__UART5_DCE_RX 0x79 /* RS232-RX */
+ MX7D_PAD_I2C3_SDA__UART5_DCE_RTS 0x79 /* RS232-RTS */
+ MX7D_PAD_I2C3_SCL__UART5_DCE_CTS 0x79 /* RS232-CTS */
+ >;
+ };
+
+ pinctrl_uart7: uart7grp {
+ fsl,pins = <
+ MX7D_PAD_ECSPI2_MOSI__UART7_DCE_TX 0x79 /* R485-TX */
+ MX7D_PAD_ECSPI2_SCLK__UART7_DCE_RX 0x79 /* R485-RX */
+ MX7D_PAD_ECSPI2_SS0__UART7_DCE_CTS 0x79 /* R485-CTS */
+ MX7D_PAD_ECSPI2_MISO__UART7_DCE_RTS 0x79 /* R485-TTS */
+ >;
+ };
+
+ pinctrl_usdhc1: usdhc1grp {
+ fsl,pins = <
+ MX7D_PAD_SD1_CMD__SD1_CMD 0x59
+ MX7D_PAD_SD1_CLK__SD1_CLK 0x19
+ MX7D_PAD_SD1_DATA0__SD1_DATA0 0x59
+ MX7D_PAD_SD1_DATA1__SD1_DATA1 0x59
+ MX7D_PAD_SD1_DATA2__SD1_DATA2 0x59
+ MX7D_PAD_SD1_DATA3__SD1_DATA3 0x59
+ MX7D_PAD_SD1_CD_B__GPIO5_IO0 0x59 /* CD */
+ >;
+ };
+};
+
+&lcdif {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_lcdif_dat
+ &pinctrl_lcdif_ctrl>;
+ display = <&display0>;
+ status = "okay";
+
+ display0: display {
+ bits-per-pixel = <24>;
+ bus-width = <24>;
+
+ display-timings {
+ native-mode = <&timing0>;
+ timing0: dvi {
+ /* 1024x768p60 */
+ clock-frequency = <65000000>;
+ hactive = <1024>;
+ hfront-porch = <40>;
+ hback-porch = <220>;
+ hsync-len = <60>;
+ vactive = <768>;
+ vfront-porch = <7>;
+ vback-porch = <21>;
+ vsync-len = <10>;
+
+ hsync-active = <0>;
+ vsync-active = <0>;
+ de-active = <1>;
+ pixelclk-active = <0>;
+ };
+ };
+ };
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>;
+ assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
+ fsl,uart-has-rtscts;
+ status = "okay";
+};
+
+&uart5 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart5>;
+ assigned-clocks = <&clks IMX7D_UART5_ROOT_SRC>;
+ assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
+ fsl,uart-has-rtscts;
+ status = "okay";
+};
+
+&uart7 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart7>;
+ assigned-clocks = <&clks IMX7D_UART7_ROOT_SRC>;
+ assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
+ fsl,uart-has-rtscts;
+ status = "okay";
+};
+
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
+ wp-gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>;
+ enable-sdio-wakeup;
+ status = "okay";
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts
2017-11-30 20:14 ` [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts tyler
@ 2017-12-01 20:10 ` Fabio Estevam
2017-12-05 20:58 ` Tyler Baker
0 siblings, 1 reply; 19+ messages in thread
From: Fabio Estevam @ 2017-12-01 20:10 UTC (permalink / raw)
To: tyler
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, robh+dt, Mark Rutland,
linux-arm-kernel, devicetree, linux-kernel, Ilya Ledvich
On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
> +&ecspi3 {
> + fsl,spi-num-chipselects = <1>;
Please remove this property. It is no longer used.
> + dvicape@39 {
> + compatible = "sil164_simple";
This compatible string does not exist.
> +&lcdif {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcdif_dat
> + &pinctrl_lcdif_ctrl>;
> + display = <&display0>;
> + status = "okay";
> +
> + display0: display {
> + bits-per-pixel = <24>;
> + bus-width = <24>;
> +
> + display-timings {
> + native-mode = <&timing0>;
> + timing0: dvi {
> + /* 1024x768p60 */
> + clock-frequency = <65000000>;
> + hactive = <1024>;
> + hfront-porch = <40>;
> + hback-porch = <220>;
> + hsync-len = <60>;
> + vactive = <768>;
> + vfront-porch = <7>;
> + vback-porch = <21>;
> + vsync-len = <10>;
> +
> + hsync-active = <0>;
> + vsync-active = <0>;
> + de-active = <1>;
> + pixelclk-active = <0>;
Which panel is this? Could you use a simple panel driver compatible
string instead?
> + };
> + };
> + };
> +};
> +
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart2>;
> + assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>;
> + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
> + fsl,uart-has-rtscts;
Please use 'uart-has-rtscts' instead.
> + status = "okay";
> +};
> +
> +&uart5 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart5>;
> + assigned-clocks = <&clks IMX7D_UART5_ROOT_SRC>;
> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
> + fsl,uart-has-rtscts;
Ditto.
> + status = "okay";
> +};
> +
> +&uart7 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart7>;
> + assigned-clocks = <&clks IMX7D_UART7_ROOT_SRC>;
> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
> + fsl,uart-has-rtscts;
Ditto
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts
2017-12-01 20:10 ` Fabio Estevam
@ 2017-12-05 20:58 ` Tyler Baker
0 siblings, 0 replies; 19+ messages in thread
From: Tyler Baker @ 2017-12-05 20:58 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, robh+dt, Mark Rutland,
linux-arm-kernel, devicetree, linux-kernel, Ilya Ledvich
On Fri, Dec 1, 2017 at 12:10 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
>
>> +&ecspi3 {
>> + fsl,spi-num-chipselects = <1>;
>
> Please remove this property. It is no longer used.
Ack.
>
>
>> + dvicape@39 {
>> + compatible = "sil164_simple";
>
> This compatible string does not exist.
I'm going to drop this, and address the display hardware it in a later series.
>
>
>
>> +&lcdif {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_lcdif_dat
>> + &pinctrl_lcdif_ctrl>;
>> + display = <&display0>;
>> + status = "okay";
>> +
>> + display0: display {
>> + bits-per-pixel = <24>;
>> + bus-width = <24>;
>> +
>> + display-timings {
>> + native-mode = <&timing0>;
>> + timing0: dvi {
>> + /* 1024x768p60 */
>> + clock-frequency = <65000000>;
>> + hactive = <1024>;
>> + hfront-porch = <40>;
>> + hback-porch = <220>;
>> + hsync-len = <60>;
>> + vactive = <768>;
>> + vfront-porch = <7>;
>> + vback-porch = <21>;
>> + vsync-len = <10>;
>> +
>> + hsync-active = <0>;
>> + vsync-active = <0>;
>> + de-active = <1>;
>> + pixelclk-active = <0>;
>
> Which panel is this? Could you use a simple panel driver compatible
> string instead?
I'll switch to a simple panel driver and do some more testing. Will
submit a follow up series to address the LCD panel and dvi cape.
>
>
>> + };
>> + };
>> + };
>> +};
>> +
>> +&uart2 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_uart2>;
>> + assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>;
>> + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
>> + fsl,uart-has-rtscts;
>
> Please use 'uart-has-rtscts' instead.
Ack.
>
>> + status = "okay";
>> +};
>> +
>> +&uart5 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_uart5>;
>> + assigned-clocks = <&clks IMX7D_UART5_ROOT_SRC>;
>> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
>> + fsl,uart-has-rtscts;
>
> Ditto.
Ack.
>
>> + status = "okay";
>> +};
>> +
>> +&uart7 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_uart7>;
>> + assigned-clocks = <&clks IMX7D_UART7_ROOT_SRC>;
>> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
>> + fsl,uart-has-rtscts;
>
> Ditto
Ack.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
2017-11-30 20:14 ` [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts tyler
@ 2017-11-30 20:14 ` tyler
2017-12-01 20:11 ` Fabio Estevam
2017-11-30 20:14 ` [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2 tyler
` (5 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker
From: Tyler Baker <tyler@opensourcefoundries.com>
Build the imx7d-sbc-iot-imx7 device tree blob.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
---
arch/arm/boot/dts/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d0381e9..0334137 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -515,6 +515,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \
imx7d-nitrogen7.dtb \
imx7d-pico.dtb \
imx7d-sbc-imx7.dtb \
+ imx7d-sbc-iot-imx7.dtb \
imx7d-sdb.dtb \
imx7d-sdb-sht11.dtb \
imx7s-colibri-eval-v3.dtb \
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb
2017-11-30 20:14 ` [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb tyler
@ 2017-12-01 20:11 ` Fabio Estevam
2017-12-05 20:58 ` Tyler Baker
0 siblings, 1 reply; 19+ messages in thread
From: Fabio Estevam @ 2017-12-01 20:11 UTC (permalink / raw)
To: tyler
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, Mark Rutland, devicetree,
linux-kernel, robh+dt, linux-arm-kernel
On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
> From: Tyler Baker <tyler@opensourcefoundries.com>
>
> Build the imx7d-sbc-iot-imx7 device tree blob.
>
> Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d0381e9..0334137 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -515,6 +515,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \
> imx7d-nitrogen7.dtb \
> imx7d-pico.dtb \
> imx7d-sbc-imx7.dtb \
> + imx7d-sbc-iot-imx7.dtb \
This could be part of the previous patch that introduces the dts.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb
2017-12-01 20:11 ` Fabio Estevam
@ 2017-12-05 20:58 ` Tyler Baker
0 siblings, 0 replies; 19+ messages in thread
From: Tyler Baker @ 2017-12-05 20:58 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, Mark Rutland, devicetree,
linux-kernel, robh+dt, linux-arm-kernel
On Fri, Dec 1, 2017 at 12:11 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
>> From: Tyler Baker <tyler@opensourcefoundries.com>
>>
>> Build the imx7d-sbc-iot-imx7 device tree blob.
>>
>> Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index d0381e9..0334137 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -515,6 +515,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \
>> imx7d-nitrogen7.dtb \
>> imx7d-pico.dtb \
>> imx7d-sbc-imx7.dtb \
>> + imx7d-sbc-iot-imx7.dtb \
>
> This could be part of the previous patch that introduces the dts.
Ok will do.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
2017-11-30 20:14 ` [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts tyler
2017-11-30 20:14 ` [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb tyler
@ 2017-11-30 20:14 ` tyler
2017-12-01 20:13 ` Fabio Estevam
2017-11-30 20:14 ` [PATCH 4/8] ARM: dts: imx7s: add dma support tyler
` (4 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker
From: Tyler Baker <tyler@opensourcefoundries.com>
Add device tree nodes for the USB hub, and USB OTG. i2c2 on this
platform supports low state retention power state so lets use it.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
---
arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 36 +++++++++++++++++++++++++--------
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
index ae45af1..a9f690b 100644
--- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
+++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
@@ -30,6 +30,16 @@
gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
+
+ reg_usbh_nreset: regulator@4 {
+ compatible = "regulator-fixed";
+ regulator-name = "usb_host_nreset";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&pca9555 6 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ regulator-always-on;
+ };
};
&cpu0 {
@@ -199,6 +209,16 @@
status = "okay";
};
+&usbotg2 {
+ dr_mode = "host";
+ status = "okay";
+};
+
+&usbh {
+ vbus-supply = <®_usbh_nreset>;
+ status = "okay";
+};
+
&usdhc3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc3>;
@@ -247,13 +267,6 @@
>;
};
- pinctrl_i2c2: i2c2grp {
- fsl,pins = <
- MX7D_PAD_I2C2_SDA__I2C2_SDA 0x4000007f
- MX7D_PAD_I2C2_SCL__I2C2_SCL 0x4000007f
- >;
- };
-
pinctrl_uart1: uart1grp {
fsl,pins = <
MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79
@@ -284,4 +297,11 @@
MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x14 /* OTG PWREN */
>;
};
-};
\ No newline at end of file
+
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX7D_PAD_LPSR_GPIO1_IO07__I2C2_SDA 0x4000000f
+ MX7D_PAD_LPSR_GPIO1_IO06__I2C2_SCL 0x4000000f
+ >;
+ };
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2
2017-11-30 20:14 ` [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2 tyler
@ 2017-12-01 20:13 ` Fabio Estevam
2017-12-05 20:59 ` Tyler Baker
0 siblings, 1 reply; 19+ messages in thread
From: Fabio Estevam @ 2017-12-01 20:13 UTC (permalink / raw)
To: tyler
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, Mark Rutland, devicetree,
linux-kernel, robh+dt, linux-arm-kernel
On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
> From: Tyler Baker <tyler@opensourcefoundries.com>
>
> Add device tree nodes for the USB hub, and USB OTG. i2c2 on this
> platform supports low state retention power state so lets use it.
>
> Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
> ---
> arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 36 +++++++++++++++++++++++++--------
> 1 file changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> index ae45af1..a9f690b 100644
> --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> @@ -30,6 +30,16 @@
> gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
> +
> + reg_usbh_nreset: regulator@4 {
You should not use @4. Please make sure that regulators are not used
inside simple-bus.
> -
> pinctrl_uart1: uart1grp {
> fsl,pins = <
> MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79
> @@ -284,4 +297,11 @@
> MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x14 /* OTG PWREN */
> >;
> };
> -};
> \ No newline at end of file
This text here looks strange :-)
> +
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX7D_PAD_LPSR_GPIO1_IO07__I2C2_SDA 0x4000000f
> + MX7D_PAD_LPSR_GPIO1_IO06__I2C2_SCL 0x4000000f
> + >;
> + };
> +};
> --
> 2.9.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2
2017-12-01 20:13 ` Fabio Estevam
@ 2017-12-05 20:59 ` Tyler Baker
0 siblings, 0 replies; 19+ messages in thread
From: Tyler Baker @ 2017-12-05 20:59 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, Mark Rutland, devicetree,
linux-kernel, robh+dt, linux-arm-kernel
On Fri, Dec 1, 2017 at 12:13 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
>> From: Tyler Baker <tyler@opensourcefoundries.com>
>>
>> Add device tree nodes for the USB hub, and USB OTG. i2c2 on this
>> platform supports low state retention power state so lets use it.
>>
>> Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
>> ---
>> arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 36 +++++++++++++++++++++++++--------
>> 1 file changed, 28 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>> index ae45af1..a9f690b 100644
>> --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>> @@ -30,6 +30,16 @@
>> gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
>> enable-active-high;
>> };
>> +
>> + reg_usbh_nreset: regulator@4 {
>
> You should not use @4. Please make sure that regulators are not used
> inside simple-bus.
Good catch, will fix.
>> -
>> pinctrl_uart1: uart1grp {
>> fsl,pins = <
>> MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79
>> @@ -284,4 +297,11 @@
>> MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x14 /* OTG PWREN */
>> >;
>> };
>> -};
>> \ No newline at end of file
>
> This text here looks strange :-)
Indeed, I'll scrub it.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 4/8] ARM: dts: imx7s: add dma support
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
` (2 preceding siblings ...)
2017-11-30 20:14 ` [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2 tyler
@ 2017-11-30 20:14 ` tyler
2017-12-01 20:17 ` Fabio Estevam
2017-11-30 20:14 ` [PATCH 5/8] ARM: dts: imx7s: add node and supplies for vdd1p2 tyler
` (3 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker
From: Tyler Baker <tyler@opensourcefoundries.com>
Enable dma on all SPI and UART interfaces.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
---
arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 82ad26e..7b85659 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -700,6 +700,8 @@
clocks = <&clks IMX7D_ECSPI1_ROOT_CLK>,
<&clks IMX7D_ECSPI1_ROOT_CLK>;
clock-names = "ipg", "per";
+ dmas = <&sdma 0 7 1>, <&sdma 1 7 2>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -712,6 +714,8 @@
clocks = <&clks IMX7D_ECSPI2_ROOT_CLK>,
<&clks IMX7D_ECSPI2_ROOT_CLK>;
clock-names = "ipg", "per";
+ dmas = <&sdma 2 7 1>, <&sdma 3 7 2>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -724,6 +728,8 @@
clocks = <&clks IMX7D_ECSPI3_ROOT_CLK>,
<&clks IMX7D_ECSPI3_ROOT_CLK>;
clock-names = "ipg", "per";
+ dmas = <&sdma 4 7 1>, <&sdma 5 7 2>;
+ dma-names = "rx", "tx";
status = "disabled";
};
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 4/8] ARM: dts: imx7s: add dma support
2017-11-30 20:14 ` [PATCH 4/8] ARM: dts: imx7s: add dma support tyler
@ 2017-12-01 20:17 ` Fabio Estevam
2017-12-05 20:59 ` Tyler Baker
0 siblings, 1 reply; 19+ messages in thread
From: Fabio Estevam @ 2017-12-01 20:17 UTC (permalink / raw)
To: tyler
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, robh+dt, Mark Rutland,
linux-arm-kernel, devicetree, linux-kernel
On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
> From: Tyler Baker <tyler@opensourcefoundries.com>
>
> Enable dma on all SPI and UART interfaces.
You only touched SPI ports, not the UART.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/8] ARM: dts: imx7s: add dma support
2017-12-01 20:17 ` Fabio Estevam
@ 2017-12-05 20:59 ` Tyler Baker
0 siblings, 0 replies; 19+ messages in thread
From: Tyler Baker @ 2017-12-05 20:59 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, robh+dt, Mark Rutland,
linux-arm-kernel, devicetree, linux-kernel
On Fri, Dec 1, 2017 at 12:17 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
>> From: Tyler Baker <tyler@opensourcefoundries.com>
>>
>> Enable dma on all SPI and UART interfaces.
>
> You only touched SPI ports, not the UART.
I'll update the commit message, thanks.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 5/8] ARM: dts: imx7s: add node and supplies for vdd1p2
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
` (3 preceding siblings ...)
2017-11-30 20:14 ` [PATCH 4/8] ARM: dts: imx7s: add dma support tyler
@ 2017-11-30 20:14 ` tyler
2017-11-30 20:14 ` [PATCH 6/8] ARM: dts: imx7d-sbc-iot: enable PCIe peripheral tyler
` (2 subsequent siblings)
7 siblings, 0 replies; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker
From: Tyler Baker <tyler@opensourcefoundries.com>
Add the regulator nodes and supplies for vdd1p2. This regulator is
used to power the GPC and USB HSIC PHY.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
---
arch/arm/boot/dts/imx7s.dtsi | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 7b85659..151ab34 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -522,6 +522,20 @@
anatop-max-voltage = <1200000>;
anatop-enable-bit = <0>;
};
+
+ reg_1p2: regulator-vdd1p2@220 {
+ compatible = "fsl,anatop-regulator";
+ regulator-name = "vdd1p2";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1300000>;
+ anatop-reg-offset = <0x220>;
+ anatop-vol-bit-shift = <8>;
+ anatop-vol-bit-width = <5>;
+ anatop-min-bit-val = <8>;
+ anatop-min-voltage = <1100000>;
+ anatop-max-voltage = <1300000>;
+ anatop-enable-bit = <0>;
+ };
};
snvs: snvs@30370000 {
@@ -578,7 +592,7 @@
#interrupt-cells = <3>;
interrupt-parent = <&intc>;
#power-domain-cells = <1>;
-
+ vcc-supply = <®_1p2>;
pgc {
#address-cells = <1>;
#size-cells = <0>;
@@ -961,6 +975,7 @@
compatible = "usb-nop-xceiv";
clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
clock-names = "main_clk";
+ vcc-supply = <®_1p2>;
};
usdhc1: usdhc@30b40000 {
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 6/8] ARM: dts: imx7d-sbc-iot: enable PCIe peripheral
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
` (4 preceding siblings ...)
2017-11-30 20:14 ` [PATCH 5/8] ARM: dts: imx7s: add node and supplies for vdd1p2 tyler
@ 2017-11-30 20:14 ` tyler
2017-11-30 20:14 ` [PATCH 7/8] ARM: dts: imx7s: add usb hsic phy domain tyler
2017-11-30 20:14 ` [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source tyler
7 siblings, 0 replies; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker
From: Tyler Baker <tyler@opensourcefoundries.com>
Add a PCIe device tree node to enable PCIe support.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
---
arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts b/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts
index 50dfdd3..7b21366 100644
--- a/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts
+++ b/arch/arm/boot/dts/imx7d-sbc-iot-imx7.dts
@@ -127,6 +127,12 @@
>;
};
+ pinctrl_pcie: pciegrp {
+ fsl,pins = <
+ MX7D_PAD_EPDC_BDR1__GPIO2_IO29 0x34 /* PCIe RST */
+ >;
+ };
+
pinctrl_uart2: uart2grp {
fsl,pins = <
MX7D_PAD_LCD_ENABLE__UART2_DCE_TX 0x79 /* P7-12 */
@@ -201,6 +207,14 @@
};
};
+&pcie {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pcie>;
+ reset-gpio = <&gpio2 29 GPIO_ACTIVE_LOW>;
+ phy-ref-clk = <1>;
+ status = "okay";
+};
+
&uart2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart2>;
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 7/8] ARM: dts: imx7s: add usb hsic phy domain
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
` (5 preceding siblings ...)
2017-11-30 20:14 ` [PATCH 6/8] ARM: dts: imx7d-sbc-iot: enable PCIe peripheral tyler
@ 2017-11-30 20:14 ` tyler
2017-11-30 20:14 ` [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source tyler
7 siblings, 0 replies; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker
From: Tyler Baker <tyler@opensourcefoundries.com>
The GPCv2 driver should control the MIPI, PCIe,
and USB HSIC PHY regulators. Add the USB HSIC
power domain to the GPC node.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
---
arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 151ab34..9626a3e 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -602,6 +602,12 @@
reg = <IMX7_POWER_DOMAIN_PCIE_PHY>;
power-supply = <®_1p0d>;
};
+ pgc_usb_hsic_phy: pgc-usb-hsic-phy-domain {
+ #power-domain-cells = <0>;
+
+ reg = <IMX7_POWER_DOMAIN_USB_HSIC_PHY>;
+ power-supply = <®_1p2>;
+ };
};
};
};
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source
2017-11-30 20:14 [PATCH 0/8] ARM: dts: introduce Compulab IoT Gateway tyler
` (6 preceding siblings ...)
2017-11-30 20:14 ` [PATCH 7/8] ARM: dts: imx7s: add usb hsic phy domain tyler
@ 2017-11-30 20:14 ` tyler
2017-12-01 20:21 ` Fabio Estevam
7 siblings, 1 reply; 19+ messages in thread
From: tyler @ 2017-11-30 20:14 UTC (permalink / raw)
To: shawnguo, fabio.estevam, kernel
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Tyler Baker, Ilya Ledvich
From: Tyler Baker <tyler@opensourcefoundries.com>
In the i.MX7D the PCIe PHY can use either externel oscillator or
internal PLL as a reference clock source.
Add support for the PHY Reference Clock source including
device tree property phy-ref-clk.
External oscillator is used as a default reference clock source.
Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
---
drivers/pci/dwc/pci-imx6.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index b734835..e935db4 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -45,6 +45,7 @@ enum imx6_pcie_variants {
struct imx6_pcie {
struct dw_pcie *pci;
int reset_gpio;
+ u32 phy_refclk;
bool gpio_active_high;
struct clk *pcie_bus;
struct clk *pcie_phy;
@@ -474,7 +475,7 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
switch (imx6_pcie->variant) {
case IMX7D:
regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
- IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
+ BIT(5), imx6_pcie->phy_refclk ? BIT(5) : 0);
break;
case IMX6SX:
regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
@@ -733,6 +734,11 @@ static int imx6_pcie_probe(struct platform_device *pdev)
if (IS_ERR(pci->dbi_base))
return PTR_ERR(pci->dbi_base);
+ /* Fetch PHY Reference Clock */
+ if (of_property_read_u32(node, "phy-ref-clk", &imx6_pcie->phy_refclk))
+ imx6_pcie->phy_refclk = 0;
+ pr_info("%s: phy_refclk = %d\n", __func__, imx6_pcie->phy_refclk);
+
/* Fetch GPIOs */
imx6_pcie->reset_gpio = of_get_named_gpio(node, "reset-gpio", 0);
imx6_pcie->gpio_active_high = of_property_read_bool(node,
--
2.9.3
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source
2017-11-30 20:14 ` [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source tyler
@ 2017-12-01 20:21 ` Fabio Estevam
2017-12-05 20:58 ` Tyler Baker
0 siblings, 1 reply; 19+ messages in thread
From: Fabio Estevam @ 2017-12-01 20:21 UTC (permalink / raw)
To: tyler
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, robh+dt, Mark Rutland,
linux-arm-kernel, devicetree, linux-kernel, Ilya Ledvich
On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
> From: Tyler Baker <tyler@opensourcefoundries.com>
>
> In the i.MX7D the PCIe PHY can use either externel oscillator or
> internal PLL as a reference clock source.
> Add support for the PHY Reference Clock source including
> device tree property phy-ref-clk.
> External oscillator is used as a default reference clock source.
>
> Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
> Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
Please submit this one to the PCI list and PCI maintainers.
As you are adding a new property you should update
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt.
> ---
> drivers/pci/dwc/pci-imx6.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
> index b734835..e935db4 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -45,6 +45,7 @@ enum imx6_pcie_variants {
> struct imx6_pcie {
> struct dw_pcie *pci;
> int reset_gpio;
> + u32 phy_refclk;
Could this be bool instead?
> bool gpio_active_high;
> struct clk *pcie_bus;
> struct clk *pcie_phy;
> @@ -474,7 +475,7 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
> switch (imx6_pcie->variant) {
> case IMX7D:
> regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> - IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
> + BIT(5), imx6_pcie->phy_refclk ? BIT(5) : 0);
> break;
> case IMX6SX:
> regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> @@ -733,6 +734,11 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> if (IS_ERR(pci->dbi_base))
> return PTR_ERR(pci->dbi_base);
>
> + /* Fetch PHY Reference Clock */
> + if (of_property_read_u32(node, "phy-ref-clk", &imx6_pcie->phy_refclk))
You could use of_property_read_bool instead.
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 8/8] PCIe: imx6: imx7d: add support for phy refclk source
2017-12-01 20:21 ` Fabio Estevam
@ 2017-12-05 20:58 ` Tyler Baker
0 siblings, 0 replies; 19+ messages in thread
From: Tyler Baker @ 2017-12-05 20:58 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Fabio Estevam, Sascha Hauer, robh+dt, Mark Rutland,
linux-arm-kernel, devicetree, linux-kernel, Ilya Ledvich
On Fri, Dec 1, 2017 at 12:21 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote:
>> From: Tyler Baker <tyler@opensourcefoundries.com>
>>
>> In the i.MX7D the PCIe PHY can use either externel oscillator or
>> internal PLL as a reference clock source.
>> Add support for the PHY Reference Clock source including
>> device tree property phy-ref-clk.
>> External oscillator is used as a default reference clock source.
>>
>> Signed-off-by: Tyler Baker <tyler@opensourcefoundries.com>
>> Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
>
> Please submit this one to the PCI list and PCI maintainers.
Ack. Will do.
>
> As you are adding a new property you should update
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt.
I'll add this when I resubmit to the PCI list.
>
>> ---
>> drivers/pci/dwc/pci-imx6.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git adrivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
>> index b734835..e935db4 100644
>> --- a/drivers/pci/dwc/pci-imx6.c
>> +++ b/drivers/pci/dwc/pci-imx6.c
>> @@ -45,6 +45,7 @@ enum imx6_pcie_variants {
>> struct imx6_pcie {
>> struct dw_pcie *pci;
>> int reset_gpio;
>> + u32 phy_refclk;
>
> Could this be bool instead?
>
>> bool gpio_active_high;
>> struct clk *pcie_bus;
>> struct clk *pcie_phy;
>> @@ -474,7 +475,7 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
>> switch (imx6_pcie->variant) {
>> case IMX7D:
>> regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
>> - IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
>> + BIT(5), imx6_pcie->phy_refclk ? BIT(5) : 0);
>> break;
>> case IMX6SX:
>> regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
>> @@ -733,6 +734,11 @@ static int imx6_pcie_probe(struct platform_device *pdev)
>> if (IS_ERR(pci->dbi_base))
>> return PTR_ERR(pci->dbi_base);
>>
>> + /* Fetch PHY Reference Clock */
>> + if (of_property_read_u32(node, "phy-ref-clk", &imx6_pcie->phy_refclk))
>
> You could use of_property_read_bool instead.
Thanks for the review, I'll switch to to use a bool instead.
^ permalink raw reply [flat|nested] 19+ messages in thread