* [PATCH -next] imx7: fix Kconfig warning and build errors
@ 2017-04-12 18:22 Randy Dunlap
2017-04-12 18:26 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2017-04-12 18:22 UTC (permalink / raw)
To: LKML
Cc: Andrew Morton, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-arm-kernel
From: Randy Dunlap <rdunlap@infradead.org>
Fix Kconfig warning in drivers/soc/imx/Kconfig and subsequent build errors
elsewhere when CONFIG_PM is not enabled.
warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
This warning causes multiple build errors in drivers/base/power/domain.c:
../drivers/base/power/domain.c: In function 'genpd_queue_power_off_work':
../drivers/base/power/domain.c:279:13: error: 'pm_wq' undeclared (first use in this function)
queue_work(pm_wq, &genpd->power_off_work);
../drivers/base/power/domain.c: In function 'genpd_dev_pm_qos_notifier':
../drivers/base/power/domain.c:462:25: error: 'struct dev_pm_info' has no member named 'ignore_children'
if (!dev || dev->power.ignore_children)
../drivers/base/power/domain.c: In function 'rtpm_status_str':
../drivers/base/power/domain.c:2207:16: error: 'struct dev_pm_info' has no member named 'runtime_error'
if (dev->power.runtime_error)
../drivers/base/power/domain.c:2209:21: error: 'struct dev_pm_info' has no member named 'disable_depth'
else if (dev->power.disable_depth)
../drivers/base/power/domain.c:2211:21: error: 'struct dev_pm_info' has no member named 'runtime_status'
else if (dev->power.runtime_status < ARRAY_SIZE(status_lookup))
p = status_lookup[dev->power.runtime_status];
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/soc/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20170412.orig/drivers/soc/imx/Kconfig
+++ linux-next-20170412/drivers/soc/imx/Kconfig
@@ -2,6 +2,7 @@ menu "i.MX SoC drivers"
config IMX7_PM_DOMAINS
bool "i.MX7 PM domains"
+ depends on PM
select PM_GENERIC_DOMAINS
depends on SOC_IMX7D || (COMPILE_TEST && OF)
default y if SOC_IMX7D
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] imx7: fix Kconfig warning and build errors
2017-04-12 18:22 [PATCH -next] imx7: fix Kconfig warning and build errors Randy Dunlap
@ 2017-04-12 18:26 ` Fabio Estevam
2017-04-12 19:24 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2017-04-12 18:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Fabio Estevam, Andrew Morton, Shawn Guo, linux-arm-kernel,
Sascha Hauer
On Wed, Apr 12, 2017 at 3:22 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> --- linux-next-20170412.orig/drivers/soc/imx/Kconfig
> +++ linux-next-20170412/drivers/soc/imx/Kconfig
> @@ -2,6 +2,7 @@ menu "i.MX SoC drivers"
>
> config IMX7_PM_DOMAINS
> bool "i.MX7 PM domains"
> + depends on PM
> select PM_GENERIC_DOMAINS
Could this be:
select PM_GENERIC_DOMAINS if PM instead?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] imx7: fix Kconfig warning and build errors
2017-04-12 18:26 ` Fabio Estevam
@ 2017-04-12 19:24 ` Randy Dunlap
2017-04-12 19:55 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2017-04-12 19:24 UTC (permalink / raw)
To: Fabio Estevam
Cc: LKML, Fabio Estevam, Andrew Morton, Shawn Guo, linux-arm-kernel,
Sascha Hauer
On 04/12/17 11:26, Fabio Estevam wrote:
> On Wed, Apr 12, 2017 at 3:22 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> --- linux-next-20170412.orig/drivers/soc/imx/Kconfig
>> +++ linux-next-20170412/drivers/soc/imx/Kconfig
>> @@ -2,6 +2,7 @@ menu "i.MX SoC drivers"
>>
>> config IMX7_PM_DOMAINS
>> bool "i.MX7 PM domains"
>> + depends on PM
>> select PM_GENERIC_DOMAINS
>
> Could this be:
>
> select PM_GENERIC_DOMAINS if PM instead?
>
You want IMX7_PM_DOMAINS to be built without having
PM_GENERIC_DOMAINS enabled?
On x86, your suggestion works for me... because of this
in drivers/soc/Makefile:
obj-$(CONFIG_ARCH_MXC) += imx/
and I don't have CONFIG_ARCH_MXC, so the gpc* binaries are
not being built at all. This might be a small bug.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] imx7: fix Kconfig warning and build errors
2017-04-12 19:24 ` Randy Dunlap
@ 2017-04-12 19:55 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-04-12 19:55 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Fabio Estevam, Andrew Morton, Shawn Guo, linux-arm-kernel,
Sascha Hauer
On Wed, Apr 12, 2017 at 4:24 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> You want IMX7_PM_DOMAINS to be built without having
> PM_GENERIC_DOMAINS enabled?
>
> On x86, your suggestion works for me... because of this
> in drivers/soc/Makefile:
>
> obj-$(CONFIG_ARCH_MXC) += imx/
>
> and I don't have CONFIG_ARCH_MXC, so the gpc* binaries are
> not being built at all. This might be a small bug.
Just tested your patch with imx_v6_v7_defconfig + manually doing
CONFIG_PM=n and it does fix the build error, thanks:
Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-12 19:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 18:22 [PATCH -next] imx7: fix Kconfig warning and build errors Randy Dunlap
2017-04-12 18:26 ` Fabio Estevam
2017-04-12 19:24 ` Randy Dunlap
2017-04-12 19:55 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).