* [PATCH 1/1] ARM: clk-imx6q: refine sata's parent
@ 2015-05-20 14:30 Sébastien Szymanski
2015-05-20 15:20 ` Fabio Estevam
2015-05-21 1:18 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Sébastien Szymanski @ 2015-05-20 14:30 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Mike Turquette, Stephen Boyd,
linux-arm-kernel, linux-clk, linux-kernel
Cc: Sébastien Szymanski
According to IMX6D/Q RM, table 18-3, sata clock's parent is ahb, not ipg.
This patch is based on branch:
git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/soc
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
drivers/clk/imx/clk-imx6q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index 128f887..d046f8e 100644
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -450,7 +450,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
clk[IMX6QDL_CLK_GPMI_IO] = imx_clk_gate2("gpmi_io", "enfc", base + 0x78, 28);
clk[IMX6QDL_CLK_GPMI_APB] = imx_clk_gate2("gpmi_apb", "usdhc3", base + 0x78, 30);
clk[IMX6QDL_CLK_ROM] = imx_clk_gate2("rom", "ahb", base + 0x7c, 0);
- clk[IMX6QDL_CLK_SATA] = imx_clk_gate2("sata", "ipg", base + 0x7c, 4);
+ clk[IMX6QDL_CLK_SATA] = imx_clk_gate2("sata", "ahb", base + 0x7c, 4);
clk[IMX6QDL_CLK_SDMA] = imx_clk_gate2("sdma", "ahb", base + 0x7c, 6);
clk[IMX6QDL_CLK_SPBA] = imx_clk_gate2("spba", "ipg", base + 0x7c, 12);
clk[IMX6QDL_CLK_SPDIF] = imx_clk_gate2("spdif", "spdif_podf", base + 0x7c, 14);
--
2.0.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: clk-imx6q: refine sata's parent
2015-05-20 14:30 [PATCH 1/1] ARM: clk-imx6q: refine sata's parent Sébastien Szymanski
@ 2015-05-20 15:20 ` Fabio Estevam
2015-05-21 1:18 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2015-05-20 15:20 UTC (permalink / raw)
To: Sébastien Szymanski
Cc: Shawn Guo, Sascha Hauer, Mike Turquette, Stephen Boyd,
linux-arm-kernel, linux-clk, linux-kernel
On Wed, May 20, 2015 at 11:30 AM, Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
> According to IMX6D/Q RM, table 18-3, sata clock's parent is ahb, not ipg.
Good catch!
>
> This patch is based on branch:
> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/soc
Please put this below the --- line.
Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: clk-imx6q: refine sata's parent
2015-05-20 14:30 [PATCH 1/1] ARM: clk-imx6q: refine sata's parent Sébastien Szymanski
2015-05-20 15:20 ` Fabio Estevam
@ 2015-05-21 1:18 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2015-05-21 1:18 UTC (permalink / raw)
To: Sébastien Szymanski
Cc: Sascha Hauer, Mike Turquette, Stephen Boyd, linux-arm-kernel,
linux-clk, linux-kernel
On Wed, May 20, 2015 at 04:30:37PM +0200, Sébastien Szymanski wrote:
> According to IMX6D/Q RM, table 18-3, sata clock's parent is ahb, not ipg.
>
> This patch is based on branch:
> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/soc
Dropped these two lines, and applied patch.
Shawn
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> drivers/clk/imx/clk-imx6q.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> index 128f887..d046f8e 100644
> --- a/drivers/clk/imx/clk-imx6q.c
> +++ b/drivers/clk/imx/clk-imx6q.c
> @@ -450,7 +450,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
> clk[IMX6QDL_CLK_GPMI_IO] = imx_clk_gate2("gpmi_io", "enfc", base + 0x78, 28);
> clk[IMX6QDL_CLK_GPMI_APB] = imx_clk_gate2("gpmi_apb", "usdhc3", base + 0x78, 30);
> clk[IMX6QDL_CLK_ROM] = imx_clk_gate2("rom", "ahb", base + 0x7c, 0);
> - clk[IMX6QDL_CLK_SATA] = imx_clk_gate2("sata", "ipg", base + 0x7c, 4);
> + clk[IMX6QDL_CLK_SATA] = imx_clk_gate2("sata", "ahb", base + 0x7c, 4);
> clk[IMX6QDL_CLK_SDMA] = imx_clk_gate2("sdma", "ahb", base + 0x7c, 6);
> clk[IMX6QDL_CLK_SPBA] = imx_clk_gate2("spba", "ipg", base + 0x7c, 12);
> clk[IMX6QDL_CLK_SPDIF] = imx_clk_gate2("spdif", "spdif_podf", base + 0x7c, 14);
> --
> 2.0.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-21 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-20 14:30 [PATCH 1/1] ARM: clk-imx6q: refine sata's parent Sébastien Szymanski
2015-05-20 15:20 ` Fabio Estevam
2015-05-21 1:18 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).