* [PATCH] gpu: ipu-v3: use swap()
@ 2021-07-13 13:32 Salah Triki
2021-07-13 13:44 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2021-07-13 13:32 UTC (permalink / raw)
To: p.zabel, alexdeucher; +Cc: dri-devel, linux-kernel
Use swap() instead of implementing it since it makes code more clean.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c
index aa1d4b6d278f..5f730cd6009d 100644
--- a/drivers/gpu/ipu-v3/ipu-image-convert.c
+++ b/drivers/gpu/ipu-v3/ipu-image-convert.c
@@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx,
u_off = y_size - y_off + uv_off;
v_off = (fmt->uv_packed) ? 0 : u_off + uv_size;
- if (fmt->uv_swapped) {
- tmp = u_off;
- u_off = v_off;
- v_off = tmp;
- }
+ if (fmt->uv_swapped)
+ swap(u_off, v_off);
image->tile[tile].offset = y_off;
image->tile[tile].u_off = u_off;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpu: ipu-v3: use swap()
2021-07-13 13:32 [PATCH] gpu: ipu-v3: use swap() Salah Triki
@ 2021-07-13 13:44 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2021-07-13 13:44 UTC (permalink / raw)
To: Salah Triki; +Cc: Philipp Zabel, alexdeucher, linux-kernel, DRI mailing list
Hi Salah,
On Tue, Jul 13, 2021 at 10:33 AM Salah Triki <salah.triki@gmail.com> wrote:
>
> Use swap() instead of implementing it since it makes code more clean.
s/more clean/cleaner
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c
> index aa1d4b6d278f..5f730cd6009d 100644
> --- a/drivers/gpu/ipu-v3/ipu-image-convert.c
> +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c
> @@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx,
>
> u_off = y_size - y_off + uv_off;
> v_off = (fmt->uv_packed) ? 0 : u_off + uv_size;
> - if (fmt->uv_swapped) {
> - tmp = u_off;
> - u_off = v_off;
> - v_off = tmp;
The 'tmp' variable seems to be unused now, so its declaration should be removed.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-13 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 13:32 [PATCH] gpu: ipu-v3: use swap() Salah Triki
2021-07-13 13:44 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).