From: Fabio Estevam <festevam@gmail.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes
Date: Tue, 25 Aug 2020 14:16:05 -0300 [thread overview]
Message-ID: <CAOMZO5CP=wtJ5ZScyb0NrRMW0FR0FAGVKRFq9JpFcAoZppn_bA@mail.gmail.com> (raw)
In-Reply-To: <7a59492e46f34d213b83f7182c7db73954c5a9c7.camel@ew.tq-group.com>
On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer
<matthias.schiffer@ew.tq-group.com> wrote:
> Makes sense. Does the following logic sound correct?
>
> - If num-cs is set, use that (and add it to the docs)
I would not add num-cs to the docs. As far as I can see there is no
imx dts that uses num-cs currently.
> - If num-cs is unset, use the number of cs-gpios
> - If num-cs is unset and no cs-gpios are defined, use a driver-provided
> default
>
>
> I'm not sure if 3 is a particularly useful default either, but it seems
> it was chosen to accommodate boards that previously set this via
> platform data. All SoCs I've checked (i.MX6Q/DL, i.MX6UL, i.MX7) have 4
> internal CS pins per ECSPI instance, so maybe the driver should use
> that as its default instead?
I think it is time to get rid of i.MX board files. I will try to work
on this when I have a chance.
bout using 4 as default chip select number, please also check some
older SoCs like imx25, imx35, imx51, imx53, etc
next prev parent reply other threads:[~2020-08-25 17:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:10 [PATCH 1/2] ARM: dts: imx6qdl: tqma6: fix indentation Matthias Schiffer
2020-08-24 9:10 ` [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes Matthias Schiffer
2020-08-24 21:36 ` Fabio Estevam
2020-08-25 7:22 ` (EXT) " Matthias Schiffer
2020-08-25 14:24 ` Fabio Estevam
2020-08-25 14:40 ` (EXT) " Matthias Schiffer
2020-08-25 17:16 ` Fabio Estevam [this message]
2020-08-26 10:32 ` (EXT) " Matthias Schiffer
2020-08-26 10:34 ` Matthias Schiffer
2020-08-26 10:59 ` Fabio Estevam
2020-08-26 11:54 ` (EXT) " Matthias Schiffer
2020-08-26 13:01 ` Fabio Estevam
2020-08-26 13:13 ` (EXT) " Matthias Schiffer
2020-08-26 13:49 ` Fabio Estevam
2020-08-27 7:31 ` Matthias Schiffer
2020-08-27 21:27 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CP=wtJ5ZScyb0NrRMW0FR0FAGVKRFq9JpFcAoZppn_bA@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).