From: Fabio Estevam <festevam@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Lucas Stach <l.stach@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
The etnaviv authors <etnaviv@lists.freedesktop.org>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks
Date: Wed, 13 May 2020 13:07:06 -0300 [thread overview]
Message-ID: <CAOMZO5CfPC_awoo4RRgOabWYk8WaAKJUypG8A=XeuThuCZHqDQ@mail.gmail.com> (raw)
In-Reply-To: <20200513150007.1315395-3-lkundrak@v3.sk>
Hi Lubomir,
On Wed, May 13, 2020 at 12:08 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
> /* Get Clocks: */
> - gpu->clk_reg = devm_clk_get(&pdev->dev, "reg");
> + gpu->clk_reg = devm_clk_get_optional(&pdev->dev, "reg");
> DBG("clk_reg: %p", gpu->clk_reg);
> if (IS_ERR(gpu->clk_reg))
> - gpu->clk_reg = NULL;
> + return err;
You should return PTR_ERR(gpu->clk_reg) instead.
next prev parent reply other threads:[~2020-05-13 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/3] drm/etnaviv: Clock fixes>
2020-05-13 15:00 ` Lubomir Rintel
2020-05-13 15:00 ` [PATCH 1/3] drm/etnaviv: Fix error path on failure to enable bus clk Lubomir Rintel
2020-05-13 15:00 ` [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks Lubomir Rintel
2020-05-13 16:07 ` Fabio Estevam [this message]
2020-05-13 17:09 ` Fabio Estevam
2020-05-14 2:41 ` Fabio Estevam
2020-05-14 8:18 ` Lucas Stach
2020-05-14 8:27 ` Russell King - ARM Linux admin
2020-05-14 8:40 ` Lucas Stach
2020-05-14 8:53 ` Russell King - ARM Linux admin
2020-05-20 13:38 ` Lubomir Rintel
2020-05-20 14:04 ` Lucas Stach
2020-05-20 15:00 ` Russell King - ARM Linux admin
2020-05-23 10:22 ` Lubomir Rintel
2020-05-13 15:00 ` [PATCH 3/3] drm/etnaviv: Simplify clock enable/disable Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CfPC_awoo4RRgOabWYk8WaAKJUypG8A=XeuThuCZHqDQ@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).