* [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates
@ 2018-06-03 1:44 Anson Huang
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Anson Huang @ 2018-06-03 1:44 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, robh+dt, mark.rutland,
mturquette, sboyd, michael, matteo.lisi
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel, linux-clk
i.MX6UL has GPIO clock gates in CCM CCGR,
add them into clock tree for clock management.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
Move IMX6UL_CLK_GPIOx definition to end of clock table;
Based on Fabio's patch "[v2] dt-bindings: clock: imx6ul: Do not change the clock definition order".
drivers/clk/imx/clk-imx6ul.c | 5 +++++
include/dt-bindings/clock/imx6ul-clock.h | 8 +++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index ba563ba..3ea2d97 100644
--- a/drivers/clk/imx/clk-imx6ul.c
+++ b/drivers/clk/imx/clk-imx6ul.c
@@ -360,6 +360,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
clks[IMX6UL_CLK_UART2_SERIAL] = imx_clk_gate2("uart2_serial", "uart_podf", base + 0x68, 28);
if (clk_on_imx6ull())
clks[IMX6UL_CLK_AIPSTZ3] = imx_clk_gate2("aips_tz3", "ahb", base + 0x80, 18);
+ clks[IMX6UL_CLK_GPIO2] = imx_clk_gate2("gpio2", "ipg", base + 0x68, 30);
/* CCGR1 */
clks[IMX6UL_CLK_ECSPI1] = imx_clk_gate2("ecspi1", "ecspi_podf", base + 0x6c, 0);
@@ -376,6 +377,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
clks[IMX6UL_CLK_GPT1_SERIAL] = imx_clk_gate2("gpt1_serial", "perclk", base + 0x6c, 22);
clks[IMX6UL_CLK_UART4_IPG] = imx_clk_gate2("uart4_ipg", "ipg", base + 0x6c, 24);
clks[IMX6UL_CLK_UART4_SERIAL] = imx_clk_gate2("uart4_serial", "uart_podf", base + 0x6c, 24);
+ clks[IMX6UL_CLK_GPIO1] = imx_clk_gate2("gpio1", "ipg", base + 0x6c, 26);
+ clks[IMX6UL_CLK_GPIO5] = imx_clk_gate2("gpio5", "ipg", base + 0x6c, 30);
/* CCGR2 */
if (clk_on_imx6ull()) {
@@ -389,6 +392,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
clks[IMX6UL_CLK_I2C3] = imx_clk_gate2("i2c3", "perclk", base + 0x70, 10);
clks[IMX6UL_CLK_OCOTP] = imx_clk_gate2("ocotp", "ipg", base + 0x70, 12);
clks[IMX6UL_CLK_IOMUXC] = imx_clk_gate2("iomuxc", "lcdif_podf", base + 0x70, 14);
+ clks[IMX6UL_CLK_GPIO3] = imx_clk_gate2("gpio3", "ipg", base + 0x70, 26);
clks[IMX6UL_CLK_LCDIF_APB] = imx_clk_gate2("lcdif_apb", "axi", base + 0x70, 28);
clks[IMX6UL_CLK_PXP] = imx_clk_gate2("pxp", "axi", base + 0x70, 30);
@@ -405,6 +409,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
clks[IMX6UL_CLK_UART6_IPG] = imx_clk_gate2("uart6_ipg", "ipg", base + 0x74, 6);
clks[IMX6UL_CLK_UART6_SERIAL] = imx_clk_gate2("uart6_serial", "uart_podf", base + 0x74, 6);
clks[IMX6UL_CLK_LCDIF_PIX] = imx_clk_gate2("lcdif_pix", "lcdif_podf", base + 0x74, 10);
+ clks[IMX6UL_CLK_GPIO4] = imx_clk_gate2("gpio4", "ipg", base + 0x74, 12);
clks[IMX6UL_CLK_QSPI] = imx_clk_gate2("qspi1", "qspi1_podf", base + 0x74, 14);
clks[IMX6UL_CLK_WDOG1] = imx_clk_gate2("wdog1", "ipg", base + 0x74, 16);
clks[IMX6UL_CLK_MMDC_P0_FAST] = imx_clk_gate("mmdc_p0_fast", "mmdc_podf", base + 0x74, 20);
diff --git a/include/dt-bindings/clock/imx6ul-clock.h b/include/dt-bindings/clock/imx6ul-clock.h
index 0aa1d9c..f8e0476 100644
--- a/include/dt-bindings/clock/imx6ul-clock.h
+++ b/include/dt-bindings/clock/imx6ul-clock.h
@@ -254,6 +254,12 @@
#define IMX6UL_CLK_CKO2_PODF 241
#define IMX6UL_CLK_CKO2 242
#define IMX6UL_CLK_CKO 243
-#define IMX6UL_CLK_END 244
+#define IMX6UL_CLK_GPIO1 244
+#define IMX6UL_CLK_GPIO2 245
+#define IMX6UL_CLK_GPIO3 246
+#define IMX6UL_CLK_GPIO4 247
+#define IMX6UL_CLK_GPIO5 248
+
+#define IMX6UL_CLK_END 249
#endif /* __DT_BINDINGS_CLOCK_IMX6UL_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-03 1:44 [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
@ 2018-06-03 1:44 ` Anson Huang
2018-06-03 2:06 ` Fabio Estevam
` (2 more replies)
2018-06-03 2:06 ` [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Fabio Estevam
` (2 subsequent siblings)
3 siblings, 3 replies; 13+ messages in thread
From: Anson Huang @ 2018-06-03 1:44 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, robh+dt, mark.rutland,
mturquette, sboyd, michael, matteo.lisi
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel, linux-clk
i.MX6UL has GPIO clock gates in CCM CCGR, add
clock property for GPIO driver to make sure all
GPIO banks work as expected.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
no changes since V1.
arch/arm/boot/dts/imx6ul.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 1241972..405e068 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -437,6 +437,7 @@
reg = <0x0209c000 0x4000>;
interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6UL_CLK_GPIO1>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -450,6 +451,7 @@
reg = <0x020a0000 0x4000>;
interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6UL_CLK_GPIO2>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -462,6 +464,7 @@
reg = <0x020a4000 0x4000>;
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6UL_CLK_GPIO3>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -474,6 +477,7 @@
reg = <0x020a8000 0x4000>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6UL_CLK_GPIO4>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -486,6 +490,7 @@
reg = <0x020ac000 0x4000>;
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks IMX6UL_CLK_GPIO5>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
@ 2018-06-03 2:06 ` Fabio Estevam
2018-06-03 20:57 ` Fabio Estevam
2018-06-25 3:14 ` Anson Huang
2 siblings, 0 replies; 13+ messages in thread
From: Fabio Estevam @ 2018-06-03 2:06 UTC (permalink / raw)
To: Anson Huang
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Michael Turquette, Stephen Boyd, Michael Trimarchi,
Matteo Lisi, NXP Linux Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, linux-clk
On Sat, Jun 2, 2018 at 10:44 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> i.MX6UL has GPIO clock gates in CCM CCGR, add
> clock property for GPIO driver to make sure all
> GPIO banks work as expected.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
2018-06-03 2:06 ` Fabio Estevam
@ 2018-06-03 20:57 ` Fabio Estevam
2018-06-25 3:14 ` Anson Huang
2 siblings, 0 replies; 13+ messages in thread
From: Fabio Estevam @ 2018-06-03 20:57 UTC (permalink / raw)
To: Anson Huang
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Michael Turquette, Stephen Boyd, Michael Trimarchi,
Matteo Lisi, NXP Linux Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, linux-clk
On Sat, Jun 2, 2018 at 10:44 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> i.MX6UL has GPIO clock gates in CCM CCGR, add
> clock property for GPIO driver to make sure all
> GPIO banks work as expected.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
2018-06-03 2:06 ` Fabio Estevam
2018-06-03 20:57 ` Fabio Estevam
@ 2018-06-25 3:14 ` Anson Huang
2018-06-28 0:52 ` Shawn Guo
2 siblings, 1 reply; 13+ messages in thread
From: Anson Huang @ 2018-06-25 3:14 UTC (permalink / raw)
To: shawnguo, kernel, Fabio Estevam, robh+dt, mark.rutland,
mturquette, sboyd, michael, matteo.lisi
Cc: dl-linux-imx, linux-arm-kernel, devicetree, linux-kernel, linux-clk
Gentle Ping...
Anson Huang
Best Regards!
> -----Original Message-----
> From: Anson Huang
> Sent: Sunday, June 3, 2018 9:44 AM
> To: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam
> <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com;
> mturquette@baylibre.com; sboyd@kernel.org;
> michael@amarulasolutions.com; matteo.lisi@engicam.com
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-clk@vger.kernel.org
> Subject: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
>
> i.MX6UL has GPIO clock gates in CCM CCGR, add clock property for GPIO driver
> to make sure all GPIO banks work as expected.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> no changes since V1.
> arch/arm/boot/dts/imx6ul.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 1241972..405e068 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -437,6 +437,7 @@
> reg = <0x0209c000 0x4000>;
> interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6UL_CLK_GPIO1>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -450,6 +451,7 @@
> reg = <0x020a0000 0x4000>;
> interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6UL_CLK_GPIO2>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -462,6 +464,7 @@
> reg = <0x020a4000 0x4000>;
> interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6UL_CLK_GPIO3>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -474,6 +477,7 @@
> reg = <0x020a8000 0x4000>;
> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6UL_CLK_GPIO4>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -486,6 +490,7 @@
> reg = <0x020ac000 0x4000>;
> interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX6UL_CLK_GPIO5>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-25 3:14 ` Anson Huang
@ 2018-06-28 0:52 ` Shawn Guo
2018-06-29 18:39 ` Stephen Boyd
0 siblings, 1 reply; 13+ messages in thread
From: Shawn Guo @ 2018-06-28 0:52 UTC (permalink / raw)
To: Anson Huang
Cc: kernel, Fabio Estevam, robh+dt, mark.rutland, mturquette, sboyd,
michael, matteo.lisi, dl-linux-imx, linux-arm-kernel, devicetree,
linux-kernel, linux-clk
On Mon, Jun 25, 2018 at 03:14:39AM +0000, Anson Huang wrote:
> Gentle Ping...
I cannot apply this dts patch until the clock patch is landed on
mainline, because it has a dependency on new clock ID IMX6UL_CLK_GPIO1
created by clock patch.
Shawn
> > -----Original Message-----
> > From: Anson Huang
> > Sent: Sunday, June 3, 2018 9:44 AM
> > To: shawnguo@kernel.org; kernel@pengutronix.de; Fabio Estevam
> > <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com;
> > mturquette@baylibre.com; sboyd@kernel.org;
> > michael@amarulasolutions.com; matteo.lisi@engicam.com
> > Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-clk@vger.kernel.org
> > Subject: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
> >
> > i.MX6UL has GPIO clock gates in CCM CCGR, add clock property for GPIO driver
> > to make sure all GPIO banks work as expected.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > no changes since V1.
> > arch/arm/boot/dts/imx6ul.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > index 1241972..405e068 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -437,6 +437,7 @@
> > reg = <0x0209c000 0x4000>;
> > interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX6UL_CLK_GPIO1>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > @@ -450,6 +451,7 @@
> > reg = <0x020a0000 0x4000>;
> > interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX6UL_CLK_GPIO2>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > @@ -462,6 +464,7 @@
> > reg = <0x020a4000 0x4000>;
> > interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX6UL_CLK_GPIO3>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > @@ -474,6 +477,7 @@
> > reg = <0x020a8000 0x4000>;
> > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX6UL_CLK_GPIO4>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > @@ -486,6 +490,7 @@
> > reg = <0x020ac000 0x4000>;
> > interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX6UL_CLK_GPIO5>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > --
> > 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-28 0:52 ` Shawn Guo
@ 2018-06-29 18:39 ` Stephen Boyd
2018-07-01 2:19 ` Shawn Guo
0 siblings, 1 reply; 13+ messages in thread
From: Stephen Boyd @ 2018-06-29 18:39 UTC (permalink / raw)
To: Anson Huang, Shawn Guo
Cc: mark.rutland, devicetree, matteo.lisi, mturquette, linux-kernel,
robh+dt, dl-linux-imx, kernel, Fabio Estevam, michael, linux-clk,
linux-arm-kernel
Quoting Shawn Guo (2018-06-27 17:52:18)
> On Mon, Jun 25, 2018 at 03:14:39AM +0000, Anson Huang wrote:
> > Gentle Ping...
>
> I cannot apply this dts patch until the clock patch is landed on
> mainline, because it has a dependency on new clock ID IMX6UL_CLK_GPIO1
> created by clock patch.
>
Does it matter if that clk ID changes across branches? Or is everything
good if it just exists as some number? The patch adding the define
conflicts with another patch to fix the numbering scheme to be
incremental instead of changing IMX6UL and IMX6ULL which is annoying.
I'll probably make a topic branch just for the fix and merge it into
clk-fixes and this branch so you can pick it up from there if you like.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-06-29 18:39 ` Stephen Boyd
@ 2018-07-01 2:19 ` Shawn Guo
2018-07-06 17:15 ` Stephen Boyd
0 siblings, 1 reply; 13+ messages in thread
From: Shawn Guo @ 2018-07-01 2:19 UTC (permalink / raw)
To: Stephen Boyd
Cc: Anson Huang, mark.rutland, devicetree, matteo.lisi, mturquette,
linux-kernel, robh+dt, dl-linux-imx, kernel, Fabio Estevam,
michael, linux-clk, linux-arm-kernel
On Fri, Jun 29, 2018 at 11:39:38AM -0700, Stephen Boyd wrote:
> Quoting Shawn Guo (2018-06-27 17:52:18)
> > On Mon, Jun 25, 2018 at 03:14:39AM +0000, Anson Huang wrote:
> > > Gentle Ping...
> >
> > I cannot apply this dts patch until the clock patch is landed on
> > mainline, because it has a dependency on new clock ID IMX6UL_CLK_GPIO1
> > created by clock patch.
> >
>
> Does it matter if that clk ID changes across branches? Or is everything
> good if it just exists as some number?
We use macro IMX6UL_CLK_GPIO1 instead of hard-coded number in DTS. So
it doesn't matter if IMX6UL_CLK_GPIO1 changes.
> The patch adding the define
> conflicts with another patch to fix the numbering scheme to be
> incremental instead of changing IMX6UL and IMX6ULL which is annoying.
> I'll probably make a topic branch just for the fix and merge it into
> clk-fixes and this branch so you can pick it up from there if you like.
It will be good if you can have a topic branch. Otherwise, we are also
fine to wait till the clock patches lands on mainline.
Shawn
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-07-01 2:19 ` Shawn Guo
@ 2018-07-06 17:15 ` Stephen Boyd
2018-07-11 8:28 ` Shawn Guo
0 siblings, 1 reply; 13+ messages in thread
From: Stephen Boyd @ 2018-07-06 17:15 UTC (permalink / raw)
To: Shawn Guo
Cc: Anson Huang, mark.rutland, devicetree, matteo.lisi, mturquette,
linux-kernel, robh+dt, dl-linux-imx, kernel, Fabio Estevam,
michael, linux-clk, linux-arm-kernel
Quoting Shawn Guo (2018-06-30 19:19:49)
> On Fri, Jun 29, 2018 at 11:39:38AM -0700, Stephen Boyd wrote:
> > Quoting Shawn Guo (2018-06-27 17:52:18)
> > > On Mon, Jun 25, 2018 at 03:14:39AM +0000, Anson Huang wrote:
> > > > Gentle Ping...
> > >
> > > I cannot apply this dts patch until the clock patch is landed on
> > > mainline, because it has a dependency on new clock ID IMX6UL_CLK_GPIO1
> > > created by clock patch.
> > >
> >
> > Does it matter if that clk ID changes across branches? Or is everything
> > good if it just exists as some number?
>
> We use macro IMX6UL_CLK_GPIO1 instead of hard-coded number in DTS. So
> it doesn't matter if IMX6UL_CLK_GPIO1 changes.
>
> > The patch adding the define
> > conflicts with another patch to fix the numbering scheme to be
> > incremental instead of changing IMX6UL and IMX6ULL which is annoying.
> > I'll probably make a topic branch just for the fix and merge it into
> > clk-fixes and this branch so you can pick it up from there if you like.
>
> It will be good if you can have a topic branch. Otherwise, we are also
> fine to wait till the clock patches lands on mainline.
>
Ok. The topic branch is out there as clk-imx-gpio-gates
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
2018-07-06 17:15 ` Stephen Boyd
@ 2018-07-11 8:28 ` Shawn Guo
0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2018-07-11 8:28 UTC (permalink / raw)
To: Stephen Boyd
Cc: Anson Huang, mark.rutland, devicetree, matteo.lisi, mturquette,
linux-kernel, robh+dt, dl-linux-imx, kernel, Fabio Estevam,
michael, linux-clk, linux-arm-kernel
On Fri, Jul 06, 2018 at 10:15:34AM -0700, Stephen Boyd wrote:
> Quoting Shawn Guo (2018-06-30 19:19:49)
> > On Fri, Jun 29, 2018 at 11:39:38AM -0700, Stephen Boyd wrote:
> > > Quoting Shawn Guo (2018-06-27 17:52:18)
> > > > On Mon, Jun 25, 2018 at 03:14:39AM +0000, Anson Huang wrote:
> > > > > Gentle Ping...
> > > >
> > > > I cannot apply this dts patch until the clock patch is landed on
> > > > mainline, because it has a dependency on new clock ID IMX6UL_CLK_GPIO1
> > > > created by clock patch.
> > > >
> > >
> > > Does it matter if that clk ID changes across branches? Or is everything
> > > good if it just exists as some number?
> >
> > We use macro IMX6UL_CLK_GPIO1 instead of hard-coded number in DTS. So
> > it doesn't matter if IMX6UL_CLK_GPIO1 changes.
> >
> > > The patch adding the define
> > > conflicts with another patch to fix the numbering scheme to be
> > > incremental instead of changing IMX6UL and IMX6ULL which is annoying.
> > > I'll probably make a topic branch just for the fix and merge it into
> > > clk-fixes and this branch so you can pick it up from there if you like.
> >
> > It will be good if you can have a topic branch. Otherwise, we are also
> > fine to wait till the clock patches lands on mainline.
> >
>
> Ok. The topic branch is out there as clk-imx-gpio-gates
Thanks. I applied dts patch now.
Shawn
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates
2018-06-03 1:44 [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
@ 2018-06-03 2:06 ` Fabio Estevam
2018-06-05 21:10 ` Rob Herring
2018-06-29 18:42 ` Stephen Boyd
3 siblings, 0 replies; 13+ messages in thread
From: Fabio Estevam @ 2018-06-03 2:06 UTC (permalink / raw)
To: Anson Huang
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring,
Mark Rutland, Michael Turquette, Stephen Boyd, Michael Trimarchi,
Matteo Lisi,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-clk, NXP Linux Team,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
On Sat, Jun 2, 2018 at 10:44 PM, Anson Huang <Anson.Huang@nxp.com> wrote:
> i.MX6UL has GPIO clock gates in CCM CCGR,
> add them into clock tree for clock management.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates
2018-06-03 1:44 [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
2018-06-03 2:06 ` [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Fabio Estevam
@ 2018-06-05 21:10 ` Rob Herring
2018-06-29 18:42 ` Stephen Boyd
3 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2018-06-05 21:10 UTC (permalink / raw)
To: Anson Huang
Cc: shawnguo, kernel, fabio.estevam, mark.rutland, mturquette, sboyd,
michael, matteo.lisi, devicetree, linux-clk, Linux-imx,
linux-arm-kernel, linux-kernel
On Sun, Jun 03, 2018 at 09:44:04AM +0800, Anson Huang wrote:
> i.MX6UL has GPIO clock gates in CCM CCGR,
> add them into clock tree for clock management.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> Move IMX6UL_CLK_GPIOx definition to end of clock table;
> Based on Fabio's patch "[v2] dt-bindings: clock: imx6ul: Do not change the clock definition order".
> drivers/clk/imx/clk-imx6ul.c | 5 +++++
> include/dt-bindings/clock/imx6ul-clock.h | 8 +++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates
2018-06-03 1:44 [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
` (2 preceding siblings ...)
2018-06-05 21:10 ` Rob Herring
@ 2018-06-29 18:42 ` Stephen Boyd
3 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2018-06-29 18:42 UTC (permalink / raw)
To: Anson Huang, fabio.estevam, kernel, mark.rutland, matteo.lisi,
michael, mturquette, robh+dt, shawnguo
Cc: devicetree, linux-clk, Linux-imx, linux-arm-kernel, linux-kernel
Quoting Anson Huang (2018-06-02 18:44:04)
> i.MX6UL has GPIO clock gates in CCM CCGR,
> add them into clock tree for clock management.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-07-11 8:29 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-03 1:44 [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
2018-06-03 2:06 ` Fabio Estevam
2018-06-03 20:57 ` Fabio Estevam
2018-06-25 3:14 ` Anson Huang
2018-06-28 0:52 ` Shawn Guo
2018-06-29 18:39 ` Stephen Boyd
2018-07-01 2:19 ` Shawn Guo
2018-07-06 17:15 ` Stephen Boyd
2018-07-11 8:28 ` Shawn Guo
2018-06-03 2:06 ` [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Fabio Estevam
2018-06-05 21:10 ` Rob Herring
2018-06-29 18:42 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).