linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes
@ 2021-03-06 11:28 peng.fan
  2021-03-06 12:46 ` Fabio Estevam
  0 siblings, 1 reply; 2+ messages in thread
From: peng.fan @ 2021-03-06 11:28 UTC (permalink / raw)
  To: shawnguo, s.hauer, robh+dt
  Cc: kernel, festevam, linux-imx, linux-arm-kernel, linux-kernel,
	devicetree, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

There is wdog[2,3] in i.MX8MP, so add them, all wdogs share the
same clock root, so use the wdog1 clk here.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index c7523fd4eae9..05dd04116f2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -312,6 +312,22 @@ wdog1: watchdog@30280000 {
 				status = "disabled";
 			};
 
+			wdog2: watchdog@30290000 {
+				compatible = "fsl,imx8mp-wdt", "fsl,imx21-wdt";
+				reg = <0x30290000 0x10000>;
+				interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MP_CLK_WDOG2_ROOT>;
+				status = "disabled";
+			};
+
+			wdog3: watchdog@302a0000 {
+				compatible = "fsl,imx8mp-wdt", "fsl,imx21-wdt";
+				reg = <0x302a0000 0x10000>;
+				interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MP_CLK_WDOG3_ROOT>;
+				status = "disabled";
+			};
+
 			iomuxc: pinctrl@30330000 {
 				compatible = "fsl,imx8mp-iomuxc";
 				reg = <0x30330000 0x10000>;
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes
  2021-03-06 11:28 [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes peng.fan
@ 2021-03-06 12:46 ` Fabio Estevam
  0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2021-03-06 12:46 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Sascha Hauer,
	NXP Linux Team,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Peng Fan

Hi Peng,

On Sat, Mar 6, 2021 at 8:41 AM <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> There is wdog[2,3] in i.MX8MP, so add them, all wdogs share the
> same clock root, so use the wdog1 clk here.

The patch looks good, but I don't understand this sentence where you
state that "all wdogs share the same clock root, so use the wdog1 clk
here."

wdog1 uses IMX8MP_CLK_WDOG1_ROOT
wdog2 uses IMX8MP_CLK_WDOG2_ROOT
wdog3 uses IMX8MP_CLK_WDOG3_ROOT

Please clarify.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-06 12:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-06 11:28 [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes peng.fan
2021-03-06 12:46 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).